Merge pull request #106 from hannasution/bug-search-undefined

medyo · web-flow · commit 545af1fad7db · 2022-12-17T12:05:12.000+01:00
fixed undefined bug when doing a search
diff --git a/src/components/Elements/SearchBar/SearchBar.tsx b/src/components/Elements/SearchBar/SearchBar.tsx
@@ -20,7 +20,7 @@ export const SearchBar = () => {
     }
 
     trackSearchEngineUse(usedSearchEngine.label)
-    window.open(`${usedSearchEngine.url}${target.keyword}`, '_self')
+    window.open(`${usedSearchEngine.url}${target.keyword.value}`, '_self')
   }
 
   useEffect(() => {
@@ -33,6 +33,7 @@ export const SearchBar = () => {
       <input
         ref={keywordsInputRef}
         type="text"
+        name="keyword"
         className="searchBarInput"
         placeholder={`Search on ${usedSearchEngine.label}`}
       />

Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@ export const SearchBar = () => {`
`20`	`20`	`}`
`21`	`21`
`22`	`22`	`trackSearchEngineUse(usedSearchEngine.label)`
`23`		- window.open(`${usedSearchEngine.url}${target.keyword}`, '_self')
	`23`	+ window.open(`${usedSearchEngine.url}${target.keyword.value}`, '_self')
`24`	`24`	`}`
`25`	`25`
`26`	`26`	`useEffect(() => {`
`@@ -33,6 +33,7 @@ export const SearchBar = () => {`
`33`	`33`	`<input`
`34`	`34`	`ref={keywordsInputRef}`
`35`	`35`	`type="text"`
	`36`	`+ name="keyword"`
`36`	`37`	`className="searchBarInput"`
`37`	`38`	placeholder={`Search on ${usedSearchEngine.label}`}
`38`	`39`	`/>`