Skip to content

Commit 72a66d5

Browse files
committed
fix first run analytics events
1 parent 6afa461 commit 72a66d5

4 files changed

Lines changed: 8 additions & 4 deletions

File tree

src/cards/DevToCard.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,6 @@ function DevToCard({ analyticsTag, label, icon, withAds }) {
7474

7575
useEffect(() => {
7676
if (selectedLanguage) {
77-
trackCardLanguageChange('Devto', selectedLanguage.value)
7877
dispatcher({
7978
type: 'setCardSettings',
8079
value: { card: label.toLowerCase(), language: selectedLanguage.label },
@@ -141,6 +140,7 @@ function DevToCard({ analyticsTag, label, icon, withAds }) {
141140
setSelectedTag={setSelectedLanguage}
142141
fallbackTag={GLOBAL_TAG}
143142
cardSettings={cardsSettings?.devto?.language}
143+
trackEvent={(tag) => trackCardLanguageChange('Devto', tag.value)}
144144
data={userSelectedTags.map((tag) => ({
145145
label: tag.label,
146146
value: tag.value,

src/cards/HashNodeCard.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,6 @@ function HashNodeCard({ analyticsTag, label, icon, withAds }) {
7474

7575
useEffect(() => {
7676
if (selectedLanguage) {
77-
trackCardLanguageChange('Hashnode', selectedLanguage.value)
7877
dispatcher({
7978
type: 'setCardSettings',
8079
value: { card: label, language: selectedLanguage.label.toLowerCase() },
@@ -132,6 +131,7 @@ function HashNodeCard({ analyticsTag, label, icon, withAds }) {
132131
tagId={HN_MENU_LANGUAGE_ID}
133132
selectedTag={selectedLanguage}
134133
setSelectedTag={setSelectedLanguage}
134+
trackEvent={(tag) => trackCardLanguageChange('Hashnode', tag.value)}
135135
fallbackTag={GLOBAL_TAG}
136136
cardSettings={cardsSettings?.hashnode?.language}
137137
data={userSelectedTags.map((tag) => ({

src/cards/ReposCard.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,6 @@ function ReposCard({ analyticsTag, label, icon, withAds }) {
6969

7070
useEffect(() => {
7171
if (selectedLanguage) {
72-
trackCardLanguageChange('Repos', selectedLanguage.value)
7372
dispatcher({
7473
type: 'setCardSettings',
7574
value: { card: 'repos', language: selectedLanguage.label },
@@ -80,7 +79,6 @@ function ReposCard({ analyticsTag, label, icon, withAds }) {
8079

8180
useEffect(() => {
8281
if (selectedDateRange) {
83-
trackCardLanguageChange('Repos', selectedDateRange.value)
8482
dispatcher({
8583
type: 'setCardSettings',
8684
value: { card: 'repos', dateRange: selectedDateRange.value },
@@ -137,6 +135,7 @@ function ReposCard({ analyticsTag, label, icon, withAds }) {
137135
setSelectedTag={setSelectedLanguage}
138136
fallbackTag={GLOBAL_TAG}
139137
cardSettings={cardsSettings?.repos?.language}
138+
trackEvent={(tag) => trackCardLanguageChange('Repos', tag.value)}
140139
data={userSelectedTags.map((tag) => ({
141140
label: tag.label,
142141
value: tag.value,
@@ -152,6 +151,7 @@ function ReposCard({ analyticsTag, label, icon, withAds }) {
152151
value: Object.keys(dateRangeMapper)[0],
153152
label: Object.values(dateRangeMapper)[0],
154153
}}
154+
trackEvent={(tag) => trackCardLanguageChange('Repos', tag.value)}
155155
cardSettings={cardsSettings?.repos?.dateRange}
156156
data={Object.keys(dateRangeMapper).map((tag) => ({
157157
label: dateRangeMapper[tag],

src/components/SelectableCard.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ function SelectableCard({
1010
fallbackTag,
1111
selectedTag,
1212
setSelectedTag,
13+
trackEvent,
1314
isLanguage = false,
1415
}) {
1516
const preferences = useContext(PreferencesContext)
@@ -58,6 +59,9 @@ function SelectableCard({
5859
setSelectedDropDownItem={(item) => {
5960
const tag = findTagByValue(item.value)
6061
if (tag) {
62+
if (trackEvent) {
63+
trackEvent(tag)
64+
}
6165
setSelectedTag(tag)
6266
}
6367
}}

0 commit comments

Comments
 (0)