Skip to content

Commit 9304d05

Browse files
committed
fix: update hidden class usage in AdvBanner component for improved visibility control
1 parent fc866d7 commit 9304d05

2 files changed

Lines changed: 41 additions & 20 deletions

File tree

src/features/adv/components/AdvBanner.css

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,8 @@
5656
right: 0;
5757
}
5858

59-
.hidden {
59+
.banneradv .hidden,
60+
.carbonCoverTarget .hidden {
6061
width: 0;
6162
height: 0;
6263
display: none;

src/features/adv/components/AdvBanner.tsx

Lines changed: 39 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -56,24 +56,37 @@ export const AdvBanner = ({ feedDisplay = false, loadingState, onAdLoaded }: Adv
5656

5757
if (ad.largeImage) {
5858
return (
59-
<div
60-
className="carbonCoverTarget"
61-
style={
62-
{
63-
'--ad-dynamic-bg-image': `url(${ad.largeImage})`,
64-
'--ad-gradient-color': ad.backgroundColor,
65-
} as React.CSSProperties
66-
}>
67-
<a href={ad.link} className="carbonCover">
68-
<img className="carbonCoverImage" src={ad.largeImage} />
69-
<div className="carbonCoverMain">
70-
<img className="carbonCoverLogo" src={ad.logo} />
71-
<div className="carbonCoverTagline">{ad.companyTagline}</div>
72-
<div className="carbonCoverDescription">{ad.description}</div>
73-
<div className="carbonCoverButton">{ad.callToAction + ' ↗'}</div>
74-
</div>
75-
</a>
76-
</div>
59+
<>
60+
<div
61+
className="carbonCoverTarget"
62+
style={
63+
{
64+
'--ad-dynamic-bg-image': `url(${ad.largeImage})`,
65+
'--ad-gradient-color': ad.backgroundColor,
66+
} as React.CSSProperties
67+
}>
68+
<a href={ad.link} className="carbonCover">
69+
<img className="carbonCoverImage" src={ad.largeImage} />
70+
<div className="carbonCoverMain">
71+
<img className="carbonCoverLogo" src={ad.logo} />
72+
<div className="carbonCoverTagline">{ad.companyTagline}</div>
73+
<div className="carbonCoverDescription">{ad.description}</div>
74+
<div className="carbonCoverButton">{ad.callToAction + ' ↗'}</div>
75+
</div>
76+
</a>
77+
</div>
78+
{ad.viewUrl &&
79+
ad.viewUrl
80+
.split('||')
81+
.map((viewUrl, i) => (
82+
<img
83+
key={i}
84+
src={viewUrl.replace('[timestamp]', `${Math.round(Date.now() / 10000) | 0}`)}
85+
className="hidden"
86+
alt=""
87+
/>
88+
))}
89+
</>
7790
)
7891
}
7992

@@ -112,7 +125,14 @@ export const AdvBanner = ({ feedDisplay = false, loadingState, onAdLoaded }: Adv
112125
{ad.viewUrl &&
113126
ad.viewUrl
114127
.split('||')
115-
.map((viewUrl, i) => <img key={i} src={viewUrl} className="hidden" alt="" />)}
128+
.map((viewUrl, i) => (
129+
<img
130+
key={i}
131+
src={viewUrl.replace('[timestamp]', `${Math.round(Date.now() / 10000) | 0}`)}
132+
className="hidden"
133+
alt=""
134+
/>
135+
))}
116136
</>
117137
)
118138
}

0 commit comments

Comments
 (0)