Skip to content

Commit b4d6048

Browse files
committed
remove marketing banner config from remoteConfig
1 parent 8c37191 commit b4d6048

2 files changed

Lines changed: 15 additions & 14 deletions

File tree

src/features/remoteConfig/stores/remoteConfig.ts

Lines changed: 14 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,15 @@
11
import create from 'zustand';
22
import { persist } from 'zustand/middleware'
3-
import { RemoteConfig, Tag, MarketingBannerConfig } from "../types";
3+
import { RemoteConfig, Tag } from "../types";
44

5-
type ChangelogVersionStore = {
5+
type RemoteConfigStore = {
66
supportedTags: Tag[];
7-
refresh_rate: number | false;
8-
marketingBannerConfig?: MarketingBannerConfig;
7+
marketingBannerConfig?: any;
98
setRemoteConfig: (remoteConfig: RemoteConfig) => void;
109
};
1110

12-
export const useRemoteConfigStore = create(persist<ChangelogVersionStore>((set) => ({
11+
export const useRemoteConfigStore = create(persist<RemoteConfigStore>((set) => ({
1312
marketingBannerConfig: undefined,
14-
refresh_rate: false,
1513
supportedTags: [
1614
{
1715
value: 'javascript',
@@ -27,8 +25,17 @@ export const useRemoteConfigStore = create(persist<ChangelogVersionStore>((set)
2725
],
2826
setRemoteConfig: (remoteConfig: RemoteConfig) =>
2927
set(() => {
30-
return { ...remoteConfig }
28+
const { marketingBannerConfig, ...otherConfigs } = remoteConfig
29+
return { ...otherConfigs }
3130
}),
3231
}), {
3332
name: 'remote_config_storage',
33+
version: 1,
34+
migrate(persistedState, version) {
35+
const newState = persistedState as RemoteConfigStore;
36+
if (version === 0) {
37+
delete newState.marketingBannerConfig
38+
}
39+
return newState;
40+
},
3441
}));

src/features/remoteConfig/types/index.ts

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -19,14 +19,8 @@ export type TagValuesFieldType =
1919
| 'freecodecampValues'
2020
| 'mediumValues'
2121

22-
export type MarketingBannerConfig = {
23-
show: boolean
24-
campaign_name: string
25-
htmlContent: string
26-
}
27-
2822
export type RemoteConfig = {
2923
supportedTags: Tag[]
3024
refresh_rate: number | false,
31-
marketingBannerConfig?: MarketingBannerConfig
25+
marketingBannerConfig?: any
3226
}

0 commit comments

Comments
 (0)