Skip to content

Commit b646b65

Browse files
committed
remove rss cards from display card settings
1 parent 212c465 commit b646b65

1 file changed

Lines changed: 8 additions & 16 deletions

File tree

src/features/settings/components/SettingsModal.tsx

Lines changed: 8 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ import {
1919
trackLanguageRemove,
2020
trackListingModeSelect,
2121
trackRssSourceAdd,
22-
trackRssSourceRemove,
2322
trackSearchEngineSelect,
2423
trackSourceAdd,
2524
trackSourceRemove,
@@ -105,6 +104,11 @@ export const SettingsModal = ({ showSettings, setShowSettings }: SettingsModalPr
105104
}
106105
break
107106
case 'remove-value':
107+
// if removed card is a userCustomCard, remove it
108+
const newUserCustomCards = userCustomCards.filter(
109+
(c) => c.value !== metas.removedValue.value
110+
)
111+
setUserCustomCards(newUserCustomCards)
108112
if (metas.removedValue?.label) {
109113
trackSourceRemove(metas.removedValue.label)
110114
}
@@ -116,6 +120,7 @@ export const SettingsModal = ({ showSettings, setShowSettings }: SettingsModalPr
116120
let type = AVAILABLE_CARDS.find((ac) => ac.value === c.value)?.type
117121
return { id: index, name: c.value, type }
118122
}) as SelectedCard[]
123+
119124
identifyUserCards(newCards.map((card) => card.name))
120125
setSelectedCards(newCards)
121126
setCards(newCards)
@@ -192,19 +197,6 @@ export const SettingsModal = ({ showSettings, setShowSettings }: SettingsModalPr
192197
}
193198
}
194199

195-
const onRssSelectChange = (newCards: MultiValue<OptionType>, metas: ActionMeta<OptionType>) => {
196-
if (metas.action === 'remove-value') {
197-
setUserCustomCards(newCards as SupportedCardType[])
198-
let newSelectedCards = cards.filter(
199-
(c) => c.type !== 'rss' || c.name !== metas.removedValue.value
200-
)
201-
setSelectedCards(newSelectedCards)
202-
setCards(newSelectedCards)
203-
identifyUserCards(newSelectedCards.map((card) => card.name))
204-
trackRssSourceRemove(metas.removedValue.value)
205-
}
206-
}
207-
208200
return (
209201
<ReactModal
210202
isOpen={showSettings}
@@ -277,7 +269,7 @@ export const SettingsModal = ({ showSettings, setShowSettings }: SettingsModalPr
277269
<div className="settingRow">
278270
<p className="settingTitle">Add Custom Source</p>
279271
<div className="settingContent">
280-
<Select
272+
{/* <Select
281273
menuIsOpen={false}
282274
options={[]}
283275
value={userCustomCards}
@@ -287,7 +279,7 @@ export const SettingsModal = ({ showSettings, setShowSettings }: SettingsModalPr
287279
isSearchable={false}
288280
classNamePrefix={'hackertab'}
289281
className={'rss-sources'}
290-
/>
282+
/> */}
291283
<div className="rssUrlControl">
292284
<input
293285
className="rssUrlInput"

0 commit comments

Comments
 (0)