feat: remove ADV-related analytics and user preferences for cleaner code

Author: medyo

src/App.tsx

@@ -1,15 +1,9 @@
 import clsx from 'clsx'
 import { useEffect, useLayoutEffect } from 'react'
 import { DNDLayout } from 'src/components/Layout'
-import {
-  identifyAdvBlocked,
-  setupAnalytics,
-  setupIdentification,
-  trackPageView,
-} from 'src/lib/analytics'
+import { setupAnalytics, setupIdentification, trackPageView } from 'src/lib/analytics'
 import { useUserPreferences } from 'src/stores/preferences'
 import { AppContentLayout } from './components/Layout'
-import { verifyAdvStatus } from './features/adv/utils/status'
 import { lazyImport } from './utils/lazyImport'
 const { OnboardingModal } = lazyImport(() => import('src/features/onboarding'), 'OnboardingModal')
 
@@ -27,7 +21,6 @@ export const App = () => {
   const {
     maxVisibleCards,
     onboardingCompleted,
-    setAdvStatus,
     isDNDModeActive,
     layout,
     DNDDuration,
@@ -42,12 +35,6 @@ export const App = () => {
     document.body.classList.remove('preload')
     setupAnalytics()
     setupIdentification()
-    const adVerifier = async () => {
-      const status = await verifyAdvStatus()
-      setAdvStatus(status)
-      identifyAdvBlocked(status)
-    }
-    adVerifier()
   }, [])
 
   useEffect(() => {

src/lib/analytics.ts

@@ -76,7 +76,6 @@ export enum Attributes {
   MAX_VISIBLE_CARDS = 'Max Visible Cards',
   DURATION = 'Duration',
   PROVIDER = 'Provider',
-  ADV = 'ADV',
   STREAK = 'Streak',
   DISPLAY_LAYOUT = 'Display Layout',
 }
@@ -467,9 +466,6 @@ export const identifyUserOccupation = (occupation: string) => {
 export const identifyUserMaxVisibleCards = (maxVisibleCards: number) => {
   identifyUserProperty(Attributes.MAX_VISIBLE_CARDS, maxVisibleCards)
 }
-export const identifyAdvBlocked = (blocked: boolean) => {
-  identifyUserProperty(Attributes.ADV, blocked)
-}
 export const identifyUserStreak = (value: number) => {
   identifyUserProperty(Attributes.STREAK, value)
 }

src/stores/preferences.ts

@@ -34,7 +34,6 @@ export type UserPreferencesState = {
   cardsSettings: Record<string, CardSettingsType>
   firstSeenDate: number
   userCustomCards: SupportedCardType[]
-  advStatus: boolean
   DNDDuration: DNDDuration
   showReadPosts: boolean
 }
@@ -61,7 +60,6 @@ type UserPreferencesStoreActions = {
   isDNDModeActive: () => boolean
   addSearchEngine: (searchEngine: SearchEngineType) => void
   removeSearchEngine: (searchEngineUrl: string) => void
-  setAdvStatus: (status: boolean) => void
   setShowReadPosts: (value: boolean) => void
 }
 
@@ -93,7 +91,6 @@ export const useUserPreferences = create(
       ],
       userCustomCards: [],
       DNDDuration: 'never',
-      advStatus: false,
       showReadPosts: true,
       setLayout: (layout) => set({ layout }),
       setPromptEngine: (promptEngine: string) => set({ promptEngine }),
@@ -168,7 +165,6 @@ export const useUserPreferences = create(
             promptEngines: state.promptEngines.filter((se) => se.url !== engine),
           }
         }),
-      setAdvStatus: (status) => set({ advStatus: status }),
       setShowReadPosts: (value) => set({ showReadPosts: value }),
       removeCard: (cardName: string) =>
         set((state) => {