Skip to content

Commit f0b1872

Browse files
committed
fix dispying the right label for 'today stars'
1 parent b3258c8 commit f0b1872

File tree

3 files changed

+14
-3
lines changed

3 files changed

+14
-3
lines changed

src/features/cards/components/githubCard/GithubCard.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,9 +45,10 @@ export function GithubCard(props: CardPropsType) {
4545
key={item.id}
4646
selectedTag={selectedTag}
4747
analyticsTag={meta.analyticsTag}
48+
dateRange={dateRange}
4849
/>
4950
),
50-
[meta.analyticsTag, selectedTag]
51+
[meta.analyticsTag, selectedTag, dateRange]
5152
)
5253

5354
const headerTitle = useMemo(() => {

src/features/cards/components/githubCard/RepoItem.tsx

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ import { CardItemWithActions, CardLink } from 'src/components/Elements'
22

33
import { VscRepoForked, VscStarFull } from 'react-icons/vsc'
44
import { ColoredLanguagesBadge } from 'src/components/Elements'
5+
import { dateRanges } from 'src/config'
56
import { Attributes } from 'src/lib/analytics'
67
import { useUserPreferences } from 'src/stores/preferences'
78
import { BaseItemPropsType, Repository } from 'src/types'
@@ -10,7 +11,12 @@ function numberWithCommas(x: number | string) {
1011
return x.toString().replace(/\B(?=(\d{3})+(?!\d))/g, ',')
1112
}
1213

13-
const RepoItem = ({ item, selectedTag, analyticsTag }: BaseItemPropsType<Repository>) => {
14+
const RepoItem = ({
15+
item,
16+
selectedTag,
17+
dateRange = '',
18+
analyticsTag,
19+
}: BaseItemPropsType<Repository>) => {
1420
const { listingMode } = useUserPreferences()
1521

1622
return (
@@ -48,7 +54,10 @@ const RepoItem = ({ item, selectedTag, analyticsTag }: BaseItemPropsType<Reposit
4854
{item.stars_in_range && (
4955
<span className="rowItem">
5056
<VscStarFull className="rowItemIcon" />{' '}
51-
{numberWithCommas(item.stars_in_range || 0)} stars today
57+
{numberWithCommas(item.stars_in_range || 0)} stars{' '}
58+
{dateRange
59+
? dateRanges.find((d) => d.value === dateRange)?.label.toLowerCase()
60+
: 'today'}
5261
</span>
5362
)}
5463
{item.forks_count && (

src/types/index.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -138,6 +138,7 @@ export type BaseItemPropsType<
138138
item: T
139139
className?: string
140140
analyticsTag: string
141+
dateRange?: string
141142
selectedTag?: SelectedTag
142143
}
143144

0 commit comments

Comments
 (0)