Skip to content

Commit b42d82f

Browse files
committed
Revert "fix: we also need the attributes on iframes"
This reverts commit 31da8b7.
1 parent 31da8b7 commit b42d82f

12 files changed

+26
-28
lines changed

demo/index.html

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ <h1>
131131
<main>
132132
<!-- Lazy-load an offscreen image when the user scrolls near it -->
133133
<img
134-
src="img/lazyimg-src-loadinglazy.250x150.guetzli.jpg?loading=lazy&asset-width=250&asset-height=150"
134+
src="img/lazyimg-src-loadinglazy.250x150.guetzli.jpg?loading=lazy&image-width=250&image-height=150"
135135
loading="lazy"
136136
alt=""
137137
width="250"
@@ -152,18 +152,18 @@ <h1>
152152
<source
153153
media="(min-width: 40em)"
154154
srcset="
155-
img/lazypicture-media1x-loadinglazy.250x150.guetzli.jpg?loading=lazy&asset-width=250&asset-height=150 1x,
156-
img/lazypicture-media2x-loadinglazy.500x300.guetzli.jpg?loading=lazy&asset-width=500&asset-height=300 2x
155+
img/lazypicture-media1x-loadinglazy.250x150.guetzli.jpg?loading=lazy&image-width=250&image-height=150 1x,
156+
img/lazypicture-media2x-loadinglazy.500x300.guetzli.jpg?loading=lazy&image-width=500&image-height=300 2x
157157
"
158158
/>
159159
<source
160160
srcset="
161-
img/lazypicture-1x-loadinglazy.250x150.guetzli.jpg?loading=lazy&asset-width=250&asset-height=150 1x,
162-
img/lazypicture-2x-loadinglazy.500x300.guetzli.jpg?loading=lazy&asset-width=500&asset-height=300 2x
161+
img/lazypicture-1x-loadinglazy.250x150.guetzli.jpg?loading=lazy&image-width=250&image-height=150 1x,
162+
img/lazypicture-2x-loadinglazy.500x300.guetzli.jpg?loading=lazy&image-width=500&image-height=300 2x
163163
"
164164
/>
165165
<img
166-
src="img/lazypicture-imgsrc-loadinglazy.250x150.guetzli.jpg?loading=lazy&asset-width=250&asset-height=150"
166+
src="img/lazypicture-imgsrc-loadinglazy.250x150.guetzli.jpg?loading=lazy&image-width=250&image-height=150"
167167
loading="lazy"
168168
alt=""
169169
width="250"
@@ -173,11 +173,11 @@ <h1>
173173

174174
<!-- Lazy-load an image that has srcset specified -->
175175
<img
176-
src="img/lazyimg-src-loadinglazy.250x150.guetzli.jpg?loading=lazy&asset-width=250&asset-height=150"
176+
src="img/lazyimg-src-loadinglazy.250x150.guetzli.jpg?loading=lazy&image-width=250&image-height=150"
177177
srcset="
178-
img/lazyimg-srcset1024w-loadinglazy.1024x614.guetzli.jpg?loading=lazy&asset-width=1024&asset-height=614 1024w,
179-
img/lazyimg-srcset640w-loadinglazy.640x384.guetzli.jpg?loading=lazy&asset-width=640&asset-height=384 640w,
180-
img/lazyimg-srcset320w-loadinglazy.320x192.guetzli.jpg?loading=lazy&asset-width=320&asset-height=192 320w
178+
img/lazyimg-srcset1024w-loadinglazy.1024x614.guetzli.jpg?loading=lazy&image-width=1024&image-height=614 1024w,
179+
img/lazyimg-srcset640w-loadinglazy.640x384.guetzli.jpg?loading=lazy&image-width=640&image-height=384 640w,
180+
img/lazyimg-srcset320w-loadinglazy.320x192.guetzli.jpg?loading=lazy&image-width=320&image-height=192 320w
181181
"
182182
sizes="(min-width: 36em) 33.3vw, 100vw"
183183
alt=""
@@ -188,7 +188,7 @@ <h1>
188188

189189
<!-- Lazy-load an offscreen iframe when the user scrolls near it -->
190190
<iframe
191-
src="iframe.html?loading=lazy&asset-width=250&asset-height=150"
191+
src="iframe.html?loading=lazy"
192192
width="320"
193193
height="180"
194194
loading="lazy"

demo/index.js

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,17 +8,14 @@ let addDynamicContent = (event) => {
88

99
imageElement.setAttribute(
1010
'src',
11-
'img/lazyimg-src-loadinglazy.250x150.guetzli.jpg?loading=lazy&asset-width=250&asset-height=150'
11+
'img/lazyimg-src-loadinglazy.250x150.guetzli.jpg?loading=lazy&image-width=250&image-height=150'
1212
);
1313
imageElement.setAttribute('loading', 'lazy');
1414
imageElement.setAttribute('alt', '..');
1515
imageElement.setAttribute('width', '250');
1616
imageElement.setAttribute('height', '150');
1717

18-
iframeElement.setAttribute(
19-
'src',
20-
'iframe.html?loading=lazy&asset-width=250&asset-height=150'
21-
);
18+
iframeElement.setAttribute('src', 'iframe.html?loading=lazy');
2219
iframeElement.setAttribute('loading', 'lazy');
2320
iframeElement.setAttribute('title', '..');
2421
iframeElement.setAttribute('width', '320');

dist/loading-attribute-polyfill.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/loading-attribute-polyfill.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/loading-attribute-polyfill.modern.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/loading-attribute-polyfill.modern.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/loading-attribute-polyfill.module.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)