Skip to content

Commit 401b274

Browse files
jschick04NikTilton
authored andcommitted
Updated warnings to be treated as errors and resolved remaining errors
1 parent fec05dc commit 401b274

9 files changed

Lines changed: 70 additions & 64 deletions

File tree

src/Directory.Build.props

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
<Project>
22
<PropertyGroup>
33
<ImplicitUsings>enable</ImplicitUsings>
4-
<Nullable>enable</Nullable>
4+
<Nullable>enable</Nullable>
5+
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
56
</PropertyGroup>
67

78
<Choose>

src/EventLogExpert.Eventing.Tests/EventProviderDatabase/EventProviderDbContextTests.cs

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -248,7 +248,7 @@ public void ProviderDetails_ShouldCompressLargeData()
248248
var dbPath = CreateTempDatabasePath();
249249

250250
var largeMessages = Enumerable.Range(1, 100)
251-
.Select(i => new MessageModel { RawId = i, Text = new string('A', 1000) })
251+
.Select(i => new MessageModel { ProviderName = "LargeProvider", RawId = i, Text = new string('A', 1000) })
252252
.ToList();
253253

254254
var provider = new ProviderDetails
@@ -301,7 +301,7 @@ public void ProviderDetails_Update_ShouldModifyExistingRecord()
301301
context.ProviderDetails.Add(new ProviderDetails
302302
{
303303
ProviderName = providerName,
304-
Messages = [new MessageModel { RawId = 1, Text = "Original" }],
304+
Messages = [new MessageModel { ProviderName = providerName, RawId = 1, Text = "Original" }],
305305
Parameters = [],
306306
Events = [],
307307
Keywords = new Dictionary<long, string>(),
@@ -316,7 +316,7 @@ public void ProviderDetails_Update_ShouldModifyExistingRecord()
316316
using (var context = new EventProviderDbContext(dbPath, false))
317317
{
318318
var provider = context.ProviderDetails.First(p => p.ProviderName == providerName);
319-
provider.Messages = [new MessageModel { RawId = 1, Text = "Updated" }];
319+
provider.Messages = [new MessageModel { ProviderName = providerName, RawId = 1, Text = "Updated" }];
320320
context.SaveChanges();
321321
}
322322

@@ -339,19 +339,19 @@ public void ProviderDetails_WithComplexData_ShouldPreserveAllFields()
339339
ProviderName = "ComplexProvider",
340340
Messages =
341341
[
342-
new MessageModel { RawId = 1, Text = "Message1" },
343-
new MessageModel { RawId = 2, Text = "Message2" },
344-
new MessageModel { RawId = 3, Text = "Message3" }
342+
new MessageModel { ProviderName = "ComplexProvider", RawId = 1, Text = "Message1" },
343+
new MessageModel { ProviderName = "ComplexProvider", RawId = 2, Text = "Message2" },
344+
new MessageModel { ProviderName = "ComplexProvider", RawId = 3, Text = "Message3" }
345345
],
346346
Parameters =
347347
[
348-
new MessageModel { RawId = 10, Text = "Param1" },
349-
new MessageModel { RawId = 11, Text = "Param2" }
348+
new MessageModel { ProviderName = "ComplexProvider", RawId = 10, Text = "Param1" },
349+
new MessageModel { ProviderName = "ComplexProvider", RawId = 11, Text = "Param2" }
350350
],
351351
Events =
352352
[
353-
new EventModel { Id = 100, Description = "Event1" },
354-
new EventModel { Id = 101, Description = "Event2" }
353+
new EventModel { Id = 100, Keywords = [], Description = "Event1" },
354+
new EventModel { Id = 101, Keywords = [], Description = "Event2" }
355355
],
356356
Keywords = new Dictionary<long, string>
357357
{
@@ -482,7 +482,7 @@ public void ProviderDetails_WithSpecialCharacters_ShouldPersist()
482482
var provider = new ProviderDetails
483483
{
484484
ProviderName = "Special\"Provider'With<>Chars",
485-
Messages = [new MessageModel { RawId = 1, Text = "Message with \"quotes\" and 'apostrophes'" }],
485+
Messages = [new MessageModel { ProviderName = "Special\"Provider'With<>Chars", RawId = 1, Text = "Message with \"quotes\" and 'apostrophes'" }],
486486
Parameters = [],
487487
Events = [],
488488
Keywords = new Dictionary<long, string>(),

0 commit comments

Comments
 (0)