Removed FireAndForget in place of InvokeAsync to ensure render thread and JS play nice together

Author: jschick04

src/EventLogExpert/Components/EventTable.razor.cs

@@ -47,10 +47,10 @@ protected override async Task OnInitializedAsync()
     {
         SelectedEventState.Select(s => s.SelectedEvents);
 
-        SubscribeToAction<EventTableAction.SetActiveTable>(action => ScrollToSelectedEvent().AndForget());
-        SubscribeToAction<EventTableAction.LoadColumnsCompleted>(action => RegisterTableEventHandlers().AndForget());
-        SubscribeToAction<EventTableAction.UpdateCombinedEvents>(action => ScrollToSelectedEvent().AndForget());
-        SubscribeToAction<EventTableAction.UpdateDisplayedEvents>(action => ScrollToSelectedEvent().AndForget());
+        SubscribeToAction<EventTableAction.SetActiveTable>(action => InvokeAsync(ScrollToSelectedEvent));
+        SubscribeToAction<EventTableAction.LoadColumnsCompleted>(action => InvokeAsync(RegisterTableEventHandlers));
+        SubscribeToAction<EventTableAction.UpdateCombinedEvents>(action => InvokeAsync(ScrollToSelectedEvent));
+        SubscribeToAction<EventTableAction.UpdateDisplayedEvents>(action => InvokeAsync(ScrollToSelectedEvent));
 
         _eventTableState = EventTableState.Value;
 

src/EventLogExpert/ExtensionMethods.cs

@@ -1,38 +1,22 @@
 // // Copyright (c) Microsoft Corporation.
 // // Licensed under the MIT License.
 
-using EventLogExpert.Eventing.Helpers;
 using System.Reflection;
 using System.Runtime.Serialization;
-using System.Text;
 
 namespace EventLogExpert;
 
 internal static class ExtensionMethods
 {
-    internal static void AndForget(this Task task, ITraceLogger? logger = null)
+    extension(DateTime time)
     {
-        if (!task.IsCompleted || task.IsFaulted) { _ = ForgetAwaited(task, logger); }
+        internal DateTime ConvertTimeZone(TimeZoneInfo? destinationTime) =>
+            destinationTime is null ? time : TimeZoneInfo.ConvertTimeFromUtc(time, destinationTime);
 
-        static async Task ForgetAwaited(Task task, ITraceLogger? logger = null)
-        {
-            try
-            {
-                await task.ConfigureAwait(false);
-            }
-            catch (Exception ex)
-            {
-                logger?.Trace(ex.Message);
-            }
-        }
+        internal DateTime ConvertTimeZoneToUtc(TimeZoneInfo? destinationTime) =>
+            destinationTime is null ? time : TimeZoneInfo.ConvertTimeToUtc(time, destinationTime);
     }
 
-    internal static DateTime ConvertTimeZone(this DateTime time, TimeZoneInfo? destinationTime) =>
-        destinationTime is null ? time : TimeZoneInfo.ConvertTimeFromUtc(time, destinationTime);
-
-    internal static DateTime ConvertTimeZoneToUtc(this DateTime time, TimeZoneInfo? destinationTime) =>
-        destinationTime is null ? time : TimeZoneInfo.ConvertTimeToUtc(time, destinationTime);
-
     internal static string ToFullString(this Enum value)
     {
         var memberAttribute = value.GetType().GetField(value.ToString())?

src/EventLogExpert/MainPage.xaml.cs

@@ -111,7 +111,7 @@ await MainThread.InvokeOnMainThreadAsync(() =>
         fluxorDispatcher.Dispatch(new FilterCacheAction.LoadFilters());
         fluxorDispatcher.Dispatch(new FilterGroupAction.LoadGroups());
 
-        ProcessCommandLine();
+        _ = ProcessCommandLine();
     }
 
     public void Dispose()
@@ -437,7 +437,7 @@ private void PopulateOtherLogsMenu()
         CreateFlyoutMenu(OpenOtherLogsFlyoutSubitem, names);
     }
 
-    private void ProcessCommandLine()
+    private async Task ProcessCommandLine()
     {
         var args = Environment.GetCommandLineArgs();
 
@@ -446,7 +446,7 @@ private void ProcessCommandLine()
             switch (arg)
             {
                 case not null when arg.EndsWith(".evtx"):
-                    OpenLog(arg, PathType.FilePath).AndForget();
+                    await OpenLog(arg, PathType.FilePath);
                     break;
             }
         }

src/EventLogExpert/Shared/Components/DebugLogModal.razor.cs

@@ -21,7 +21,7 @@ protected internal override async Task Open()
 
     protected override void OnInitialized()
     {
-        TraceLogger.DebugLogLoaded += () => Open().AndForget();
+        TraceLogger.DebugLogLoaded += () => InvokeAsync(Open);
 
         base.OnInitialized();
     }

src/EventLogExpert/Shared/Components/Filters/FilterCacheModal.razor.cs

@@ -25,7 +25,7 @@ public sealed partial class FilterCacheModal
 
     protected override void OnInitialized()
     {
-        SubscribeToAction<FilterCacheAction.OpenMenu>(action => Open().AndForget());
+        SubscribeToAction<FilterCacheAction.OpenMenu>(action => InvokeAsync(Open));
 
         base.OnInitialized();
     }
@@ -44,7 +44,7 @@ private void AddFilter(string filter)
                     IsEnabled = true
                 }));
 
-        Close().AndForget();
+        InvokeAsync(Close);
     }
 
     private async Task ExportFavorites()

src/EventLogExpert/Shared/Components/Filters/FilterGroup.razor.cs

@@ -28,12 +28,12 @@ public sealed partial class FilterGroup
     private void ApplyFilters()
     {
         Dispatcher.Dispatch(new FilterPaneAction.ApplyFilterGroup(Group));
-        Parent.Close().AndForget();
+        InvokeAsync(Parent.Close);
     }
 
-    private void CopyGroup() => Clipboard.SetTextAsync(Group.Filters.Count() > 1 ?
+    private void CopyGroup() => Clipboard.SetTextAsync(Group.Filters.Count > 1 ?
         string.Join(" || ", Group.Filters.Select(filter => $"({filter.Comparison.Value})")) :
-        Group.Filters.First().Comparison.Value);
+        Group.Filters[0].Comparison.Value);
 
     private async Task ExportGroup()
     {

src/EventLogExpert/Shared/Components/Filters/FilterGroupModal.razor.cs

@@ -23,7 +23,7 @@ public sealed partial class FilterGroupModal
 
     protected override void OnInitialized()
     {
-        SubscribeToAction<FilterGroupAction.OpenMenu>(action => Open().AndForget());
+        SubscribeToAction<FilterGroupAction.OpenMenu>(action => InvokeAsync(Open));
 
         base.OnInitialized();
     }

src/EventLogExpert/Shared/Components/SettingsModal.razor.cs

@@ -56,7 +56,7 @@ protected internal override async Task Close()
 
     protected override void OnInitialized()
     {
-        Settings.Loaded += () => Load().AndForget();
+        Settings.Loaded += () => InvokeAsync(Load);
 
         base.OnInitialized();
     }
@@ -101,7 +101,7 @@ private async Task ImportDatabase()
 
             await AlertDialogService.ShowAlert("Import Successful", message, "OK");
 
-            Close().AndForget();
+            await InvokeAsync(Close);
         }
         catch (Exception ex)
         {