feat(emitter): support differing accessor types (#88)

Author: saschanaz

baselines/dom.generated.d.ts

@@ -4320,7 +4320,8 @@ interface Document extends Node, DocumentAndElementEventHandlers, DocumentOrShad
     /**
      * Contains information about the current URL.
      */
-    location: Location;
+    get location(): Location;
+    set location(href: string | Location);
     onfullscreenchange: ((this: Document, ev: Event) => any) | null;
     onfullscreenerror: ((this: Document, ev: Event) => any) | null;
     onpointerlockchange: ((this: Document, ev: Event) => any) | null;
@@ -16958,7 +16959,8 @@ interface Window extends EventTarget, AnimationFrameProvider, GlobalEventHandler
     readonly innerHeight: number;
     readonly innerWidth: number;
     readonly length: number;
-    location: Location;
+    get location(): Location;
+    set location(href: string | Location);
     /**
      * Returns true if the location bar is visible; otherwise, returns false.
      */

package-lock.json

@@ -51,7 +51,7 @@
     "prettier": "^2.2.1",
     "print-diff": "^1.0.0",
     "styleless-innertext": "^1.1.2",
-    "typescript": "^4.2.4",
+    "typescript": "^4.3.0-dev.20210327",
     "webidl2": "^23.13.1"
   },
   "files": [

package.json

@@ -793,11 +793,27 @@ export function emitWebIdl(
       if (p.optional && prefix) {
         pType += " | undefined";
       }
-      const readOnlyModifier = p.readonly && prefix === "" ? "readonly " : "";
       const optionalModifier = !p.optional || prefix ? "" : "?";
-      printer.printLine(
-        `${prefix}${readOnlyModifier}${p.name}${optionalModifier}: ${pType};`
-      );
+      if (!prefix && !p.readonly && p.putForwards) {
+        printer.printLine(`get ${p.name}${optionalModifier}(): ${pType};`);
+
+        const forwardingProperty =
+          allInterfacesMap[pType].properties?.property[p.putForwards];
+        if (!forwardingProperty) {
+          throw new Error("Couldn't find [PutForwards]");
+        }
+        const setterType = `${convertDomTypeToTsType(
+          forwardingProperty
+        )} | ${pType}`;
+        printer.printLine(
+          `set ${p.name}${optionalModifier}(${p.putForwards}: ${setterType});`
+        );
+      } else {
+        const readOnlyModifier = p.readonly && prefix === "" ? "readonly " : "";
+        printer.printLine(
+          `${prefix}${readOnlyModifier}${p.name}${optionalModifier}: ${pType};`
+        );
+      }
     }
 
     if (p.stringifier) {

src/build/emitter.ts

@@ -31,7 +31,7 @@ export interface Property extends Typed {
   eventHandler?: string;
   readonly?: boolean;
   replaceable?: string;
-  "put-forwards"?: string;
+  putForwards?: string;
   stringifier?: boolean;
   tags?: string;
   "property-descriptor-not-enumerable"?: string;

src/build/types.d.ts

@@ -362,6 +362,7 @@ function convertAttribute(
     exposed:
       getExtAttrConcatenated(attribute.extAttrs, "Exposed") ||
       inheritedExposure,
+    putForwards: getExtAttr(attribute.extAttrs, "PutForwards")[0],
   };
 }
 

src/build/widlprocess.ts

@@ -0,0 +1,2 @@
+document.location.href.padStart(3);
+document.location = "abc";