Add null types to optional IDB query parameters (#701)

philipwalton · sandersn · commit a209d6b6e154 · 2019-06-06T14:12:24.000-07:00
diff --git a/baselines/dom.generated.d.ts b/baselines/dom.generated.d.ts
@@ -9196,13 +9196,13 @@ interface IDBIndex {
      * 
      * If successful, request's result will be an Array of the values.
      */
-    getAll(query?: IDBValidKey | IDBKeyRange, count?: number): IDBRequest<any[]>;
+    getAll(query?: IDBValidKey | IDBKeyRange | null, count?: number): IDBRequest<any[]>;
     /**
      * Retrieves the keys of records matching the given key or key range in query (up to count if given).
      * 
      * If successful, request's result will be an Array of the keys.
      */
-    getAllKeys(query?: IDBValidKey | IDBKeyRange, count?: number): IDBRequest<IDBValidKey[]>;
+    getAllKeys(query?: IDBValidKey | IDBKeyRange | null, count?: number): IDBRequest<IDBValidKey[]>;
     /**
      * Retrieves the key of the first record matching the given key or key range in query.
      * 
@@ -9214,13 +9214,13 @@ interface IDBIndex {
      * 
      * If successful, request's result will be an IDBCursorWithValue, or null if there were no matching records.
      */
-    openCursor(range?: IDBValidKey | IDBKeyRange, direction?: IDBCursorDirection): IDBRequest<IDBCursorWithValue | null>;
+    openCursor(query?: IDBValidKey | IDBKeyRange | null, direction?: IDBCursorDirection): IDBRequest<IDBCursorWithValue | null>;
     /**
      * Opens a cursor with key only flag set over the records matching query, ordered by direction. If query is null, all records in index are matched.
      * 
      * If successful, request's result will be an IDBCursor, or null if there were no matching records.
      */
-    openKeyCursor(range?: IDBValidKey | IDBKeyRange, direction?: IDBCursorDirection): IDBRequest<IDBCursor | null>;
+    openKeyCursor(query?: IDBValidKey | IDBKeyRange | null, direction?: IDBCursorDirection): IDBRequest<IDBCursor | null>;
 }
 
 declare var IDBIndex: {
@@ -9346,13 +9346,13 @@ interface IDBObjectStore {
      * 
      * If successful, request's result will be an Array of the values.
      */
-    getAll(query?: IDBValidKey | IDBKeyRange, count?: number): IDBRequest<any[]>;
+    getAll(query?: IDBValidKey | IDBKeyRange | null, count?: number): IDBRequest<any[]>;
     /**
      * Retrieves the keys of records matching the given key or key range in query (up to count if given).
      * 
      * If successful, request's result will be an Array of the keys.
      */
-    getAllKeys(query?: IDBValidKey | IDBKeyRange, count?: number): IDBRequest<IDBValidKey[]>;
+    getAllKeys(query?: IDBValidKey | IDBKeyRange | null, count?: number): IDBRequest<IDBValidKey[]>;
     /**
      * Retrieves the key of the first record matching the given key or key range in query.
      * 
@@ -9365,13 +9365,13 @@ interface IDBObjectStore {
      * 
      * If successful, request's result will be an IDBCursorWithValue pointing at the first matching record, or null if there were no matching records.
      */
-    openCursor(range?: IDBValidKey | IDBKeyRange, direction?: IDBCursorDirection): IDBRequest<IDBCursorWithValue | null>;
+    openCursor(query?: IDBValidKey | IDBKeyRange | null, direction?: IDBCursorDirection): IDBRequest<IDBCursorWithValue | null>;
     /**
      * Opens a cursor with key only flag set over the records matching query, ordered by direction. If query is null, all records in store are matched.
      * 
      * If successful, request's result will be an IDBCursor pointing at the first matching record, or null if there were no matching records.
      */
-    openKeyCursor(query?: IDBValidKey | IDBKeyRange, direction?: IDBCursorDirection): IDBRequest<IDBCursor | null>;
+    openKeyCursor(query?: IDBValidKey | IDBKeyRange | null, direction?: IDBCursorDirection): IDBRequest<IDBCursor | null>;
     /**
      * Adds or updates a record in store with the given value and key.
      * 
diff --git a/baselines/webworker.generated.d.ts b/baselines/webworker.generated.d.ts
@@ -1824,13 +1824,13 @@ interface IDBIndex {
      * 
      * If successful, request's result will be an Array of the values.
      */
-    getAll(query?: IDBValidKey | IDBKeyRange, count?: number): IDBRequest<any[]>;
+    getAll(query?: IDBValidKey | IDBKeyRange | null, count?: number): IDBRequest<any[]>;
     /**
      * Retrieves the keys of records matching the given key or key range in query (up to count if given).
      * 
      * If successful, request's result will be an Array of the keys.
      */
-    getAllKeys(query?: IDBValidKey | IDBKeyRange, count?: number): IDBRequest<IDBValidKey[]>;
+    getAllKeys(query?: IDBValidKey | IDBKeyRange | null, count?: number): IDBRequest<IDBValidKey[]>;
     /**
      * Retrieves the key of the first record matching the given key or key range in query.
      * 
@@ -1842,13 +1842,13 @@ interface IDBIndex {
      * 
      * If successful, request's result will be an IDBCursorWithValue, or null if there were no matching records.
      */
-    openCursor(range?: IDBValidKey | IDBKeyRange, direction?: IDBCursorDirection): IDBRequest<IDBCursorWithValue | null>;
+    openCursor(query?: IDBValidKey | IDBKeyRange | null, direction?: IDBCursorDirection): IDBRequest<IDBCursorWithValue | null>;
     /**
      * Opens a cursor with key only flag set over the records matching query, ordered by direction. If query is null, all records in index are matched.
      * 
      * If successful, request's result will be an IDBCursor, or null if there were no matching records.
      */
-    openKeyCursor(range?: IDBValidKey | IDBKeyRange, direction?: IDBCursorDirection): IDBRequest<IDBCursor | null>;
+    openKeyCursor(query?: IDBValidKey | IDBKeyRange | null, direction?: IDBCursorDirection): IDBRequest<IDBCursor | null>;
 }
 
 declare var IDBIndex: {
@@ -1974,13 +1974,13 @@ interface IDBObjectStore {
      * 
      * If successful, request's result will be an Array of the values.
      */
-    getAll(query?: IDBValidKey | IDBKeyRange, count?: number): IDBRequest<any[]>;
+    getAll(query?: IDBValidKey | IDBKeyRange | null, count?: number): IDBRequest<any[]>;
     /**
      * Retrieves the keys of records matching the given key or key range in query (up to count if given).
      * 
      * If successful, request's result will be an Array of the keys.
      */
-    getAllKeys(query?: IDBValidKey | IDBKeyRange, count?: number): IDBRequest<IDBValidKey[]>;
+    getAllKeys(query?: IDBValidKey | IDBKeyRange | null, count?: number): IDBRequest<IDBValidKey[]>;
     /**
      * Retrieves the key of the first record matching the given key or key range in query.
      * 
@@ -1993,13 +1993,13 @@ interface IDBObjectStore {
      * 
      * If successful, request's result will be an IDBCursorWithValue pointing at the first matching record, or null if there were no matching records.
      */
-    openCursor(range?: IDBValidKey | IDBKeyRange, direction?: IDBCursorDirection): IDBRequest<IDBCursorWithValue | null>;
+    openCursor(query?: IDBValidKey | IDBKeyRange | null, direction?: IDBCursorDirection): IDBRequest<IDBCursorWithValue | null>;
     /**
      * Opens a cursor with key only flag set over the records matching query, ordered by direction. If query is null, all records in store are matched.
      * 
      * If successful, request's result will be an IDBCursor pointing at the first matching record, or null if there were no matching records.
      */
-    openKeyCursor(query?: IDBValidKey | IDBKeyRange, direction?: IDBCursorDirection): IDBRequest<IDBCursor | null>;
+    openKeyCursor(query?: IDBValidKey | IDBKeyRange | null, direction?: IDBCursorDirection): IDBRequest<IDBCursor | null>;
     /**
      * Adds or updates a record in store with the given value and key.
      * 
diff --git a/inputfiles/overridingTypes.json b/inputfiles/overridingTypes.json
@@ -696,13 +696,13 @@
                         "openCursor": {
                             "name": "openCursor",
                             "override-signatures": [
-                                "openCursor(range?: IDBValidKey | IDBKeyRange, direction?: IDBCursorDirection): IDBRequest<IDBCursorWithValue | null>"
+                                "openCursor(query?: IDBValidKey | IDBKeyRange | null, direction?: IDBCursorDirection): IDBRequest<IDBCursorWithValue | null>"
                             ]
                         },
                         "openKeyCursor": {
                             "name": "openKeyCursor",
                             "override-signatures": [
-                                "openKeyCursor(query?: IDBValidKey | IDBKeyRange, direction?: IDBCursorDirection): IDBRequest<IDBCursor | null>"
+                                "openKeyCursor(query?: IDBValidKey | IDBKeyRange | null, direction?: IDBCursorDirection): IDBRequest<IDBCursor | null>"
                             ]
                         },
                         "add": {
@@ -744,13 +744,13 @@
                         "getAll": {
                             "name": "getAll",
                             "override-signatures": [
-                                "getAll(query?: IDBValidKey | IDBKeyRange, count?: number): IDBRequest<any[]>"
+                                "getAll(query?: IDBValidKey | IDBKeyRange | null, count?: number): IDBRequest<any[]>"
                             ]
                         },
                         "getAllKeys": {
                             "name": "getAllKeys",
                             "override-signatures": [
-                                "getAllKeys(query?: IDBValidKey | IDBKeyRange, count?: number): IDBRequest<IDBValidKey[]>"
+                                "getAllKeys(query?: IDBValidKey | IDBKeyRange | null, count?: number): IDBRequest<IDBValidKey[]>"
                             ]
                         },
                         "getKey": {
@@ -802,13 +802,13 @@
                         "openCursor": {
                             "name": "openCursor",
                             "override-signatures": [
-                                "openCursor(range?: IDBValidKey | IDBKeyRange, direction?: IDBCursorDirection): IDBRequest<IDBCursorWithValue | null>"
+                                "openCursor(query?: IDBValidKey | IDBKeyRange | null, direction?: IDBCursorDirection): IDBRequest<IDBCursorWithValue | null>"
                             ]
                         },
                         "openKeyCursor": {
                             "name": "openKeyCursor",
                             "override-signatures": [
-                                "openKeyCursor(range?: IDBValidKey | IDBKeyRange, direction?: IDBCursorDirection): IDBRequest<IDBCursor | null>"
+                                "openKeyCursor(query?: IDBValidKey | IDBKeyRange | null, direction?: IDBCursorDirection): IDBRequest<IDBCursor | null>"
                             ]
                         },
                         "count": {
@@ -826,13 +826,13 @@
                         "getAll": {
                             "name": "getAll",
                             "override-signatures": [
-                                "getAll(query?: IDBValidKey | IDBKeyRange, count?: number): IDBRequest<any[]>"
+                                "getAll(query?: IDBValidKey | IDBKeyRange | null, count?: number): IDBRequest<any[]>"
                             ]
                         },
                         "getAllKeys": {
                             "name": "getAllKeys",
                             "override-signatures": [
-                                "getAllKeys(query?: IDBValidKey | IDBKeyRange, count?: number): IDBRequest<IDBValidKey[]>"
+                                "getAllKeys(query?: IDBValidKey | IDBKeyRange | null, count?: number): IDBRequest<IDBValidKey[]>"
                             ]
                         },
                         "getKey": {

Original file line number	Diff line number	Diff line change
`@@ -9196,13 +9196,13 @@ interface IDBIndex {`
`9196`	`9196`	`*`
`9197`	`9197`	`* If successful, request's result will be an Array of the values.`
`9198`	`9198`	`*/`
`9199`		`- getAll(query?: IDBValidKey \| IDBKeyRange, count?: number): IDBRequest<any[]>;`
	`9199`	`+ getAll(query?: IDBValidKey \| IDBKeyRange \| null, count?: number): IDBRequest<any[]>;`
`9200`	`9200`	`/**`
`9201`	`9201`	`* Retrieves the keys of records matching the given key or key range in query (up to count if given).`
`9202`	`9202`	`*`
`9203`	`9203`	`* If successful, request's result will be an Array of the keys.`
`9204`	`9204`	`*/`
`9205`		`- getAllKeys(query?: IDBValidKey \| IDBKeyRange, count?: number): IDBRequest<IDBValidKey[]>;`
	`9205`	`+ getAllKeys(query?: IDBValidKey \| IDBKeyRange \| null, count?: number): IDBRequest<IDBValidKey[]>;`
`9206`	`9206`	`/**`
`9207`	`9207`	`* Retrieves the key of the first record matching the given key or key range in query.`
`9208`	`9208`	`*`
`@@ -9214,13 +9214,13 @@ interface IDBIndex {`
`9214`	`9214`	`*`
`9215`	`9215`	`* If successful, request's result will be an IDBCursorWithValue, or null if there were no matching records.`
`9216`	`9216`	`*/`
`9217`		`- openCursor(range?: IDBValidKey \| IDBKeyRange, direction?: IDBCursorDirection): IDBRequest<IDBCursorWithValue \| null>;`
	`9217`	`+ openCursor(query?: IDBValidKey \| IDBKeyRange \| null, direction?: IDBCursorDirection): IDBRequest<IDBCursorWithValue \| null>;`
`9218`	`9218`	`/**`
`9219`	`9219`	`* Opens a cursor with key only flag set over the records matching query, ordered by direction. If query is null, all records in index are matched.`
`9220`	`9220`	`*`
`9221`	`9221`	`* If successful, request's result will be an IDBCursor, or null if there were no matching records.`
`9222`	`9222`	`*/`
`9223`		`- openKeyCursor(range?: IDBValidKey \| IDBKeyRange, direction?: IDBCursorDirection): IDBRequest<IDBCursor \| null>;`
	`9223`	`+ openKeyCursor(query?: IDBValidKey \| IDBKeyRange \| null, direction?: IDBCursorDirection): IDBRequest<IDBCursor \| null>;`
`9224`	`9224`	`}`
`9225`	`9225`
`9226`	`9226`	`declare var IDBIndex: {`
`@@ -9346,13 +9346,13 @@ interface IDBObjectStore {`
`9346`	`9346`	`*`
`9347`	`9347`	`* If successful, request's result will be an Array of the values.`
`9348`	`9348`	`*/`
`9349`		`- getAll(query?: IDBValidKey \| IDBKeyRange, count?: number): IDBRequest<any[]>;`
	`9349`	`+ getAll(query?: IDBValidKey \| IDBKeyRange \| null, count?: number): IDBRequest<any[]>;`
`9350`	`9350`	`/**`
`9351`	`9351`	`* Retrieves the keys of records matching the given key or key range in query (up to count if given).`
`9352`	`9352`	`*`
`9353`	`9353`	`* If successful, request's result will be an Array of the keys.`
`9354`	`9354`	`*/`
`9355`		`- getAllKeys(query?: IDBValidKey \| IDBKeyRange, count?: number): IDBRequest<IDBValidKey[]>;`
	`9355`	`+ getAllKeys(query?: IDBValidKey \| IDBKeyRange \| null, count?: number): IDBRequest<IDBValidKey[]>;`
`9356`	`9356`	`/**`
`9357`	`9357`	`* Retrieves the key of the first record matching the given key or key range in query.`
`9358`	`9358`	`*`
`@@ -9365,13 +9365,13 @@ interface IDBObjectStore {`
`9365`	`9365`	`*`
`9366`	`9366`	`* If successful, request's result will be an IDBCursorWithValue pointing at the first matching record, or null if there were no matching records.`
`9367`	`9367`	`*/`
`9368`		`- openCursor(range?: IDBValidKey \| IDBKeyRange, direction?: IDBCursorDirection): IDBRequest<IDBCursorWithValue \| null>;`
	`9368`	`+ openCursor(query?: IDBValidKey \| IDBKeyRange \| null, direction?: IDBCursorDirection): IDBRequest<IDBCursorWithValue \| null>;`
`9369`	`9369`	`/**`
`9370`	`9370`	`* Opens a cursor with key only flag set over the records matching query, ordered by direction. If query is null, all records in store are matched.`
`9371`	`9371`	`*`
`9372`	`9372`	`* If successful, request's result will be an IDBCursor pointing at the first matching record, or null if there were no matching records.`
`9373`	`9373`	`*/`
`9374`		`- openKeyCursor(query?: IDBValidKey \| IDBKeyRange, direction?: IDBCursorDirection): IDBRequest<IDBCursor \| null>;`
	`9374`	`+ openKeyCursor(query?: IDBValidKey \| IDBKeyRange \| null, direction?: IDBCursorDirection): IDBRequest<IDBCursor \| null>;`
`9375`	`9375`	`/**`
`9376`	`9376`	`* Adds or updates a record in store with the given value and key.`
`9377`	`9377`	`*`
Original file line number	Diff line number	Diff line change
`@@ -1824,13 +1824,13 @@ interface IDBIndex {`
`1824`	`1824`	`*`
`1825`	`1825`	`* If successful, request's result will be an Array of the values.`
`1826`	`1826`	`*/`
`1827`		`- getAll(query?: IDBValidKey \| IDBKeyRange, count?: number): IDBRequest<any[]>;`
	`1827`	`+ getAll(query?: IDBValidKey \| IDBKeyRange \| null, count?: number): IDBRequest<any[]>;`
`1828`	`1828`	`/**`
`1829`	`1829`	`* Retrieves the keys of records matching the given key or key range in query (up to count if given).`
`1830`	`1830`	`*`
`1831`	`1831`	`* If successful, request's result will be an Array of the keys.`
`1832`	`1832`	`*/`
`1833`		`- getAllKeys(query?: IDBValidKey \| IDBKeyRange, count?: number): IDBRequest<IDBValidKey[]>;`
	`1833`	`+ getAllKeys(query?: IDBValidKey \| IDBKeyRange \| null, count?: number): IDBRequest<IDBValidKey[]>;`
`1834`	`1834`	`/**`
`1835`	`1835`	`* Retrieves the key of the first record matching the given key or key range in query.`
`1836`	`1836`	`*`
`@@ -1842,13 +1842,13 @@ interface IDBIndex {`
`1842`	`1842`	`*`
`1843`	`1843`	`* If successful, request's result will be an IDBCursorWithValue, or null if there were no matching records.`
`1844`	`1844`	`*/`
`1845`		`- openCursor(range?: IDBValidKey \| IDBKeyRange, direction?: IDBCursorDirection): IDBRequest<IDBCursorWithValue \| null>;`
	`1845`	`+ openCursor(query?: IDBValidKey \| IDBKeyRange \| null, direction?: IDBCursorDirection): IDBRequest<IDBCursorWithValue \| null>;`
`1846`	`1846`	`/**`
`1847`	`1847`	`* Opens a cursor with key only flag set over the records matching query, ordered by direction. If query is null, all records in index are matched.`
`1848`	`1848`	`*`
`1849`	`1849`	`* If successful, request's result will be an IDBCursor, or null if there were no matching records.`
`1850`	`1850`	`*/`
`1851`		`- openKeyCursor(range?: IDBValidKey \| IDBKeyRange, direction?: IDBCursorDirection): IDBRequest<IDBCursor \| null>;`
	`1851`	`+ openKeyCursor(query?: IDBValidKey \| IDBKeyRange \| null, direction?: IDBCursorDirection): IDBRequest<IDBCursor \| null>;`
`1852`	`1852`	`}`
`1853`	`1853`
`1854`	`1854`	`declare var IDBIndex: {`
`@@ -1974,13 +1974,13 @@ interface IDBObjectStore {`
`1974`	`1974`	`*`
`1975`	`1975`	`* If successful, request's result will be an Array of the values.`
`1976`	`1976`	`*/`
`1977`		`- getAll(query?: IDBValidKey \| IDBKeyRange, count?: number): IDBRequest<any[]>;`
	`1977`	`+ getAll(query?: IDBValidKey \| IDBKeyRange \| null, count?: number): IDBRequest<any[]>;`
`1978`	`1978`	`/**`
`1979`	`1979`	`* Retrieves the keys of records matching the given key or key range in query (up to count if given).`
`1980`	`1980`	`*`
`1981`	`1981`	`* If successful, request's result will be an Array of the keys.`
`1982`	`1982`	`*/`
`1983`		`- getAllKeys(query?: IDBValidKey \| IDBKeyRange, count?: number): IDBRequest<IDBValidKey[]>;`
	`1983`	`+ getAllKeys(query?: IDBValidKey \| IDBKeyRange \| null, count?: number): IDBRequest<IDBValidKey[]>;`
`1984`	`1984`	`/**`
`1985`	`1985`	`* Retrieves the key of the first record matching the given key or key range in query.`
`1986`	`1986`	`*`
`@@ -1993,13 +1993,13 @@ interface IDBObjectStore {`
`1993`	`1993`	`*`
`1994`	`1994`	`* If successful, request's result will be an IDBCursorWithValue pointing at the first matching record, or null if there were no matching records.`
`1995`	`1995`	`*/`
`1996`		`- openCursor(range?: IDBValidKey \| IDBKeyRange, direction?: IDBCursorDirection): IDBRequest<IDBCursorWithValue \| null>;`
	`1996`	`+ openCursor(query?: IDBValidKey \| IDBKeyRange \| null, direction?: IDBCursorDirection): IDBRequest<IDBCursorWithValue \| null>;`
`1997`	`1997`	`/**`
`1998`	`1998`	`* Opens a cursor with key only flag set over the records matching query, ordered by direction. If query is null, all records in store are matched.`
`1999`	`1999`	`*`
`2000`	`2000`	`* If successful, request's result will be an IDBCursor pointing at the first matching record, or null if there were no matching records.`
`2001`	`2001`	`*/`
`2002`		`- openKeyCursor(query?: IDBValidKey \| IDBKeyRange, direction?: IDBCursorDirection): IDBRequest<IDBCursor \| null>;`
	`2002`	`+ openKeyCursor(query?: IDBValidKey \| IDBKeyRange \| null, direction?: IDBCursorDirection): IDBRequest<IDBCursor \| null>;`
`2003`	`2003`	`/**`
`2004`	`2004`	`* Adds or updates a record in store with the given value and key.`
`2005`	`2005`	`*`