PM / devfreq: mtk-cci: avoid redundant conditions

LiaoYuanhong-vivo · chanwoochoi · commit 6d0982ae7880 · 2025-09-08T17:19:25.000+09:00
While 'if (i <= 0) ... else if (i > 0) ...' is technically equivalent to 'if (i <= 0) ... else ...', the latter is vastly easier to read because it avoids writing out a condition that is unnecessary. Let's drop such unnecessary conditions. Signed-off-by: Liao Yuanhong <liaoyuanhong@vivo.com> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> Link: https://patchwork.kernel.org/project/linux-pm/patch/20250903121452.387023-1-liaoyuanhong@vivo.com/
diff --git a/drivers/devfreq/mtk-cci-devfreq.c b/drivers/devfreq/mtk-cci-devfreq.c
@@ -86,7 +86,7 @@ static int mtk_ccifreq_set_voltage(struct mtk_ccifreq_drv *drv, int new_voltage)
 						      soc_data->sram_max_volt);
 				return ret;
 			}
-		} else if (pre_voltage > new_voltage) {
+		} else {
 			voltage = max(new_voltage,
 				      pre_vsram - soc_data->max_volt_shift);
 			ret = regulator_set_voltage(drv->proc_reg, voltage,

Original file line number	Diff line number	Diff line change
`@@ -86,7 +86,7 @@ static int mtk_ccifreq_set_voltage(struct mtk_ccifreq_drv *drv, int new_voltage)`
`86`	`86`	`soc_data->sram_max_volt);`
`87`	`87`	`return ret;`
`88`	`88`	`}`
`89`		`- } else if (pre_voltage > new_voltage) {`
	`89`	`+ } else {`
`90`	`90`	`voltage = max(new_voltage,`
`91`	`91`	`pre_vsram - soc_data->max_volt_shift);`
`92`	`92`	`ret = regulator_set_voltage(drv->proc_reg, voltage,`