Skip to content

Commit 9395b3c

Browse files
jhnikulaalexandrebelloni
authored andcommitted
i3c: Fix default I2C adapter timeout value
Commit 3a379bb ("i3c: Add core I3C infrastructure") set the default adapter timeout for I2C transfers as 1000 (ms). However that parameter is defined in jiffies not in milliseconds. With mipi-i3c-hci driver this wasn't visible until commit c0a90eb ("i3c: mipi-i3c-hci: use adapter timeout value for I2C transfers"). Fix this by setting the default timeout as HZ (CONFIG_HZ) not 1000. Fixes: 1b84691 ("i3c: dw: use adapter timeout value for I2C transfers") Fixes: be27ed6 ("i3c: master: cdns: use adapter timeout value for I2C transfers") Fixes: c0a90eb ("i3c: mipi-i3c-hci: use adapter timeout value for I2C transfers") Fixes: a747e01 ("i3c: master: svc: use adapter timeout value for I2C transfers") Fixes: d028219 ("i3c: master: Add basic driver for the Renesas I3C controller") Fixes: 3a379bb ("i3c: Add core I3C infrastructure") Cc: stable@vger.kernel.org # 6.17 Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com> Reviewed-by: Frank Li <Frank.Li@nxp.com> Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Link: https://lore.kernel.org/r/20250905100320.954536-1-jarkko.nikula@linux.intel.com Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
1 parent a4ea64a commit 9395b3c

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/i3c/master.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2566,7 +2566,7 @@ static int i3c_master_i2c_adapter_init(struct i3c_master_controller *master)
25662566
strscpy(adap->name, dev_name(master->dev.parent), sizeof(adap->name));
25672567

25682568
/* FIXME: Should we allow i3c masters to override these values? */
2569-
adap->timeout = 1000;
2569+
adap->timeout = HZ;
25702570
adap->retries = 3;
25712571

25722572
id = of_alias_get_id(master->dev.of_node, "i2c");

0 commit comments

Comments
 (0)