Skip to content

Commit c99d627

Browse files
author
Marc Zyngier
committed
KVM: arm64: Enforce absence of FEAT_HCX on HCRX_EL2
Add the dependency between the HCRX_EL2 register and FEAT_HCX. Reviewed-by: Oliver Upton <oliver.upton@linux.dev> Signed-off-by: Marc Zyngier <maz@kernel.org>
1 parent 338a41e commit c99d627

1 file changed

Lines changed: 7 additions & 5 deletions

File tree

arch/arm64/kvm/config.c

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -214,6 +214,7 @@ struct reg_feat_map_desc {
214214
#define FEAT_FGT ID_AA64MMFR0_EL1, FGT, IMP
215215
#define FEAT_FGT2 ID_AA64MMFR0_EL1, FGT, FGT2
216216
#define FEAT_MTPMU ID_AA64DFR0_EL1, MTPMU, IMP
217+
#define FEAT_HCX ID_AA64MMFR1_EL1, HCX, IMP
217218

218219
static bool not_feat_aa64el3(struct kvm *kvm)
219220
{
@@ -929,6 +930,10 @@ static const struct reg_bits_to_feat_map hcrx_feat_map[] = {
929930
NEEDS_FEAT(HCRX_EL2_EnAS0, FEAT_LS64_ACCDATA),
930931
};
931932

933+
934+
static const DECLARE_FEAT_MAP(hcrx_desc, __HCRX_EL2,
935+
hcrx_feat_map, FEAT_HCX);
936+
932937
static const struct reg_bits_to_feat_map hcr_feat_map[] = {
933938
NEEDS_FEAT(HCR_EL2_TID0, FEAT_AA32EL0),
934939
NEEDS_FEAT_FIXED(HCR_EL2_RW, compute_hcr_rw),
@@ -1181,8 +1186,7 @@ void __init check_feature_map(void)
11811186
check_reg_desc(&hfgitr2_desc);
11821187
check_reg_desc(&hdfgrtr2_desc);
11831188
check_reg_desc(&hdfgwtr2_desc);
1184-
check_feat_map(hcrx_feat_map, ARRAY_SIZE(hcrx_feat_map),
1185-
__HCRX_EL2_RES0, "HCRX_EL2");
1189+
check_reg_desc(&hcrx_desc);
11861190
check_feat_map(hcr_feat_map, ARRAY_SIZE(hcr_feat_map),
11871191
HCR_EL2_RES0, "HCR_EL2");
11881192
check_feat_map(sctlr2_feat_map, ARRAY_SIZE(sctlr2_feat_map),
@@ -1383,9 +1387,7 @@ void get_reg_fixed_bits(struct kvm *kvm, enum vcpu_sysreg reg, u64 *res0, u64 *r
13831387
*res1 = HDFGWTR2_EL2_RES1;
13841388
break;
13851389
case HCRX_EL2:
1386-
*res0 = compute_res0_bits(kvm, hcrx_feat_map,
1387-
ARRAY_SIZE(hcrx_feat_map), 0, 0);
1388-
*res0 |= __HCRX_EL2_RES0;
1390+
*res0 = compute_reg_res0_bits(kvm, &hcrx_desc, 0, 0);
13891391
*res1 = __HCRX_EL2_RES1;
13901392
break;
13911393
case HCR_EL2:

0 commit comments

Comments
 (0)