drm/ssd130x: fix ssd132x_clear_screen() columns

johnkeeping · martinezjavier · commit e479da405487 · 2025-06-12T14:04:56.000+02:00
The number of columns relates to the width, not the height. Use the correct variable. Signed-off-by: John Keeping <jkeeping@inmusicbrands.com> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com> Fixes: fdd591e ("drm/ssd130x: Add support for the SSD132x OLED controller family") Link: https://lore.kernel.org/r/20250611111307.1814876-1-jkeeping@inmusicbrands.com Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
diff --git a/drivers/gpu/drm/solomon/ssd130x.c b/drivers/gpu/drm/solomon/ssd130x.c
@@ -974,7 +974,7 @@ static void ssd130x_clear_screen(struct ssd130x_device *ssd130x, u8 *data_array)
 
 static void ssd132x_clear_screen(struct ssd130x_device *ssd130x, u8 *data_array)
 {
-	unsigned int columns = DIV_ROUND_UP(ssd130x->height, SSD132X_SEGMENT_WIDTH);
+	unsigned int columns = DIV_ROUND_UP(ssd130x->width, SSD132X_SEGMENT_WIDTH);
 	unsigned int height = ssd130x->height;
 
 	memset(data_array, 0, columns * height);

Original file line number	Diff line number	Diff line change
`@@ -974,7 +974,7 @@ static void ssd130x_clear_screen(struct ssd130x_device ssd130x, u8 data_array)`
`974`	`974`
`975`	`975`	`static void ssd132x_clear_screen(struct ssd130x_device ssd130x, u8 data_array)`
`976`	`976`	`{`
`977`		`- unsigned int columns = DIV_ROUND_UP(ssd130x->height, SSD132X_SEGMENT_WIDTH);`
	`977`	`+ unsigned int columns = DIV_ROUND_UP(ssd130x->width, SSD132X_SEGMENT_WIDTH);`
`978`	`978`	`unsigned int height = ssd130x->height;`
`979`	`979`
`980`	`980`	`memset(data_array, 0, columns * height);`