Skip to content

Commit f89763e

Browse files
author
Marc Zyngier
committed
KVM: arm64: Enforce absence of FEAT_SCTLR2 on SCTLR2_EL{1,2}
Enforce that SCTLR2_EL{1,2} are RES0 when FEAT_SCTLR2 isn't present. Reviewed-by: Oliver Upton <oliver.upton@linux.dev> Signed-off-by: Marc Zyngier <maz@kernel.org>
1 parent efe5406 commit f89763e

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

arch/arm64/kvm/config.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1026,6 +1026,9 @@ static const struct reg_bits_to_feat_map sctlr2_feat_map[] = {
10261026
FEAT_CPA2),
10271027
};
10281028

1029+
static const DECLARE_FEAT_MAP(sctlr2_desc, SCTLR2_EL1,
1030+
sctlr2_feat_map, FEAT_SCTLR2);
1031+
10291032
static const struct reg_bits_to_feat_map tcr2_el2_feat_map[] = {
10301033
NEEDS_FEAT(TCR2_EL2_FNG1 |
10311034
TCR2_EL2_FNG0 |
@@ -1192,8 +1195,7 @@ void __init check_feature_map(void)
11921195
check_reg_desc(&hdfgwtr2_desc);
11931196
check_reg_desc(&hcrx_desc);
11941197
check_reg_desc(&hcr_desc);
1195-
check_feat_map(sctlr2_feat_map, ARRAY_SIZE(sctlr2_feat_map),
1196-
SCTLR2_EL1_RES0, "SCTLR2_EL1");
1198+
check_reg_desc(&sctlr2_desc);
11971199
check_feat_map(tcr2_el2_feat_map, ARRAY_SIZE(tcr2_el2_feat_map),
11981200
TCR2_EL2_RES0, "TCR2_EL2");
11991201
check_feat_map(sctlr_el1_feat_map, ARRAY_SIZE(sctlr_el1_feat_map),
@@ -1399,9 +1401,7 @@ void get_reg_fixed_bits(struct kvm *kvm, enum vcpu_sysreg reg, u64 *res0, u64 *r
13991401
break;
14001402
case SCTLR2_EL1:
14011403
case SCTLR2_EL2:
1402-
*res0 = compute_res0_bits(kvm, sctlr2_feat_map,
1403-
ARRAY_SIZE(sctlr2_feat_map), 0, 0);
1404-
*res0 |= SCTLR2_EL1_RES0;
1404+
*res0 = compute_reg_res0_bits(kvm, &sctlr2_desc, 0, 0);
14051405
*res1 = SCTLR2_EL1_RES1;
14061406
break;
14071407
case TCR2_EL2:

0 commit comments

Comments
 (0)