fix after changes to prev. PR

Author: dmcilvaney

internal/app/azldev/cmds/component/render.go

@@ -162,7 +162,7 @@ func RenderComponents(env *azldev.Env, options *RenderOptions) ([]*RenderResult,
 	results := make([]*RenderResult, len(componentList))
 
 	// ── Phase 1: Parallel source preparation ──
-	prepared := parallelPrepare(env, componentList, stagingDir, results)
+	prepared := parallelPrepare(env, componentList, stagingDir, options.OutputDir, options.Force, results)
 
 	// ── Phase 2: Batch mock processing ──
 	mockResultMap := batchMockProcess(env, mockProcessor, stagingDir, prepared)
@@ -255,6 +255,8 @@ func parallelPrepare(
 	env *azldev.Env,
 	comps []components.Component,
 	stagingDir string,
+	outputDir string,
+	allowOverwrite bool,
 	results []*RenderResult,
 ) []*preparedComponent {
 	progressEvent := env.StartEvent("Preparing component sources", "count", len(comps))
@@ -274,7 +276,7 @@ func parallelPrepare(
 		go func(idx int, comp components.Component) {
 			defer waitGroup.Done()
 
-			resultsChan <- prepWithSemaphore(workerEnv, semaphore, idx, comp, stagingDir)
+			resultsChan <- prepWithSemaphore(workerEnv, semaphore, idx, comp, stagingDir, outputDir, allowOverwrite)
 		}(compIdx, comp)
 	}
 
@@ -308,25 +310,20 @@ func prepWithSemaphore(
 	index int,
 	comp components.Component,
 	stagingDir string,
+	outputDir string,
+	allowOverwrite bool,
 ) prepResult {
-	// Validate component name before any filesystem work.
-	if err := validateComponentName(comp.GetName()); err != nil {
-		return prepResult{index: index, result: &RenderResult{
-			Component: comp.GetName(),
-			OutputDir: "(invalid)",
-			Status:    renderStatusError,
-			Error:     err.Error(),
-		}}
-	}
+	componentName := comp.GetName()
+	compOutputDir := filepath.Join(outputDir, componentName)
 
 	// Context-aware semaphore acquisition.
 	select {
 	case semaphore <- struct{}{}:
 		defer func() { <-semaphore }()
 	case <-env.Done():
 		return prepResult{index: index, result: &RenderResult{
-			Component: comp.GetName(),
-			OutputDir: comp.GetName(),
+			Component: componentName,
+			OutputDir: compOutputDir,
 			Status:    renderStatusCancelled,
 			Error:     "context cancelled",
 		}}
@@ -335,11 +332,21 @@ func prepWithSemaphore(
 	prep, err := prepareComponentSources(env, comp, stagingDir)
 	if err != nil {
 		slog.Error("Failed to prepare component sources",
-			"component", comp.GetName(), "error", err)
+			"component", componentName, "error", err)
+
+		// Write error marker so the failure is visible in git diff.
+		if allowOverwrite {
+			if removeErr := env.FS().RemoveAll(compOutputDir); removeErr != nil {
+				slog.Debug("Failed to clean output before writing error marker",
+					"path", compOutputDir, "error", removeErr)
+			}
+		}
+
+		writeRenderErrorMarker(env.FS(), compOutputDir)
 
 		return prepResult{index: index, result: &RenderResult{
-			Component: comp.GetName(),
-			OutputDir: comp.GetName(),
+			Component: componentName,
+			OutputDir: compOutputDir,
 			Status:    renderStatusError,
 			Error:     err.Error(),
 		}}
@@ -388,7 +395,7 @@ func prepareComponentSources(
 	// WithSkipLookaside avoids expensive tarball downloads — only spec +
 	// sidecar files are needed for rendering.
 	preparerOpts := []sources.PreparerOption{
-		sources.WithGitRepo(),
+		sources.WithGitRepo(env.Config().Project.DefaultAuthorEmail),
 		sources.WithSkipLookaside(),
 	}
 
@@ -839,19 +846,6 @@ func validateOutputDir(outputDir string) error {
 	return nil
 }
 
-// validateComponentName rejects component names that could cause path traversal
-// when used as directory names in filepath.Join.
-func validateComponentName(name string) error {
-	if name == "" || name == "." ||
-		strings.Contains(name, "/") || strings.Contains(name, "\\") ||
-		strings.Contains(name, "..") || strings.ContainsRune(name, 0) {
-		return fmt.Errorf(
-			"component name %#q is invalid or contains path separators/traversal sequences", name)
-	}
-
-	return nil
-}
-
 // createMockProcessor creates a [sources.MockProcessor] using the project's
 // mock config. Returns nil if the mock config is not available (e.g., no project
 // config loaded, or no mock config path configured).

internal/app/azldev/cmds/component/render_internal_test.go

@@ -173,35 +173,6 @@ func TestValidateOutputDir(t *testing.T) {
 	}
 }
 
-func TestValidateComponentName(t *testing.T) {
-	tests := []struct {
-		name    string
-		wantErr bool
-	}{
-		{"curl", false},
-		{"my-package", false},
-		{"my_package.123", false},
-		{"../escape", true},
-		{"foo/bar", true},
-		{"foo\\bar", true},
-		{"..evil", true},
-		{"", true},
-		{".", true},
-		{"has\x00null", true},
-	}
-
-	for _, tt := range tests {
-		t.Run(tt.name, func(t *testing.T) {
-			err := validateComponentName(tt.name)
-			if tt.wantErr {
-				assert.Error(t, err)
-			} else {
-				assert.NoError(t, err)
-			}
-		})
-	}
-}
-
 func TestRemoveUnreferencedFiles(t *testing.T) {
 	t.Run("keeps spec and referenced files, removes others", func(t *testing.T) {
 		testFS := afero.NewMemMapFs()