chore: upgrade golangci-lint (v2.1.6 => v2.5.0) (#337)

- Updated golangci-lint tool dependency to latest (v2.5.0)
- Fixed code issues to resolve linter warnings

---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>

Author: Copilot

.golangci.yml

@@ -2,6 +2,7 @@ version: "2"
 
 linters:
   enable:
+    - arangolint
     - asasalint
     - asciicheck
     - bidichk
@@ -16,6 +17,8 @@ linters:
     - dupl
     - dupword
     - durationcheck
+    - embeddedstructfieldcheck
+    - errcheck
     - errchkjson
     - errname
     - errorlint
@@ -24,6 +27,7 @@ linters:
     - fatcontext
     - forbidigo
     - forcetypeassert
+    - funcorder
     - funlen
     - ginkgolinter
     - gocheckcompilerdirectives
@@ -34,6 +38,7 @@ linters:
     - goconst
     - gocritic
     - gocyclo
+    - godoclint
     - godot
     - godox
     - goheader
@@ -42,12 +47,15 @@ linters:
     - goprintffuncname
     - gosec
     - gosmopolitan
+    - govet
     - grouper
     - iface
     - importas
     - inamedparam
+    - ineffassign
     - interfacebloat
     - intrange
+    - iotamixing
     - lll
     - loggercheck
     - maintidx
@@ -63,6 +71,7 @@ linters:
     - nilnil
     - nlreturn
     - noctx
+    - noinlineerr
     - nolintlint
     - nosprintfhostport
     - perfsprint
@@ -87,20 +96,26 @@ linters:
     - tparallel
     - unconvert
     - unparam
+    - unqueryvet
+    - unused
     - usestdlibvars
     - usetesting
     - varnamelen
     - wastedassign
     - whitespace
     - wrapcheck
-    - wsl
+    - wsl_v5
     - zerologlint
 
   disable:
     - depguard # We will need to configure the allowed dependencies before enabling this
+    - embeddedstructfieldcheck # Would require extensive struct reorganization
     - err113 # We're okay with dynamic errors for most cases; no way to only disable that check.
     - exhaustruct # We don't require explicitly initializing each field of a struct at construction time.
+    - funcorder # Would require extensive code reorganization
+    - godoclint # Would require updating all function documentation comments
     - ireturn # We are philosophically opposed to banning interface returns.
+    - noinlineerr # We prefer inline error handling for readability
     - nonamedreturns # We *intentionally* like named returns.
     - paralleltest # We're not going to add t.Parallel() to every test for now.
 

internal/app/azldev/app.go

@@ -392,7 +392,8 @@ func (a *App) handlePostInitCallbacks(env *Env) error {
 		return nil
 	}
 
-	if err := a.callPostInitCallbacks(env); err != nil {
+	err := a.callPostInitCallbacks(env)
+	if err != nil {
 		return fmt.Errorf("error during post-config initialization: %w", err)
 	}
 
@@ -593,7 +594,8 @@ func (a *App) dispatchToCommand(env *Env, args []string) int {
 	a.cmd.SetArgs(args)
 	a.applyStylesToCommand()
 
-	if err := a.cmd.ExecuteContext(env); err != nil {
+	err := a.cmd.ExecuteContext(env)
+	if err != nil {
 		slog.Error("Error: " + err.Error())
 
 		return 1

internal/app/azldev/cmds/component/buildtasks.go

@@ -36,6 +36,7 @@ func (d *FileArtifact) Ref() artifacts.Ref {
 
 type sourcesTask struct {
 	orchestration.BaseTask
+
 	component        components.Component
 	componentBuilder componentbuilder.ComponentBuilder
 	services         orchestration.TaskServicer
@@ -132,6 +133,7 @@ func (b *sourcesTaskBuilder) SetTaskServicer(services orchestration.TaskServicer
 
 type binaryPackageTask struct {
 	orchestration.BaseTask
+
 	componentBuilder  componentbuilder.ComponentBuilder
 	component         components.Component
 	runChecks         bool

internal/app/azldev/cmds/component/buildtasks_test.go

@@ -97,6 +97,7 @@ func setupTestComponentBuilder(t *testing.T) *componentbuilder.MockComponentBuil
 
 func TestFileArtifact(t *testing.T) {
 	const dummyFilePath = "/path/to/file.rpm"
+
 	artifact := &FileArtifact{Path: dummyFilePath}
 
 	t.Run("String contains file path", func(t *testing.T) {

internal/app/azldev/core/mcp/mcpserver.go

@@ -76,6 +76,7 @@ func addToolForCmd(env *azldev.Env, srv *server.MCPServer, leaf *cobra.Command)
 	}
 
 	var toolOptions []mcp.ToolOption
+
 	toolOptions = append(toolOptions, mcp.WithDescription(toolDesc))
 
 	flags := getAllFlagDefs(leaf)

internal/orchestration/artifacts/artifactref_test.go

@@ -46,6 +46,7 @@ func TestBasicRefImplementation(t *testing.T) {
 // ExtendedRef embeds BasicRef and adds extra functionality.
 type ExtendedRef struct {
 	artifacts.BasicRef
+
 	Version string
 }
 

internal/orchestration/artifacts/artifacts_test.go

@@ -103,6 +103,7 @@ func TestPromisedArtifactResolveAndAwait(t *testing.T) {
 		))
 
 		done := make(chan struct{})
+
 		go func() {
 			time.Sleep(100 * time.Millisecond)
 			assert.NoError(t, promise.Resolve(artifact))
@@ -203,14 +204,14 @@ func TestPromisedArtifactConcurrentAccess(t *testing.T) {
 		))
 
 		const numReaders = 20
+
 		results := make(chan artifacts.Artifact, numReaders)
 		errors := make(chan error, numReaders)
 
 		// Start multiple readers
 		for range numReaders {
 			go func() {
 				result, err := promise.Await(t.Context())
-
 				if err != nil {
 					errors <- err
 				} else {
@@ -285,6 +286,7 @@ func TestPromisedArtifactConcurrentAccess(t *testing.T) {
 
 		// Wait for all tasks to complete
 		done := make(chan struct{})
+
 		go func() {
 			waitGroup.Wait()
 			close(done)
@@ -382,6 +384,7 @@ func TestPromisedArtifactConcurrentAccess(t *testing.T) {
 			// Resolver goroutine
 			go func() {
 				defer waitGroup.Done()
+
 				assert.NoError(t, promise.Resolve(artifact))
 			}()
 

internal/orchestration/orchestration/tasks.go

@@ -37,6 +37,7 @@ func NewTaskID[T any](taskID string) (TaskID, error) {
 	}
 
 	var zero T
+
 	taskType := reflect.TypeOf(zero).Name()
 
 	if taskType == "" {

internal/orchestration/orchestrator/orchestrator.go

@@ -111,7 +111,8 @@ func (o *Orchestrator) AssignTaskServices(taskBuilder orchestration.TaskBuilder)
 			return nil
 		}
 
-		if cleanupErr := o.cleanupTaskRuntimeUnsafe(taskID); cleanupErr != nil {
+		cleanupErr := o.cleanupTaskRuntimeUnsafe(taskID)
+		if cleanupErr != nil {
 			return fmt.Errorf("failed to cleanup task runtime for task %#q: %w", taskID, cleanupErr)
 		}
 
@@ -142,7 +143,8 @@ func (o *Orchestrator) cleanupTaskRuntimeUnsafe(task orchestration.TaskID) error
 	if runtime, exists := o.taskSet[task]; exists {
 		delete(o.taskSet, task)
 
-		if err := runtime.Cleanup(); err != nil {
+		err := runtime.Cleanup()
+		if err != nil {
 			return fmt.Errorf("failed to cleanup task runtime for task %#q: %w", task, err)
 		}
 	}
@@ -168,7 +170,8 @@ func (o *Orchestrator) Cleanup() (err error) {
 	for task, runtimes := range o.taskSet {
 		slog.Warn("Orphaned task runtime found during orchestrator cleanup", "taskID", task.ID())
 
-		if cleanupErr := runtimes.Cleanup(); cleanupErr != nil {
+		cleanupErr := runtimes.Cleanup()
+		if cleanupErr != nil {
 			err = errors.Join(
 				err,
 				fmt.Errorf("failed to cleanup task %#q runtime during orchestrator cleanup: %w", task.ID(), cleanupErr),

internal/orchestration/orchestrator/orchestrator_test.go

@@ -370,6 +370,7 @@ func TestOrchestrator_RunTask_ContextCancellation(t *testing.T) {
 
 	// Run task in goroutine
 	errChan := make(chan error, 1)
+
 	go func() {
 		_, err := orch.RunTask(ctx, task)
 		errChan <- err