feat: make component build run check section by default (#434)

Author: tobiasb-ms

internal/app/azldev/cmds/component/build.go

@@ -25,7 +25,7 @@ type ComponentBuildOptions struct {
 	ComponentFilter components.ComponentFilter
 
 	ContinueOnError   bool
-	RunChecks         bool
+	NoCheck           bool
 	SourcePackageOnly bool
 	BuildEnvPolicy    BuildEnvPreservePolicy
 
@@ -69,7 +69,7 @@ func NewBuildCmd() *cobra.Command {
 	components.AddComponentFilterOptionsToCommand(cmd, &options.ComponentFilter)
 	cmd.Flags().BoolVarP(&options.ContinueOnError, "continue-on-error", "k", false,
 		"Continue building when some components fail")
-	cmd.Flags().BoolVarP(&options.RunChecks, "check", "c", false, "Run package %check tests")
+	cmd.Flags().BoolVar(&options.NoCheck, "no-check", false, "Skip package %check tests")
 	cmd.Flags().BoolVar(&options.SourcePackageOnly, "srpm-only", false, "Build SRPM (source RPM) *only*")
 	cmd.Flags().Var(&options.BuildEnvPolicy, "preserve-buildenv",
 		fmt.Sprintf("Preserve build environment {%s, %s, %s}",
@@ -194,7 +194,7 @@ func BuildComponent(
 
 	results, err = buildComponentUsingBuilder(
 		env, component, builder, allLocalRepoPaths,
-		options.SourcePackageOnly, options.RunChecks,
+		options.SourcePackageOnly, options.NoCheck,
 		options.LocalRepoWithPublishPath,
 	)
 	if err != nil {
@@ -209,7 +209,7 @@ func buildComponentUsingBuilder(
 	component components.Component,
 	builder *componentbuilder.Builder,
 	localRepoPaths []string,
-	sourcePackageOnly, runChecks bool,
+	sourcePackageOnly, noCheck bool,
 	localRepoWithPublishPath string,
 ) (results ComponentBuildResults, err error) {
 	// Compose the path to the output dir.
@@ -248,7 +248,7 @@ func buildComponentUsingBuilder(
 	//
 
 	results.RPMPaths, err = builder.BuildBinaryPackage(
-		env, component, outputSourcePackagePath, localRepoPaths, outputDir, runChecks,
+		env, component, outputSourcePackagePath, localRepoPaths, outputDir, noCheck,
 	)
 	if err != nil {
 		return results, fmt.Errorf("failed to build RPM for %q: %w", component.GetName(), err)

internal/app/azldev/core/componentbuilder/componentbuilder.go

@@ -30,7 +30,7 @@ type ComponentBuilder interface {
 	BuildBinaryPackage(
 		ctx context.Context,
 		component components.Component, sourcePackagePath string, localRepoPaths []string,
-		outputDir string, runChecks bool,
+		outputDir string, noCheck bool,
 	) (packagePaths []string, err error)
 
 	// BuildSourcePackage builds a source package for the given component and returns the path to the
@@ -83,9 +83,9 @@ func (b *Builder) BuildSourcePackage(
 func (b *Builder) BuildBinaryPackage(
 	ctx context.Context,
 	component components.Component, sourcePackagePath string, localRepoPaths []string,
-	outputDir string, runChecks bool,
+	outputDir string, noCheck bool,
 ) (packagePaths []string, err error) { // NOTE: We intentionally name the returns for better self-documentation.
-	packagePaths, err = b.buildRPM(ctx, component, sourcePackagePath, b.buildEnv, localRepoPaths, outputDir, runChecks)
+	packagePaths, err = b.buildRPM(ctx, component, sourcePackagePath, b.buildEnv, localRepoPaths, outputDir, noCheck)
 	if err != nil {
 		return packagePaths, fmt.Errorf("failed to build binary package for component %#q:\n%w", component.GetName(), err)
 	}
@@ -203,7 +203,7 @@ func (b *Builder) buildRPM(
 	ctx context.Context,
 	component components.Component,
 	srpmPath string, buildEnv buildenv.RPMAwareBuildEnv, localRepoPaths []string,
-	outputDir string, runChecks bool,
+	outputDir string, noCheck bool,
 ) (outputRPMPaths []string, err error) { // NOTE: We intentionally name the returns for better self-documentation.
 	var tempRPMDir string
 
@@ -228,7 +228,7 @@ func (b *Builder) buildRPM(
 			Defines:        map[string]string{},
 			LocalRepoPaths: localRepoPaths,
 		},
-		RunChecks:    runChecks,
+		NoCheck:      noCheck,
 		ForceRebuild: false, // Could be added to config if needed
 	}
 

internal/app/azldev/core/componentbuilder/componentbuilder_test.go

@@ -186,7 +186,7 @@ func TestBuildBinaryPackage(t *testing.T) {
 		testSRPMPath,
 		[]string{},
 		testOutputDir,
-		false, /*runChecks?*/
+		false, /*noCheck?*/
 	)
 
 	require.NoError(t, err)

internal/app/azldev/core/componentbuilder/componentbuilder_test/componentbuilder_mocks.go

@@ -265,7 +265,7 @@ type RPMBuildOptions struct {
 	CommonBuildOptions
 
 	// Binary RPM specific options
-	RunChecks    bool
+	NoCheck      bool
 	ForceRebuild bool
 }
 
@@ -368,8 +368,8 @@ func (r *Runner) BuildRPM(ctx context.Context, srpmPath, outputDirPath string, o
 		args = append(args, "--rebuild")
 	}
 
-	// Unless requested to do so, we don't run %check sections.
-	if !options.RunChecks {
+	// Unless requested to skip checks, we run them.
+	if options.NoCheck {
 		args = append(args, "--nocheck")
 	}
 

internal/rpm/mock/mock.go

@@ -178,7 +178,6 @@ func TestBuildRPM(t *testing.T) {
 			With:    []string{withFeature},
 			Defines: map[string]string{macroName: macroValue},
 		},
-		RunChecks: false,
 	}
 
 	err := runner.BuildRPM(ctx, testSRPMPath, testOutputDirPath, mockOptions)