fix: do not rpmspec analyze specs by default in package builds (#390)

Aligns the local-spec case with what we're presently doing with the upstream-spec case.

Author: reubeno

internal/providers/sourceproviders/localcontentsprovider.go

@@ -19,10 +19,13 @@ import (
 )
 
 // FetchLocalComponent retrieves the `.spec` file and any sidecar files for the specified component
-// from the local filesystem, placing the fetched files in the provided directory.
+// from the local filesystem, placing the fetched files in the provided directory. If
+// dynamicallyResolveRequiredFiles is true, any files referenced by the spec's *contents* but
+// that are not located alongside the spec will also be resolved and copied to the destination.
 func FetchLocalComponent(
 	dryRunnable opctx.DryRunnable, eventListener opctx.EventListener,
 	fs opctx.FS, component components.Component, destDirPath string,
+	dynamicallyResolveRequiredFiles bool,
 ) error {
 	if dryRunnable == nil {
 		return errors.New("dry runnable cannot be nil")
@@ -61,10 +64,12 @@ func FetchLocalComponent(
 	}
 
 	// Resolve and copy any required files that may be stored separately
-	err = copyRequiredFiles(dryRunnable, fs, eventListener, component, sourceDirPath, destDirPath)
-	if err != nil {
-		return fmt.Errorf("failed to copy required files for component %#q:\n%w",
-			component.GetName(), err)
+	if dynamicallyResolveRequiredFiles {
+		err = copyRequiredFiles(dryRunnable, fs, eventListener, component, sourceDirPath, destDirPath)
+		if err != nil {
+			return fmt.Errorf("failed to copy required files for component %#q:\n%w",
+				component.GetName(), err)
+		}
 	}
 
 	return nil

internal/providers/sourceproviders/localcontentsprovider_test.go

@@ -111,6 +111,7 @@ func TestFetchLocalComponent_NoRequiredFiles(t *testing.T) {
 		testParams.env.EventListener,
 		testParams.env.FS(),
 		testParams.component, testOutputDir,
+		true,
 	)
 	require.NoError(t, err)
 
@@ -145,6 +146,7 @@ func TestFetchLocalComponent_RequiredFileMissing(t *testing.T) {
 		testParams.env.FS(),
 		testParams.component,
 		testOutputDir,
+		true,
 	)
 	require.Error(t, err)
 	require.Contains(t, err.Error(), "required-file.txt")
@@ -170,6 +172,7 @@ func TestFetchLocalComponent_RequiredFilePresent(t *testing.T) {
 		testParams.env.FS(),
 		testParams.component,
 		testOutputDir,
+		true,
 	)
 	require.NoError(t, err)
 
@@ -204,6 +207,7 @@ func TestFetchLocalComponent_MissingSpec(t *testing.T) {
 		testParams.env.FS(),
 		testParams.component,
 		testOutputDir,
+		true,
 	)
 	require.Error(t, err)
 }

internal/providers/sourceproviders/sourcemanager.go

@@ -168,7 +168,8 @@ func (m *sourceManager) FetchComponent(ctx context.Context, component components
 
 	// Handle local components
 	if sourceType == projectconfig.SpecSourceTypeLocal {
-		err := FetchLocalComponent(m.dryRunnable, m.eventListener, m.fs, component, destDirPath)
+		// NOTE: For now we are *not* dynamically resolving required files by parsing the spec.
+		err := FetchLocalComponent(m.dryRunnable, m.eventListener, m.fs, component, destDirPath, false)
 		if err != nil {
 			return fmt.Errorf("failed to fetch local component %#q:\n%w",
 				component.GetName(), err)