fix: change spec-add-tag to add to the beginning of a section to avoid bad interactions with ifs and other issues (#449)

Author: tobiasb-ms

internal/app/azldev/core/sources/overlays_test.go

@@ -102,9 +102,9 @@ func TestApplySpecOverlay(t *testing.T) {
 			spec: `Name: name
 BuildRequires: existing-package
 `,
-			result: `Name: name
+			result: `BuildRequires: added-package
+Name: name
 BuildRequires: existing-package
-BuildRequires: added-package
 `,
 		},
 		{

internal/rpm/spec/edit.go

@@ -164,7 +164,7 @@ func (s *Spec) AddTag(packageName string, tag string, value string) (err error)
 		sectionName = "%package"
 	}
 
-	return s.AppendLinesToSection(sectionName, packageName, []string{fmt.Sprintf("%s: %s", tag, value)})
+	return s.PrependLinesToSection(sectionName, packageName, []string{fmt.Sprintf("%s: %s", tag, value)})
 }
 
 // PrependLinesToSection prepends the given lines to the start of the specified section, placing

internal/rpm/spec/edit_test.go

@@ -38,8 +38,8 @@ func TestSetTag(t *testing.T) {
 			input: `OtherTag: other-value
 `,
 			expectedFailure: false,
-			expectedOutput: `OtherTag: other-value
-Name: value
+			expectedOutput: `Name: value
+OtherTag: other-value
 `,
 			packageName: "",
 			tag:         "Name",
@@ -72,8 +72,8 @@ Name: value
 			input: `# Name: old
 `,
 			expectedFailure: false,
-			expectedOutput: `# Name: old
-Name: value
+			expectedOutput: `Name: value
+# Name: old
 `,
 			packageName: "",
 			tag:         "Name",
@@ -98,8 +98,8 @@ Name: value
 			input: `# Name: old
 `,
 			expectedFailure: false,
-			expectedOutput: `# Name: old
-Name: value
+			expectedOutput: `Name: value
+# Name: old
 `,
 			packageName: "",
 			tag:         "Name",
@@ -430,8 +430,8 @@ func TestAddTag(t *testing.T) {
 			input: `OtherTag: other-value
 `,
 			expectedFailure: false,
-			expectedOutput: `OtherTag: other-value
-BuildRequires: value
+			expectedOutput: `BuildRequires: value
+OtherTag: other-value
 `,
 			packageName: "",
 			tag:         "BuildRequires",
@@ -442,8 +442,8 @@ BuildRequires: value
 			input: `BuildRequires: old
 `,
 			expectedFailure: false,
-			expectedOutput: `BuildRequires: old
-BuildRequires: value
+			expectedOutput: `BuildRequires: value
+BuildRequires: old
 `,
 			packageName: "",
 			tag:         "BuildRequires",
@@ -480,8 +480,8 @@ BuildRequires: old
 Some description
 
 %package -n test-package
-BuildRequires: old
 BuildRequires: value
+BuildRequires: old
 `,
 			packageName: "test-package",
 			tag:         "BuildRequires",