chore: revert "fix: Preserving .git dir during repo clone (#468)" (#474)

This reverts commit 2d22217.

Author: Antonio Salinas

internal/providers/sourceproviders/fedorasourceprovider.go

@@ -146,6 +146,12 @@ func (g *FedoraSourcesProviderImpl) processClonedRepo(
 		return fmt.Errorf("failed to checkout target commit:\n%w", err)
 	}
 
+	// Delete the .git directory so it's not copied to destination.
+	if err := g.fs.RemoveAll(filepath.Join(tempDir, ".git")); err != nil {
+		return fmt.Errorf("failed to remove .git directory from cloned repository at %#q:\n%w",
+			tempDir, err)
+	}
+
 	// Extract sources from repo (downloads lookaside files into the temp dir)
 	if err := g.downloader.ExtractSourcesFromRepo(ctx, tempDir, upstreamName, lookasideBaseURI); err != nil {
 		return fmt.Errorf("failed to extract sources from git repository:\n%w", err)

internal/providers/sourceproviders/fedorasourceprovider_test.go

@@ -280,49 +280,6 @@ func TestGetComponentFromGit(t *testing.T) {
 		assert.True(t, exists)
 	})
 
-	t.Run("git directory is preserved in destination", func(t *testing.T) {
-		ctrl := gomock.NewController(t)
-		mockGitProvider := git_test.NewMockGitProvider(ctrl)
-		mockExtractor := fedorasource_test.NewMockFedoraSourceDownloader(ctrl)
-
-		provider, err := sourceproviders.NewFedoraSourcesProviderImpl(
-			env.FS(), env.DryRunnable, mockGitProvider, mockExtractor, mockDistroResolver(), retry.Disabled(),
-		)
-		require.NoError(t, err)
-
-		mockComponent := components_testutils.NewMockComponent(ctrl)
-		mockComponent.EXPECT().GetName().AnyTimes().Return(testPackageName)
-		mockComponent.EXPECT().GetConfig().AnyTimes().Return(&projectconfig.ComponentConfig{Name: testPackageName})
-
-		mockGitProvider.EXPECT().
-			Clone(gomock.Any(), repoURL, gomock.Any(), gomock.Any()).
-			DoAndReturn(func(_ context.Context, _, cloneDir string, _ ...git.GitOptions) error {
-				for path, content := range map[string]string{
-					cloneDir + "/" + testPackageName + ".spec": "Name: " + testPackageName,
-					cloneDir + "/.git/HEAD":                    "ref: refs/heads/main\n",
-				} {
-					if err := fileutils.WriteFile(env.FS(), path, []byte(content), fileperms.PublicFile); err != nil {
-						return err
-					}
-				}
-
-				return nil
-			})
-
-		mockExtractor.EXPECT().
-			ExtractSourcesFromRepo(gomock.Any(), gomock.Any(), testPackageName, gomock.Any()).
-			Return(nil)
-
-		gitDestDir := destDir + "/with-git"
-		err = provider.GetComponent(context.Background(), mockComponent, gitDestDir)
-		require.NoError(t, err)
-
-		// Verify the .git directory was preserved in the destination.
-		exists, err := fileutils.Exists(env.FS(), gitDestDir+"/.git/HEAD")
-		require.NoError(t, err)
-		assert.True(t, exists, ".git/HEAD should exist in destination")
-	})
-
 	t.Run("validation failures", func(t *testing.T) {
 		ctrl := gomock.NewController(t)
 		mockGitProvider := git_test.NewMockGitProvider(ctrl)