Skip to content

Commit 06a33d9

Browse files
authored
Fix failures in running firewalld service (#13903)
1 parent 4df8bcf commit 06a33d9

File tree

7 files changed

+904
-39
lines changed

7 files changed

+904
-39
lines changed

SPECS/dbus-python/0001-Move-python-modules-to-architecture-specific-directo.patch

Lines changed: 11 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -7,14 +7,14 @@ This is because dbus-python gets dragged in as a dependency of other
77
things people want to be multilib-compatible. As is the Python
88
modules conflict.
99
---
10-
Makefile.am | 9 +++++----
11-
1 file changed, 5 insertions(+), 4 deletions(-)
10+
Makefile.am | 7 ++++---
11+
1 file changed, 4 insertions(+), 3 deletions(-)
1212

1313
diff --git a/Makefile.am b/Makefile.am
14-
index fd480d4..0859994 100644
14+
index 8738d57..b6d30c0 100644
1515
--- a/Makefile.am
1616
+++ b/Makefile.am
17-
@@ -155,7 +155,8 @@ test_dbus_py_test_la_SOURCES = \
17+
@@ -176,7 +176,8 @@ test_dbus_py_test_la_SOURCES = \
1818

1919
# === dbus package ===
2020

@@ -24,29 +24,23 @@ index fd480d4..0859994 100644
2424
dbus/bus.py \
2525
dbus/connection.py \
2626
dbus/_compat.py \
27-
@@ -175,12 +176,12 @@ nobase_python_PYTHON = \
27+
@@ -195,7 +196,7 @@ nobase_python_PYTHON = \
28+
dbus/service.py \
2829
dbus/types.py
2930

30-
if !HAVE_PYTHON_3
31-
-nobase_python_PYTHON += \
32-
+nobase_dbuspy_DATA += \
33-
dbus/gobject_service.py \
34-
$(NULL)
35-
endif
36-
3731
-check_py_sources = $(nobase_python_PYTHON)
3832
+check_py_sources = $(nobase_dbuspy_DATA)
3933
include $(top_srcdir)/tools/check-coding-style.mk
4034

4135
# === Devel stuff ===
42-
@@ -416,7 +417,7 @@ uninstall-local: uninstall-local-sphinx
36+
@@ -434,7 +435,7 @@ uninstall-local-pycache:
4337
if ENABLE_DOCUMENTATION
44-
all: doc/_build/.stamp
38+
all: doc/html/.stamp
4539

46-
-doc/_build/.stamp: $(nobase_python_PYTHON) \
47-
+doc/_build/.stamp: $(nobase_dbuspy_DATA) \
40+
-doc/html/.stamp: $(nobase_python_PYTHON) \
41+
+doc/html/.stamp: $(nobase_dbuspy_DATA) \
4842
_dbus_bindings.la \
4943
_dbus_glib_bindings.la \
5044
$(sphinx_sources) \
5145
--
52-
2.17.0
46+
2.45.3
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
22
"Signatures": {
3-
"dbus-python-1.2.16.tar.gz": "11238f1d86c995d8aed2e22f04a1e3779f0d70e587caffeab4857f3c662ed5a4"
3+
"dbus-python-1.3.2.tar.gz": "ad67819308618b5069537be237f8e68ca1c7fcc95ee4a121fe6845b1418248f8"
44
}
5-
}
5+
}

SPECS/dbus-python/dbus-python.spec

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,14 @@
11
Summary: D-Bus Python Bindings
22
Name: dbus-python
3-
Version: 1.2.16
4-
Release: 3%{?dist}
3+
Version: 1.3.2
4+
Release: 1%{?dist}
55
License: MIT
66
Vendor: Microsoft Corporation
77
Distribution: Azure Linux
88
URL: https://www.freedesktop.org/wiki/Software/DBusBindings/
99
Source0: https://dbus.freedesktop.org/releases/%{name}/%{name}-%{version}.tar.gz
1010
# borrow centos7 patch to use sitearch properly
1111
Patch0: 0001-Move-python-modules-to-architecture-specific-directo.patch
12-
# https://bugzilla.redhat.com/show_bug.cgi?id=1788491
13-
Patch1: python39.patch
1412

1513
BuildRequires: autoconf-archive
1614
BuildRequires: automake
@@ -28,6 +26,7 @@ Summary: D-Bus bindings for python3
2826
BuildRequires: python3-devel
2927
# for py3_build
3028
BuildRequires: python3dist(setuptools)
29+
BuildRequires: python3dist(wheel)
3130

3231
%description -n python3-dbus
3332
%{summary}.
@@ -46,12 +45,14 @@ bindings.
4645
autoreconf -vif
4746

4847
%build
48+
export DBUS_PYTHON_USE_AUTOTOOLS=1
4949
%set_build_flags
5050
%py3_build
5151
%configure PYTHON="%{__python3}"
5252
%make_build
5353

5454
%install
55+
export DBUS_PYTHON_USE_AUTOTOOLS=1
5556
%py3_install
5657
%make_install
5758

@@ -75,6 +76,9 @@ make check -k || (cat test-suite.log && false)
7576
%{_libdir}/pkgconfig/dbus-python.pc
7677

7778
%changelog
79+
* Wed May 28 2025 Sumedh Sharma <sumsharma@microsoft.com> - 1.3.2-1
80+
- Bump version to 1.3.2
81+
7882
* Fri Jul 16 2021 Pawel Winogrodzki <pawelwi@microsoft.com> - 1.2.16-3
7983
- License verified.
8084

SPECS/dbus-python/python39.patch

Lines changed: 0 additions & 12 deletions
This file was deleted.

SPECS/firewalld/firewalld.spec

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
Summary: A firewall daemon with D-Bus interface providing a dynamic firewall
44
Name: firewalld
55
Version: 2.0.2
6-
Release: 2%{?dist}
6+
Release: 3%{?dist}
77
License: GPLv2+
88
Vendor: Microsoft Corporation
99
Distribution: Azure Linux
@@ -12,6 +12,7 @@ Source0: https://github.com/firewalld/firewalld/releases/download/v%{vers
1212
Source1: FedoraServer.xml
1313
Source2: FedoraWorkstation.xml
1414
Patch0: firewalld-only-MDNS-default.patch
15+
Patch1: firewalld_fix_testsuite.patch
1516

1617
BuildRequires: autoconf
1718
BuildRequires: automake
@@ -55,7 +56,7 @@ firewall with a D-Bus interface.
5556
%{?python_provide:%python_provide python3-firewall}
5657
Summary: Python3 bindings for firewalld
5758

58-
Requires: python3-dbus
59+
Requires: python3-dbus >= 1.3.2
5960
Requires: python3-gobject-base
6061
Requires: python3-nftables
6162

@@ -72,6 +73,8 @@ are required by other packages that add firewalld configuration files.
7273
%package -n firewalld-test
7374
Summary: Firewalld testsuite
7475

76+
Requires: time
77+
7578
%description -n firewalld-test
7679
This package provides the firewalld testsuite.
7780

@@ -137,6 +140,8 @@ install -c -m 644 %{SOURCE2} %{buildroot}%{_libdir}/firewalld/zones/FedoraWorkst
137140
# standard firewalld.conf
138141
mv %{buildroot}%{_sysconfdir}/firewalld/firewalld.conf \
139142
%{buildroot}%{_sysconfdir}/firewalld/firewalld-standard.conf
143+
sed -i 's|^IPv6_rpfilter=.*|IPv6_rpfilter=no|g' \
144+
%{buildroot}%{_sysconfdir}/firewalld/firewalld-standard.conf
140145

141146
# server firewalld.conf
142147
cp -a %{buildroot}%{_sysconfdir}/firewalld/firewalld-standard.conf \
@@ -304,6 +309,10 @@ fi
304309
%{_mandir}/man1/firewall-config*.1*
305310

306311
%changelog
312+
* Mon Jun 16 2025 Sumedh Sharma <sumsharma@microsoft.com> - 2.0.2-3
313+
- disable ipv6_rpfilter in configuration
314+
- fix testsuite provided by firewalld-test sub-package
315+
307316
* Sun Feb 04 2024 Dan Streetman <ddstreet@ieee.org> - 2.0.2-2
308317
- workaround "circular dependencies" from build tooling
309318

0 commit comments

Comments
 (0)