|
| 1 | +From 61522c4a6b3ccf667bd89925477ae866715f110e Mon Sep 17 00:00:00 2001 |
| 2 | +From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com> |
| 3 | +Date: Tue, 10 Oct 2023 13:03:12 -0700 |
| 4 | +Subject: [PATCH] input.conf: Change default of ClassicBondedOnly |
| 5 | + |
| 6 | +This changes the default of ClassicBondedOnly since defaulting to false |
| 7 | +is not inline with HID specification which mandates the of Security Mode |
| 8 | +4: |
| 9 | + |
| 10 | +BLUETOOTH SPECIFICATION Page 84 of 123 |
| 11 | +Human Interface Device (HID) Profile: |
| 12 | + |
| 13 | + 5.4.3.4.2 Security Modes |
| 14 | + Bluetooth HID Hosts shall use Security Mode 4 when interoperating with |
| 15 | + Bluetooth HID devices that are compliant to the Bluetooth Core |
| 16 | + Specification v2.1+EDR[6]. |
| 17 | +--- |
| 18 | + profiles/input/device.c | 2 +- |
| 19 | + profiles/input/input.conf | 2 +- |
| 20 | + 2 files changed, 2 insertions(+), 2 deletions(-) |
| 21 | + |
| 22 | +diff --git a/profiles/input/device.c b/profiles/input/device.c |
| 23 | +index 0138992..156f9f1 100644 |
| 24 | +--- a/profiles/input/device.c |
| 25 | ++++ b/profiles/input/device.c |
| 26 | +@@ -81,7 +81,7 @@ struct input_device { |
| 27 | + |
| 28 | + static int idle_timeout = 0; |
| 29 | + static bool uhid_enabled = false; |
| 30 | +-static bool classic_bonded_only = false; |
| 31 | ++static bool classic_bonded_only = true; |
| 32 | + |
| 33 | + void input_set_idle_timeout(int timeout) |
| 34 | + { |
| 35 | +diff --git a/profiles/input/input.conf b/profiles/input/input.conf |
| 36 | +index 4c70bc5..d8645f3 100644 |
| 37 | +--- a/profiles/input/input.conf |
| 38 | ++++ b/profiles/input/input.conf |
| 39 | +@@ -17,7 +17,7 @@ |
| 40 | + # platforms may want to make sure that input connections only come from bonded |
| 41 | + # device connections. Several older mice have been known for not supporting |
| 42 | + # pairing/encryption. |
| 43 | +-# Defaults to false to maximize device compatibility. |
| 44 | ++# Defaults to true for security. |
| 45 | + #ClassicBondedOnly=true |
| 46 | + |
| 47 | + # LE upgrade security |
| 48 | +-- |
| 49 | +2.38.1 |
| 50 | + |
0 commit comments