|
| 1 | +From e6348a0e1f1f42547dce80135afea806125654cc Mon Sep 17 00:00:00 2001 |
| 2 | +From: Kanishk-Bansal <kbkanishk975@gmail.com> |
| 3 | +Date: Mon, 2 Dec 2024 09:20:54 +0000 |
| 4 | +Subject: [PATCH] Fix CVE-2023-38473 |
| 5 | + |
| 6 | +--- |
| 7 | + avahi-common/alternative-test.c | 3 +++ |
| 8 | + avahi-common/alternative.c | 27 +++++++++++++++++++-------- |
| 9 | + 2 files changed, 22 insertions(+), 8 deletions(-) |
| 10 | + |
| 11 | +diff --git a/avahi-common/alternative-test.c b/avahi-common/alternative-test.c |
| 12 | +index 9255435..681fc15 100644 |
| 13 | +--- a/avahi-common/alternative-test.c |
| 14 | ++++ b/avahi-common/alternative-test.c |
| 15 | +@@ -31,6 +31,9 @@ int main(AVAHI_GCC_UNUSED int argc, AVAHI_GCC_UNUSED char *argv[]) { |
| 16 | + const char* const test_strings[] = { |
| 17 | + "XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX", |
| 18 | + "XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXüüüüüüü", |
| 19 | ++ ").", |
| 20 | ++ "\\.", |
| 21 | ++ "AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA\\\\", |
| 22 | + "gurke", |
| 23 | + "-", |
| 24 | + " #", |
| 25 | +diff --git a/avahi-common/alternative.c b/avahi-common/alternative.c |
| 26 | +index b3d39f0..a094e6d 100644 |
| 27 | +--- a/avahi-common/alternative.c |
| 28 | ++++ b/avahi-common/alternative.c |
| 29 | +@@ -49,15 +49,20 @@ static void drop_incomplete_utf8(char *c) { |
| 30 | + } |
| 31 | + |
| 32 | + char *avahi_alternative_host_name(const char *s) { |
| 33 | ++ char label[AVAHI_LABEL_MAX], alternative[AVAHI_LABEL_MAX*4+1]; |
| 34 | ++ char *alt, *r, *ret; |
| 35 | + const char *e; |
| 36 | +- char *r; |
| 37 | ++ size_t len; |
| 38 | + |
| 39 | + assert(s); |
| 40 | + |
| 41 | + if (!avahi_is_valid_host_name(s)) |
| 42 | + return NULL; |
| 43 | + |
| 44 | +- if ((e = strrchr(s, '-'))) { |
| 45 | ++ if (!avahi_unescape_label(&s, label, sizeof(label))) |
| 46 | ++ return NULL; |
| 47 | ++ |
| 48 | ++ if ((e = strrchr(label, '-'))) { |
| 49 | + const char *p; |
| 50 | + |
| 51 | + e++; |
| 52 | +@@ -74,19 +79,18 @@ char *avahi_alternative_host_name(const char *s) { |
| 53 | + |
| 54 | + if (e) { |
| 55 | + char *c, *m; |
| 56 | +- size_t l; |
| 57 | + int n; |
| 58 | + |
| 59 | + n = atoi(e)+1; |
| 60 | + if (!(m = avahi_strdup_printf("%i", n))) |
| 61 | + return NULL; |
| 62 | + |
| 63 | +- l = e-s-1; |
| 64 | ++ len = e-label-1; |
| 65 | + |
| 66 | +- if (l >= AVAHI_LABEL_MAX-1-strlen(m)-1) |
| 67 | +- l = AVAHI_LABEL_MAX-1-strlen(m)-1; |
| 68 | ++ if (len >= AVAHI_LABEL_MAX-1-strlen(m)-1) |
| 69 | ++ len = AVAHI_LABEL_MAX-1-strlen(m)-1; |
| 70 | + |
| 71 | +- if (!(c = avahi_strndup(s, l))) { |
| 72 | ++ if (!(c = avahi_strndup(label, len))) { |
| 73 | + avahi_free(m); |
| 74 | + return NULL; |
| 75 | + } |
| 76 | +@@ -100,7 +104,7 @@ char *avahi_alternative_host_name(const char *s) { |
| 77 | + } else { |
| 78 | + char *c; |
| 79 | + |
| 80 | +- if (!(c = avahi_strndup(s, AVAHI_LABEL_MAX-1-2))) |
| 81 | ++ if (!(c = avahi_strndup(label, AVAHI_LABEL_MAX-1-2))) |
| 82 | + return NULL; |
| 83 | + |
| 84 | + drop_incomplete_utf8(c); |
| 85 | +@@ -109,6 +113,13 @@ char *avahi_alternative_host_name(const char *s) { |
| 86 | + avahi_free(c); |
| 87 | + } |
| 88 | + |
| 89 | ++ alt = alternative; |
| 90 | ++ len = sizeof(alternative); |
| 91 | ++ ret = avahi_escape_label(r, strlen(r), &alt, &len); |
| 92 | ++ |
| 93 | ++ avahi_free(r); |
| 94 | ++ r = avahi_strdup(ret); |
| 95 | ++ |
| 96 | + assert(avahi_is_valid_host_name(r)); |
| 97 | + |
| 98 | + return r; |
| 99 | +-- |
| 100 | +2.45.2 |
| 101 | + |
0 commit comments