Skip to content

Commit 743f60e

Browse files
[AUTO-CHERRYPICK] Patch CVE-2021-44716 in libcontainers-common - branch main (#7731)
Co-authored-by: osamaesmailmsft <110202916+osamaesmailmsft@users.noreply.github.com>
1 parent aaac8a4 commit 743f60e

2 files changed

Lines changed: 56 additions & 1 deletion

File tree

Lines changed: 50 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,50 @@
1+
Parent: db4efeb8 (http2: deflake TestTransportGroupsPendingDials)
2+
Author: Damien Neil <dneil@google.com>
3+
AuthorDate: 2021-12-06 14:31:43 -0800
4+
Commit: Filippo Valsorda <filippo@golang.org>
5+
CommitDate: 2021-12-09 12:49:13 +0000
6+
7+
http2: cap the size of the server's canonical header cache
8+
9+
The HTTP/2 server keeps a per-connection cache mapping header keys
10+
to their canonicalized form (e.g., "foo-bar" => "Foo-Bar"). Cap the
11+
maximum size of this cache to prevent a peer sending many unique
12+
header keys from causing unbounded memory growth.
13+
14+
Cap chosen arbitrarily at 32 entries. Since this cache does not
15+
include common headers (e.g., "content-type"), 32 seems like more
16+
than enough for almost all normal uses.
17+
18+
Fixes #50058
19+
Fixes CVE-2021-44716
20+
21+
Change-Id: Ia83696dc23253c12af8f26d502557c2cc9841105
22+
Reviewed-on: https://team-review.git.corp.google.com/c/golang/go-private/+/1290827
23+
Reviewed-by: Roland Shoemaker <bracewell@google.com>
24+
Reviewed-on: https://go-review.googlesource.com/c/net/+/369794
25+
Trust: Filippo Valsorda <filippo@golang.org>
26+
Run-TryBot: Filippo Valsorda <filippo@golang.org>
27+
Trust: Damien Neil <dneil@google.com>
28+
Reviewed-by: Russ Cox <rsc@golang.org>
29+
Reviewed-by: Filippo Valsorda <filippo@golang.org>
30+
TryBot-Result: Gopher Robot <gobot@golang.org>
31+
32+
diff -ru cli-20.10.27-orig/vendor/golang.org/x/net/http2/server.go cli-20.10.27/vendor/golang.org/x/net/http2/server.go
33+
--- cli-20.10.27-orig/vendor/golang.org/x/net/http2/server.go 2024-02-05 08:53:30.802532951 -0800
34+
+++ cli-20.10.27/vendor/golang.org/x/net/http2/server.go 2024-02-05 09:19:08.473430121 -0800
35+
@@ -720,7 +720,15 @@
36+
sc.canonHeader = make(map[string]string)
37+
}
38+
cv = http.CanonicalHeaderKey(v)
39+
- sc.canonHeader[v] = cv
40+
+ // maxCachedCanonicalHeaders is an arbitrarily-chosen limit on the number of
41+
+ // entries in the canonHeader cache. This should be larger than the number
42+
+ // of unique, uncommon header keys likely to be sent by the peer, while not
43+
+ // so high as to permit unreaasonable memory usage if the peer sends an unbounded
44+
+ // number of unique header keys.
45+
+ const maxCachedCanonicalHeaders = 32
46+
+ if len(sc.canonHeader) < maxCachedCanonicalHeaders {
47+
+ sc.canonHeader[v] = cv
48+
+ }
49+
return cv
50+
}

SPECS/libcontainers-common/libcontainers-common.spec

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
Summary: Configuration files common to github.com/containers
2727
Name: libcontainers-common
2828
Version: 20210626
29-
Release: 2%{?dist}
29+
Release: 3%{?dist}
3030
License: ASL 2.0 AND GPLv3
3131
Vendor: Microsoft Corporation
3232
Distribution: Mariner
@@ -47,6 +47,7 @@ Source8: default.yaml
4747
#Source9: https://github.com/containers/common/archive/refs/tags/v0.44.0.tar.gz
4848
Source9: %{name}-common-%{commonver}.tar.gz
4949
Source10: containers.conf
50+
Patch0: CVE-2021-44716.patch
5051
BuildRequires: go-go-md2man
5152
Requires(post): grep
5253
Requires(post): util-linux
@@ -63,6 +64,7 @@ github.com/containers libraries, such as Buildah, CRI-O, Podman and Skopeo.
6364
%setup -q -T -D -b 1 -n storage-%{storagever}
6465
%setup -q -T -D -b 7 -n podman-%{podmanver}
6566
%setup -q -T -D -b 9 -n common-%{commonver}
67+
%patch 0 -p1
6668
# copy the LICENSE file in the build root
6769
cd ..
6870
cp %{SOURCE2} .
@@ -158,6 +160,9 @@ fi
158160
%license LICENSE
159161
160162
%changelog
163+
* Mon Feb 05 2024 Osama Esmail <osamaesmail@microsoft.com> - 20210526-3
164+
- Patching CVE-2021-44716
165+
161166
* Thu Oct 19 2023 Dan Streetman <ddstreet@ieee.org> - 20210626-2
162167
- Bump release to rebuild with updated version of Go.
163168

0 commit comments

Comments
 (0)