Skip to content

Commit 7f740a4

Browse files
fix: Allow updating shim-unsigned-* separately from shim (#16079)
This PR introduces two small changes: Remove shim from the entangled specs check. Unlike the kernel where we have signed packages that must be kept in perfect lockstep with the unsigned packages, the shim-unsigned and shim packages need not be kept in perfect alignment. Given the update and upstream signing process for the shim binaries, it makes sense to follow the Fedora model and allow updating shim-unsigned, completing upstream signing, then later updating shim once we have the signed binaries. For shim, replace the macro-based BuildRequires on shim-unsigned-%{efiarch} with explicit architecture package names for x86_64 and aarch64. The previous dependency could resolve through an unversioned virtual provide on aarch64, which pulled in a freshly rebuilt shim-unsigned node and made delta build logic rebuild shim unnecessarily. That rebuild will fail when shim-unsigned is updated to a new version (e.g. 16.1) while shim remains at an earlier version.
1 parent 5f462e7 commit 7f740a4

2 files changed

Lines changed: 10 additions & 3 deletions

File tree

SPECS/shim/shim.spec

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
Summary: First stage UEFI bootloader
3838
Name: shim
3939
Version: 15.8
40-
Release: 5%{?dist}
40+
Release: 6%{?dist}
4141
License: BSD
4242
Vendor: Microsoft Corporation
4343
Distribution: Azure Linux
@@ -73,7 +73,12 @@ Provides: shim-unsigned = %{version}-%{release}
7373
# This is when grub was updated to be signed with the newer Azure Linux certificate
7474
Conflicts: grub2-efi-binary < 2.06-22
7575

76-
BuildRequires: shim-unsigned-%{efiarch} = %{version}-%{release}
76+
%ifarch x86_64
77+
BuildRequires: shim-unsigned-x64 = %{version}
78+
%endif
79+
%ifarch aarch64
80+
BuildRequires: shim-unsigned-aarch64 = %{version}
81+
%endif
7782
BuildRequires: binutils
7883
BuildRequires: coreutils
7984
BuildRequires: efivar
@@ -187,6 +192,9 @@ fi
187192
/boot/efi/EFI/%{efidir}/*
188193

189194
%changelog
195+
* Mon Mar 02 2026 Lynsey Rydberg <lyrydber@microsoft.com> - 15.8-6
196+
- Change BuildRequires to allow updating shim-unsigned separately
197+
190198
* Thu Nov 28 2024 Chris Co <chrco@microsoft.com> - 15.8-5
191199
- Add Provides for shim-unsigned
192200

toolkit/scripts/check_entangled_specs.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,6 @@
6060
"SPECS/cyrus-sasl-bootstrap/cyrus-sasl-bootstrap.spec"
6161
]),
6262
frozenset([
63-
"SPECS/shim/shim.spec",
6463
"SPECS/shim-unsigned-x64/shim-unsigned-x64.spec",
6564
"SPECS/shim-unsigned-aarch64/shim-unsigned-aarch64.spec"
6665
]),

0 commit comments

Comments
 (0)