Skip to content

Commit 983d4f0

Browse files
Merge PR "[AUTO-CHERRYPICK] Patch openssl for PKCS12_item_decrypt_d2i_ex(): Check oct argument for NULL - branch main" #16166
Co-authored-by: Archana Shettigar <v-shettigara@microsoft.com>
1 parent 9a69efe commit 983d4f0

6 files changed

Lines changed: 65 additions & 23 deletions

File tree

Lines changed: 38 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,38 @@
1+
Commit 00a87a8e: Add NULL check to PKCS12_item_decrypt_d2i_ex
2+
3+
Address CVE-2025-69421
4+
5+
Add NULL check for oct parameter
6+
7+
Reviewed-by: Saša Nedvědický <sashan@openssl.org>
8+
Reviewed-by: Eugene Syromiatnikov <esyr@openssl.org>
9+
Reviewed-by: Norbert Pocs <norbertp@openssl.org>
10+
Reviewed-by: Nikola Pajkovsky <nikolap@openssl.org>
11+
Reviewed-by: Neil Horman <nhorman@openssl.org>
12+
(Merged from https://github.com/openssl/premium/pull/12)
13+
14+
Upstream Reference Patch: https://msazure.visualstudio.com/PlatformCrypto/_git/openssl-msft/commit/00a87a8e7bc2a3cc780fcd645c3c4341b7d1bc54?path=/crypto/pkcs12
15+
---
16+
crypto/pkcs12/p12_decr.c | 6 ++++++
17+
1 file changed, 6 insertions(+)
18+
19+
diff --git a/crypto/pkcs12/p12_decr.c b/crypto/pkcs12/p12_decr.c
20+
index 3c86058..da2133d 100644
21+
--- a/crypto/pkcs12/p12_decr.c
22+
+++ b/crypto/pkcs12/p12_decr.c
23+
@@ -88,6 +88,12 @@ void *PKCS12_item_decrypt_d2i(const X509_ALGOR *algor, const ASN1_ITEM *it,
24+
void *ret;
25+
int outlen;
26+
27+
+ if (oct == NULL) {
28+
+ PKCS12err(PKCS12_F_PKCS12_ITEM_DECRYPT_D2I,
29+
+ PKCS12_R_INVALID_NULL_ARGUMENT);
30+
+ return NULL;
31+
+ }
32+
+
33+
if (!PKCS12_pbe_crypt(algor, pass, passlen, oct->data, oct->length,
34+
&out, &outlen, 0)) {
35+
PKCS12err(PKCS12_F_PKCS12_ITEM_DECRYPT_D2I,
36+
--
37+
2.45.4
38+

SPECS/openssl/openssl.spec

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
Summary: Utilities from the general purpose cryptography library with TLS implementation
55
Name: openssl
66
Version: 1.1.1k
7-
Release: 38%{?dist}
7+
Release: 39%{?dist}
88
License: OpenSSL
99
Vendor: Microsoft Corporation
1010
Distribution: Mariner
@@ -72,6 +72,7 @@ Patch48: openssl-1.1.1-fix-heap-buffer-overflow-in-BIO_f_linebuffer.patch
7272
Patch49: openssl-1.1.1-fix-OCB-AES-NI-HW-stream-path-unauthenticated-unencrypted.patch
7373
Patch50: openssl-1.1.1-check-return-code-of-UTF8_putc.patch
7474
Patch51: openssl-1.1.1-verify-ASN1-objects-types.patch
75+
Patch52: openssl-1.1.1-check-oct-argument-for-NULL.patch
7576

7677
BuildRequires: perl-Test-Warnings
7778
BuildRequires: perl-Text-Template
@@ -335,6 +336,9 @@ rm -f %{buildroot}%{_sysconfdir}/pki/tls/ct_log_list.cnf.dist
335336
%postun libs -p /sbin/ldconfig
336337

337338
%changelog
339+
* Wed Mar 11 2026 Archana Shettigar <v-shettigara@microsoft.com> - 1.1.1k-39
340+
- Patch PKCS12_item_decrypt_d2i_ex(): Check oct argument for NULL
341+
338342
* Fri Feb 20 2026 Kanishk Bansal <kanbansal@microsoft.com> - 1.1.1k-38
339343
- Ensure ASN1 types are checked before use in s_client, PKCS12, and PKCS7
340344
- Fix heap buffer overflow in BIO_f_linebuffer on short writes

toolkit/resources/manifests/package/pkggen_core_aarch64.txt

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -165,11 +165,11 @@ texinfo-6.8-1.cm2.aarch64.rpm
165165
gtk-doc-1.33.2-1.cm2.noarch.rpm
166166
autoconf-2.71-3.cm2.noarch.rpm
167167
automake-1.16.5-1.cm2.noarch.rpm
168-
openssl-1.1.1k-38.cm2.aarch64.rpm
169-
openssl-devel-1.1.1k-38.cm2.aarch64.rpm
170-
openssl-libs-1.1.1k-38.cm2.aarch64.rpm
171-
openssl-perl-1.1.1k-38.cm2.aarch64.rpm
172-
openssl-static-1.1.1k-38.cm2.aarch64.rpm
168+
openssl-1.1.1k-39.cm2.aarch64.rpm
169+
openssl-devel-1.1.1k-39.cm2.aarch64.rpm
170+
openssl-libs-1.1.1k-39.cm2.aarch64.rpm
171+
openssl-perl-1.1.1k-39.cm2.aarch64.rpm
172+
openssl-static-1.1.1k-39.cm2.aarch64.rpm
173173
libcap-2.60-7.cm2.aarch64.rpm
174174
libcap-devel-2.60-7.cm2.aarch64.rpm
175175
debugedit-5.0-2.cm2.aarch64.rpm

toolkit/resources/manifests/package/pkggen_core_x86_64.txt

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -165,11 +165,11 @@ texinfo-6.8-1.cm2.x86_64.rpm
165165
gtk-doc-1.33.2-1.cm2.noarch.rpm
166166
autoconf-2.71-3.cm2.noarch.rpm
167167
automake-1.16.5-1.cm2.noarch.rpm
168-
openssl-1.1.1k-38.cm2.x86_64.rpm
169-
openssl-devel-1.1.1k-38.cm2.x86_64.rpm
170-
openssl-libs-1.1.1k-38.cm2.x86_64.rpm
171-
openssl-perl-1.1.1k-38.cm2.x86_64.rpm
172-
openssl-static-1.1.1k-38.cm2.x86_64.rpm
168+
openssl-1.1.1k-39.cm2.x86_64.rpm
169+
openssl-devel-1.1.1k-39.cm2.x86_64.rpm
170+
openssl-libs-1.1.1k-39.cm2.x86_64.rpm
171+
openssl-perl-1.1.1k-39.cm2.x86_64.rpm
172+
openssl-static-1.1.1k-39.cm2.x86_64.rpm
173173
libcap-2.60-7.cm2.x86_64.rpm
174174
libcap-devel-2.60-7.cm2.x86_64.rpm
175175
debugedit-5.0-2.cm2.x86_64.rpm

toolkit/resources/manifests/package/toolchain_aarch64.txt

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -270,12 +270,12 @@ npth-1.6-4.cm2.aarch64.rpm
270270
npth-debuginfo-1.6-4.cm2.aarch64.rpm
271271
npth-devel-1.6-4.cm2.aarch64.rpm
272272
ntsysv-1.20-4.cm2.aarch64.rpm
273-
openssl-1.1.1k-38.cm2.aarch64.rpm
274-
openssl-debuginfo-1.1.1k-38.cm2.aarch64.rpm
275-
openssl-devel-1.1.1k-38.cm2.aarch64.rpm
276-
openssl-libs-1.1.1k-38.cm2.aarch64.rpm
277-
openssl-perl-1.1.1k-38.cm2.aarch64.rpm
278-
openssl-static-1.1.1k-38.cm2.aarch64.rpm
273+
openssl-1.1.1k-39.cm2.aarch64.rpm
274+
openssl-debuginfo-1.1.1k-39.cm2.aarch64.rpm
275+
openssl-devel-1.1.1k-39.cm2.aarch64.rpm
276+
openssl-libs-1.1.1k-39.cm2.aarch64.rpm
277+
openssl-perl-1.1.1k-39.cm2.aarch64.rpm
278+
openssl-static-1.1.1k-39.cm2.aarch64.rpm
279279
p11-kit-0.24.1-1.cm2.aarch64.rpm
280280
p11-kit-debuginfo-0.24.1-1.cm2.aarch64.rpm
281281
p11-kit-devel-0.24.1-1.cm2.aarch64.rpm

toolkit/resources/manifests/package/toolchain_x86_64.txt

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -276,12 +276,12 @@ npth-1.6-4.cm2.x86_64.rpm
276276
npth-debuginfo-1.6-4.cm2.x86_64.rpm
277277
npth-devel-1.6-4.cm2.x86_64.rpm
278278
ntsysv-1.20-4.cm2.x86_64.rpm
279-
openssl-1.1.1k-38.cm2.x86_64.rpm
280-
openssl-debuginfo-1.1.1k-38.cm2.x86_64.rpm
281-
openssl-devel-1.1.1k-38.cm2.x86_64.rpm
282-
openssl-libs-1.1.1k-38.cm2.x86_64.rpm
283-
openssl-perl-1.1.1k-38.cm2.x86_64.rpm
284-
openssl-static-1.1.1k-38.cm2.x86_64.rpm
279+
openssl-1.1.1k-39.cm2.x86_64.rpm
280+
openssl-debuginfo-1.1.1k-39.cm2.x86_64.rpm
281+
openssl-devel-1.1.1k-39.cm2.x86_64.rpm
282+
openssl-libs-1.1.1k-39.cm2.x86_64.rpm
283+
openssl-perl-1.1.1k-39.cm2.x86_64.rpm
284+
openssl-static-1.1.1k-39.cm2.x86_64.rpm
285285
p11-kit-0.24.1-1.cm2.x86_64.rpm
286286
p11-kit-debuginfo-0.24.1-1.cm2.x86_64.rpm
287287
p11-kit-devel-0.24.1-1.cm2.x86_64.rpm

0 commit comments

Comments
 (0)