Skip to content

Commit c091748

Browse files
authored
Revert "Kata: Release v3.2.0.azl0 for both vanilla and CC based on aligned sources (#6942)" (#7920)
1 parent 61fb513 commit c091748

14 files changed

Lines changed: 687 additions & 66 deletions
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"Signatures": {
33
"mariner-coco-build-uvm.sh": "4f2be6965d8c4d7919fd201a68160fc8ab02a1be50a336abbfea13f16a6ffb89",
4-
"kata-containers-cc-3.2.0.azl0-cargo.tar.gz": "7ff6c5f7f7aa31a99ea5d837876291d886b16c32f21b6d65d044fd398abff1e6",
5-
"kata-containers-cc-3.2.0.azl0.tar.gz": "78f3749c848c77f0d54aa16a4f29209a07f3d4af30664c0d9212300ac364aaec"
4+
"kata-containers-cc-0.6.3-cargo.tar.gz": "7ff6c5f7f7aa31a99ea5d837876291d886b16c32f21b6d65d044fd398abff1e6",
5+
"kata-containers-cc-0.6.3.tar.gz": "1f366ce70bf83a239a7ec99334506adb28c3199157b4370840c3685378a34268"
66
}
77
}

SPECS/kata-containers-cc/kata-containers-cc.spec

Lines changed: 17 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
%global runtime_make_vars DEFMEMSZ=256 \\\
2+
DEFSHAREDFS_CLH_SNP_VIRTIOFS=none \\\
23
DEFSTATICSANDBOXWORKLOADMEM=1792 \\\
3-
DEFSNPGUEST=true \\\
44
SKIP_GO_VERSION_CHECK=1
55

66
%global agent_make_vars LIBC=gnu \\\
@@ -9,15 +9,16 @@
99
%global debug_package %{nil}
1010

1111
Name: kata-containers-cc
12-
Version: 3.2.0.azl0
13-
Release: 1%{?dist}
12+
Version: 0.6.3
13+
Release: 4%{?dist}
1414
Summary: Kata Confidential Containers package developed for Confidential Containers on AKS
1515
License: ASL 2.0
1616
Vendor: Microsoft Corporation
1717
URL: https://github.com/microsoft/kata-containers
18-
Source0: https://github.com/microsoft/kata-containers/archive/refs/tags/%{version}.tar.gz#/%{name}-%{version}.tar.gz
19-
Source1: %{name}-%{version}-cargo.tar.gz
20-
Source2: mariner-coco-build-uvm.sh
18+
Source0: https://github.com/microsoft/kata-containers/archive/refs/tags/cc-%{version}.tar.gz#/%{name}-%{version}.tar.gz
19+
Source1: https://github.com/microsoft/kata-containers/archive/refs/tags/%{name}-%{version}.tar.gz
20+
Source2: %{name}-%{version}-cargo.tar.gz
21+
Source3: mariner-coco-build-uvm.sh
2122

2223
ExclusiveArch: x86_64
2324

@@ -69,7 +70,7 @@ This package contains the the tooling and files required to build the UVM
6970
%prep
7071
%autosetup -p1 -n %{name}-%{version}
7172
pushd %{_builddir}/%{name}-%{version}
72-
tar -xf %{SOURCE1}
73+
tar -xf %{SOURCE2}
7374
popd
7475

7576
%build
@@ -137,7 +138,7 @@ pushd %{_builddir}/%{name}-%{version}
137138
rm tools/osbuilder/.gitignore
138139
rm tools/osbuilder/rootfs-builder/.gitignore
139140

140-
install -D -m 0755 %{SOURCE2} %{buildroot}%{osbuilder}/mariner-coco-build-uvm.sh
141+
install -D -m 0755 %{SOURCE3} %{buildroot}%{osbuilder}/mariner-coco-build-uvm.sh
141142
install -D -m 0644 VERSION %{buildroot}%{osbuilder}/VERSION
142143
install -D -m 0644 ci/install_yq.sh %{buildroot}%{osbuilder}/ci/install_yq.sh
143144
install -D -m 0644 versions.yaml %{buildroot}%{osbuilder}/versions.yaml
@@ -184,27 +185,14 @@ install -D -m 0755 kata-monitor %{buildroot}%{coco_bin}/kata-monitor
184185
install -D -m 0755 kata-runtime %{buildroot}%{coco_bin}/kata-runtime
185186
install -D -m 0755 data/kata-collect-data.sh %{buildroot}%{coco_bin}/kata-collect-data.sh
186187

187-
# We deploy 3 configurations:
188-
# configuration-clh-snp: production Kata-CC - IGVM & image, confidential_guest=true, sev_snp_guest=true
189-
# configuration-clh-snp-debug: debug Kata-CC - kernel & image, confidential_guest=true, sev_snp_guest=false
190-
# configuration-clh (symlinked to by configuration.toml): vanilla Kata - kernel & initrd, confidential_guest=false, sev_snp_guest=false
191-
install -D -m 0644 config/configuration-clh-snp.toml %{buildroot}/%{defaults_kata}/configuration-clh-snp.toml
192-
install -D -m 0644 config/configuration-clh.toml %{buildroot}/%{defaults_kata}/configuration-clh-snp-debug.toml
188+
# Note: we deploy two configurations - the additional one is for policy/snapshotter testing w/o SEV SNP or IGVM
193189
install -D -m 0644 config/configuration-clh.toml %{buildroot}/%{defaults_kata}/configuration-clh.toml
190+
install -D -m 0644 config/configuration-clh-snp.toml %{buildroot}/%{defaults_kata}/configuration-clh-snp.toml
194191

195-
# Adapt configuration files:
196-
# - Change paths with locations specific to our distribution.
197-
sed --follow-symlinks -i 's|/usr|/opt/confidential-containers|g' %{buildroot}/%{defaults_kata}/configuration-clh*.toml
198-
# - Set up configuration-clh-snp-debug. Note that kernel and image are already
199-
# set through configuration-clh.toml.in.
200-
sed -i 's|-igvm.img|-igvm-debug.img|g' %{buildroot}/%{defaults_kata}/configuration-clh-snp-debug.toml
201-
sed -i '/^#confidential_guest =/s|^#||g' %{buildroot}/%{defaults_kata}/configuration-clh-snp-debug.toml
202-
sed -i '/^#enable_debug =/s|^#||g' %{buildroot}/%{defaults_kata}/configuration-clh-snp-debug.toml
203-
sed -i '/^#debug_console_enabled =/s|^#||g' %{buildroot}/%{defaults_kata}/configuration-clh-snp-debug.toml
204-
sed -i 's|shared_fs = "virtio-fs"|shared_fs = "none"|g' %{buildroot}/%{defaults_kata}/configuration-clh-snp-debug.toml
205-
# - Set up configuration-clh.
206-
sed -i '/^#initrd =/s|^#||g' %{buildroot}/%{defaults_kata}/configuration-clh.toml
207-
sed -i '/^image =/s|^|#|g' %{buildroot}/%{defaults_kata}/configuration-clh.toml
192+
# adapt upstream config files
193+
# change paths with locations specific to our distribution
194+
sed -i 's|/usr|/opt/confidential-containers|g' %{buildroot}/%{defaults_kata}/configuration-clh.toml
195+
sed -i 's|/usr|/opt/confidential-containers|g' %{buildroot}/%{defaults_kata}/configuration-clh-snp.toml
208196
popd
209197

210198
# tardev-snapshotter
@@ -287,11 +275,8 @@ install -D -m 0755 %{_builddir}/%{name}-%{version}/tools/osbuilder/image-builder
287275
%exclude %{osbuilder}/tools/osbuilder/rootfs-builder/ubuntu
288276

289277
%changelog
290-
* Mon Feb 12 2024 Aurelien Bombo <abombo@microsoft.com> - 3.2.0.azl0-1
291-
- Use Microsoft sources based on upstream Kata version 3.2.0.
292-
293-
* Fri Feb 02 2024 CBL-Mariner Servicing Account <cblmargh@microsoft.com> - 0.6.3-4
294-
- Bump release to rebuild with go 1.21.6
278+
* Fri Feb 02 2024 CBL-Mariner Servicing Account <cblmargh@microsoft.com> - 0.6.3-4
279+
- Bump release to rebuild with go 1.21.6
295280

296281
* Tue Jan 30 2024 Archana Choudhary <archana1@microsoft.com> - 0.6.3-3
297282
- Remove kernel-uvm-cvm(-devel) dependency
Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
From 0503cd61a56ed09de60981fedecc226df3845860 Mon Sep 17 00:00:00 2001
2+
From: dallasd1 <dadelan@microsoft.com>
3+
Date: Wed, 26 Jul 2023 08:40:44 -0700
4+
Subject: [PATCH] Append systemd kernel cmdline params for initrd
5+
6+
---
7+
src/runtime/pkg/katautils/create.go | 2 +-
8+
1 file changed, 1 insertion(+), 1 deletion(-)
9+
10+
diff --git a/src/runtime/pkg/katautils/create.go b/src/runtime/pkg/katautils/create.go
11+
index 67ea03dcf..2c829a691 100644
12+
--- a/src/runtime/pkg/katautils/create.go
13+
+++ b/src/runtime/pkg/katautils/create.go
14+
@@ -57,7 +57,7 @@ func getKernelParams(needSystemd, trace bool) []vc.Param {
15+
}
16+
17+
func needSystemd(config vc.HypervisorConfig) bool {
18+
- return config.ImagePath != ""
19+
+ return config.ImagePath != "" || config.InitrdPath != ""
20+
}
21+
22+
// HandleFactory set the factory
23+
--
24+
2.17.1
25+
Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
From 590604dca0f6a0636933be21fc6a490c0f17af34 Mon Sep 17 00:00:00 2001
2+
From: Daniel Mihai <dmihai@microsoft.com>
3+
Date: Tue, 16 Aug 2022 17:01:12 +0000
4+
Subject: [PATCH 2/3] Merged PR 9607: Allow 10 seconds for VM creation + start
5+
6+
Allow 10 seconds for VM creation + start
7+
---
8+
src/runtime/virtcontainers/clh.go | 4 +++-
9+
1 file changed, 3 insertions(+), 1 deletion(-)
10+
11+
diff --git a/src/runtime/virtcontainers/clh.go b/src/runtime/virtcontainers/clh.go
12+
index 71bd931..444d9de 100644
13+
--- a/src/runtime/virtcontainers/clh.go
14+
+++ b/src/runtime/virtcontainers/clh.go
15+
@@ -688,7 +688,9 @@ func (clh *cloudHypervisor) StartVM(ctx context.Context, timeout int) error {
16+
}
17+
clh.state.PID = pid
18+
19+
- ctx, cancel := context.WithTimeout(ctx, clh.getClhAPITimeout()*time.Second)
20+
+ // FIXME - for now allow more than one second to create and start the VM.
21+
+ //ctx, cancel := context.WithTimeout(ctx, clh.getClhAPITimeout()*time.Second)
22+
+ ctx, cancel := context.WithTimeout(ctx, 10*time.Second)
23+
defer cancel()
24+
25+
if err := clh.bootVM(ctx); err != nil {
26+
--
27+
2.25.1
28+
Lines changed: 122 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,122 @@
1+
From 36198274dcb4332f1acd445d2a80854232b1d236 Mon Sep 17 00:00:00 2001
2+
From: Dallas Delaney <dadelan@microsoft.com>
3+
Date: Thu, 26 Jan 2023 14:58:55 -0800
4+
Subject: [PATCH] osbuilder: Add support for CBL-Mariner
5+
6+
Add osbuilder support to build a rootfs and image
7+
based on the CBL-Mariner Linux distro
8+
9+
Fixes: #6462
10+
11+
Signed-off-by: Dallas Delaney <dadelan@microsoft.com>
12+
---
13+
tools/osbuilder/README.md | 14 +++++-----
14+
.../rootfs-builder/cbl-mariner/Dockerfile.in | 15 +++++++++++
15+
.../rootfs-builder/cbl-mariner/config.sh | 10 +++++++
16+
.../rootfs-builder/cbl-mariner/rootfs_lib.sh | 26 +++++++++++++++++++
17+
4 files changed, 58 insertions(+), 7 deletions(-)
18+
create mode 100644 tools/osbuilder/rootfs-builder/cbl-mariner/Dockerfile.in
19+
create mode 100644 tools/osbuilder/rootfs-builder/cbl-mariner/config.sh
20+
create mode 100644 tools/osbuilder/rootfs-builder/cbl-mariner/rootfs_lib.sh
21+
22+
diff --git a/tools/osbuilder/README.md b/tools/osbuilder/README.md
23+
index 343d2bf60..9415de74e 100644
24+
--- a/tools/osbuilder/README.md
25+
+++ b/tools/osbuilder/README.md
26+
@@ -80,7 +80,7 @@ filesystem components to generate an initrd.
27+
3. When generating an image, the initrd is extracted to obtain the base rootfs for
28+
the image.
29+
30+
-Ubuntu is the default distro for building the rootfs, to use a different one, you can set `DISTRO=alpine|clearlinux|debian|ubuntu`.
31+
+Ubuntu is the default distro for building the rootfs, to use a different one, you can set `DISTRO=alpine|clearlinux|debian|ubuntu|cbl-mariner`.
32+
For example `make USE_DOCKER=true DISTRO=alpine rootfs` will make an Alpine rootfs using Docker.
33+
34+
### Rootfs creation
35+
@@ -209,9 +209,9 @@ of the the osbuilder distributions.
36+
> Note: this table is not relevant for the dracut build method, since it supports
37+
any Linux distribution and architecture where dracut is available.
38+
39+
-| |Alpine |CentOS Stream |Clear Linux |Debian/Ubuntu |
40+
-|-- |-- |-- |-- |-- |
41+
-|**ARM64** |:heavy_check_mark:|:heavy_check_mark:| | |
42+
-|**PPC64le**| |:heavy_check_mark:| |:heavy_check_mark:|
43+
-|**s390x** | |:heavy_check_mark:| |:heavy_check_mark:|
44+
-|**x86_64** |:heavy_check_mark:|:heavy_check_mark:|:heavy_check_mark:|:heavy_check_mark:|
45+
+| |Alpine |CentOS Stream |Clear Linux |Debian/Ubuntu |CBL-Mariner |
46+
+|-- |-- |-- |-- |-- |-- |
47+
+|**ARM64** |:heavy_check_mark:|:heavy_check_mark:| | | |
48+
+|**PPC64le**| |:heavy_check_mark:| |:heavy_check_mark:| |
49+
+|**s390x** | |:heavy_check_mark:| |:heavy_check_mark:| |
50+
+|**x86_64** |:heavy_check_mark:|:heavy_check_mark:|:heavy_check_mark:|:heavy_check_mark:|:heavy_check_mark:|
51+
diff --git a/tools/osbuilder/rootfs-builder/cbl-mariner/Dockerfile.in b/tools/osbuilder/rootfs-builder/cbl-mariner/Dockerfile.in
52+
new file mode 100644
53+
index 000000000..6fa29807d
54+
--- /dev/null
55+
+++ b/tools/osbuilder/rootfs-builder/cbl-mariner/Dockerfile.in
56+
@@ -0,0 +1,15 @@
57+
+# Copyright (c) 2023 Microsoft Corporation
58+
+#
59+
+# SPDX-License-Identifier: Apache-2.0
60+
+
61+
+ARG IMAGE_REGISTRY=mcr.microsoft.com
62+
+FROM ${IMAGE_REGISTRY}/cbl-mariner/base/core:@OS_VERSION@
63+
+
64+
+RUN tdnf -y install \
65+
+ ca-certificates \
66+
+ build-essential \
67+
+ dnf \
68+
+ git \
69+
+ tar
70+
+
71+
+@INSTALL_RUST@
72+
diff --git a/tools/osbuilder/rootfs-builder/cbl-mariner/config.sh b/tools/osbuilder/rootfs-builder/cbl-mariner/config.sh
73+
new file mode 100644
74+
index 000000000..694124acd
75+
--- /dev/null
76+
+++ b/tools/osbuilder/rootfs-builder/cbl-mariner/config.sh
77+
@@ -0,0 +1,10 @@
78+
+# Copyright (c) 2023 Microsoft Corporation
79+
+#
80+
+# SPDX-License-Identifier: Apache-2.0
81+
+
82+
+OS_NAME=cbl-mariner
83+
+OS_VERSION=${OS_VERSION:-2.0}
84+
+LIBC="gnu"
85+
+PACKAGES="core-packages-base-image ca-certificates"
86+
+[ "$AGENT_INIT" = no ] && PACKAGES+=" systemd"
87+
+[ "$SECCOMP" = yes ] && PACKAGES+=" libseccomp"
88+
diff --git a/tools/osbuilder/rootfs-builder/cbl-mariner/rootfs_lib.sh b/tools/osbuilder/rootfs-builder/cbl-mariner/rootfs_lib.sh
89+
new file mode 100644
90+
index 000000000..0288d4d77
91+
--- /dev/null
92+
+++ b/tools/osbuilder/rootfs-builder/cbl-mariner/rootfs_lib.sh
93+
@@ -0,0 +1,26 @@
94+
+# Copyright (c) 2023 Microsoft Corporation
95+
+#
96+
+# SPDX-License-Identifier: Apache-2.0
97+
+
98+
+build_rootfs()
99+
+{
100+
+ # Mandatory
101+
+ local ROOTFS_DIR="$1"
102+
+
103+
+ [ -z "$ROOTFS_DIR" ] && die "need rootfs"
104+
+
105+
+ # In case of support EXTRA packages, use it to allow
106+
+ # users add more packages to the base rootfs
107+
+ local EXTRA_PKGS=${EXTRA_PKGS:-""}
108+
+
109+
+ check_root
110+
+ mkdir -p "${ROOTFS_DIR}"
111+
+ PKG_MANAGER="tdnf"
112+
+
113+
+ DNF="${PKG_MANAGER} -y --installroot=${ROOTFS_DIR} --noplugins --releasever=${OS_VERSION}"
114+
+
115+
+ info "install packages for rootfs"
116+
+ $DNF install ${EXTRA_PKGS} ${PACKAGES}
117+
+
118+
+ rm -rf ${ROOTFS_DIR}/usr/share/{bash-completion,cracklib,doc,info,locale,man,misc,pixmaps,terminfo,zoneinfo,zsh}
119+
+}
120+
--
121+
2.33.8
122+
Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
1+
From ec322fec7e9c132c4caa0a93175320cb0d8fba73 Mon Sep 17 00:00:00 2001
2+
From: Daniel Mihai <dmihai@microsoft.com>
3+
Date: Mon, 22 Aug 2022 22:02:31 +0000
4+
Subject: [PATCH 3/3] Merged PR 9671: Wait for a possibly slow Guest
5+
6+
Wait for a possibly slow Guest
7+
8+
On some Host VMs it takes longer than 30 seconds to connect to
9+
the Agent - e.g., if enable_debug is enabled for [hypervisor.clh].
10+
---
11+
src/runtime/config/configuration-clh.toml.in | 2 +-
12+
1 file changed, 1 insertion(+), 1 deletion(-)
13+
14+
diff --git a/src/runtime/config/configuration-clh.toml.in b/src/runtime/config/configuration-clh.toml.in
15+
index f09c095f..0ce7a98d 100644
16+
--- a/src/runtime/config/configuration-clh.toml.in
17+
+++ b/src/runtime/config/configuration-clh.toml.in
18+
@@ -289,7 +289,7 @@ block_device_driver = "virtio-blk"
19+
20+
# Agent connection dialing timeout value in seconds
21+
# (default: 30)
22+
-#dial_timeout = 30
23+
+dial_timeout = 60
24+
25+
[runtime]
26+
# If enabled, the runtime will log additional debug messages to the
27+
--
28+
2.17.1
29+
Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
From 67e4b4ceaefea83a1e5c77a7760fa1f9b37589f4 Mon Sep 17 00:00:00 2001
2+
From: Daniel Mihai <dmihai@microsoft.com>
3+
Date: Thu, 1 Sep 2022 15:07:16 +0000
4+
Subject: [PATCH 09/10] Merged PR 9805: Add support for MSHV
5+
6+
Cloud Hypervisor is able to use either /dev/mshv or /dev/kvm.
7+
---
8+
src/runtime/pkg/resourcecontrol/cgroups.go | 3 ++-
9+
1 file changed, 2 insertions(+), 1 deletion(-)
10+
11+
diff --git a/src/runtime/pkg/resourcecontrol/cgroups.go b/src/runtime/pkg/resourcecontrol/cgroups.go
12+
index 4210392d..d4608458 100644
13+
--- a/src/runtime/pkg/resourcecontrol/cgroups.go
14+
+++ b/src/runtime/pkg/resourcecontrol/cgroups.go
15+
@@ -64,7 +64,8 @@ func sandboxDevices() []specs.LinuxDeviceCgroup {
16+
// In order to run Virtual Machines and create virtqueues, hypervisors
17+
// need access to certain character devices in the host, like kvm and vhost-net.
18+
hypervisorDevices := []string{
19+
- "/dev/kvm", // To run virtual machines
20+
+ "/dev/kvm", // To run virtual machines using KVM
21+
+ "/dev/mshv", // To run virtual machines using MSHV
22+
"/dev/vhost-net", // To create virtqueues
23+
"/dev/vfio/vfio", // To access VFIO devices
24+
"/dev/vhost-vsock", // To interact with vsock if
25+
--
26+
2.17.1
27+
Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
From c844e8011f0726e2a371115c209d4c3d63273b3b Mon Sep 17 00:00:00 2001
2+
From: Daniel Mihai <dmihai@microsoft.com>
3+
Date: Thu, 1 Sep 2022 15:54:16 +0000
4+
Subject: [PATCH 10/10] Merged PR 9806: Fix enable_debug for [hypervisor.clh]
5+
6+
Fix error when using enable_debug = true in configuration.toml:
7+
8+
level=error msg="Error create pseudo tty"
9+
error="open /dev/ptmx: operation not permitted"
10+
---
11+
src/runtime/pkg/resourcecontrol/cgroups.go | 1 +
12+
1 file changed, 1 insertion(+)
13+
14+
diff --git a/src/runtime/pkg/resourcecontrol/cgroups.go b/src/runtime/pkg/resourcecontrol/cgroups.go
15+
index d4608458..f674e97a 100644
16+
--- a/src/runtime/pkg/resourcecontrol/cgroups.go
17+
+++ b/src/runtime/pkg/resourcecontrol/cgroups.go
18+
@@ -57,6 +57,7 @@ func sandboxDevices() []specs.LinuxDeviceCgroup {
19+
"/dev/zero",
20+
"/dev/urandom",
21+
"/dev/console",
22+
+ "/dev/ptmx",
23+
}
24+
25+
// Processes running in a device-cgroup are constrained, they have acccess
26+
--
27+
2.17.1
28+
Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
From 7fab743a43e4f2063d560161753f2b6390c7add6 Mon Sep 17 00:00:00 2001
2+
From: Dan Mihai <dmihai@microsoft.com>
3+
Date: Thu, 15 Sep 2022 20:50:12 +0000
4+
Subject: [PATCH] Merged PR 9956: shim: avoid memory hotplug timeout
5+
6+
Wait up to 10 seconds for cloud-hypervisor memory hotplug.
7+
---
8+
src/runtime/virtcontainers/clh.go | 4 +++-
9+
1 file changed, 3 insertions(+), 1 deletion(-)
10+
11+
diff --git a/src/runtime/virtcontainers/clh.go b/src/runtime/virtcontainers/clh.go
12+
index 118e1b4d..f18b6c6f 100644
13+
--- a/src/runtime/virtcontainers/clh.go
14+
+++ b/src/runtime/virtcontainers/clh.go
15+
@@ -918,7 +918,9 @@ func (clh *cloudHypervisor) ResizeMemory(ctx context.Context, reqMemMB uint32, m
16+
}
17+
18+
cl := clh.client()
19+
- ctx, cancelResize := context.WithTimeout(ctx, clh.getClhAPITimeout()*time.Second)
20+
+ // FIXME: memory hotplug sometimes takes longer than 1 second.
21+
+ // ctx, cancelResize := context.WithTimeout(ctx, clh.getClhAPITimeout()*time.Second)
22+
+ ctx, cancelResize := context.WithTimeout(ctx, 10*time.Second)
23+
defer cancelResize()
24+
25+
resize := *chclient.NewVmResize()
26+
--
27+
2.17.1
28+

0 commit comments

Comments
 (0)