add patch for cloud-init pkg install error (#8422)

Co-authored-by: minghe <rmhsawyer>

Author: rmhsawyer

SPECS/cloud-init/cloud-init.spec

@@ -1,7 +1,7 @@
 Summary:        Cloud instance init scripts
 Name:           cloud-init
 Version:        23.4.1
-Release:        3%{?dist}
+Release:        4%{?dist}
 License:        GPLv3
 Vendor:         Microsoft Corporation
 Distribution:   Mariner
@@ -11,6 +11,7 @@ Source0:        https://launchpad.net/cloud-init/trunk/%{version}/+download/%{na
 Source1:        10-azure-kvp.cfg
 Patch0:         Retain-exit-code-in-cloud-init-status-for-recoverabl.patch
 Patch1:         ci-Pin-pytest-8.0.0.patch
+Patch2:         exec_cmd_error_handling.patch
 %define cl_services cloud-config.service cloud-config.target cloud-final.service cloud-init.service cloud-init.target cloud-init-local.service
 BuildRequires:  automake
 BuildRequires:  dbus
@@ -146,6 +147,9 @@ make check %{?_smp_mflags}
 %config(noreplace) %{_sysconfdir}/cloud/cloud.cfg.d/10-azure-kvp.cfg
 
 %changelog
+* Wed Mar 13 2024 Minghe Ren <mingheren@microsoft.com> - 23.4.1-4
+- Add patch to resolve error handling approach when executing command
+
 * Fri Feb 09 2024 Chris Co <chrco@microsoft.com> - 23.4.1-3
 - Add patch to pin pytest to <8.0.0 so cloud-init tests run correctly
 

SPECS/cloud-init/exec_cmd_error_handling.patch

@@ -0,0 +1,25 @@
+diff -ruN a/cloudinit/distros/photon.py b/cloudinit/distros/photon.py
+--- a/cloudinit/distros/photon.py	2023-12-14 09:17:35.000000000 -0800
++++ b/cloudinit/distros/photon.py	2024-03-20 14:34:15.375591963 -0700
+@@ -45,7 +45,6 @@
+                 LOG.warning(
+                     "Running %s resulted in stderr output: %s", cmd, err
+                 )
+-                return True, out, err
+             return False, out, err
+         except subp.ProcessExecutionError:
+             util.logexc(LOG, "Command %s failed", cmd)
+diff -ruN a/tests/unittests/distros/test_photon.py b/tests/unittests/distros/test_photon.py
+--- a/tests/unittests/distros/test_photon.py	2023-12-14 09:17:35.000000000 -0800
++++ b/tests/unittests/distros/test_photon.py	2024-03-20 14:57:38.141906589 -0700
+@@ -42,11 +42,6 @@
+         ret = self.distro._read_hostname(hostfile)
+         self.assertEqual(ret, hostname)
+ 
+-        self.logs.truncate(0)
+-        m_subp.return_value = (None, "bla")
+-        self.distro._write_hostname(hostname, None)
+-        self.assertIn("Error while setting hostname", self.logs.getvalue())
+-
+     @mock.patch("cloudinit.net.generate_fallback_config")
+     def test_fallback_netcfg(self, m_fallback_cfg):