Skip to content

Commit e78ca42

Browse files
authored
Provide an option not to auto-clean toolchain during daily-build (#11279)
1 parent c36b428 commit e78ca42

3 files changed

Lines changed: 12 additions & 0 deletions

File tree

toolkit/docs/building/building.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -589,6 +589,14 @@ also augment the URL list.
589589

590590
> Use the daily build sources for the given date. `lkg` will use the last known good build.
591591
592+
##### `DAILY_BUILD_SKIP_TOOLCHAIN_AUTO_CLEANUP=`**`n`** *(default)*
593+
594+
> Delete the already downloaded toolchain RPMs and freshly download from LKG repo
595+
596+
##### `DAILY_BUILD_SKIP_TOOLCHAIN_AUTO_CLEANUP=`**`y`**
597+
598+
> Don't delete the already download tolchain RPMs to save time. Use only if are sure about this behaviour.
599+
592600
#### `DISABLE_UPSTREAM_REPOS=...`
593601

594602
##### `DISABLE_UPSTREAM_REPOS=`**`n`** *(default)*

toolkit/scripts/daily_build.mk

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,8 @@ DAILY_BUILD_ID ?=
2424
DAILY_BUILD_ID_UPDATE_MANIFESTS ?= y
2525
##help:var:DAILY_BUILD_REPO={path to daily.repo}=Path to the daily build repo file to use.
2626
DAILY_BUILD_REPO ?=
27+
##help:var:DAILY_BUILD_SKIP_TOOLCHAIN_AUTO_CLEANUP={y,n}=Skip Deleting all downloaded toolchain RPMs when using a daily build.
28+
DAILY_BUILD_SKIP_TOOLCHAIN_AUTO_CLEANUP ?= n
2729

2830
daily_lkg_workdir = $(BUILD_DIR)/daily_build_id
2931

toolkit/scripts/toolchain.mk

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -94,8 +94,10 @@ clean-toolchain-rpms:
9494
# We leave the directory structure in place since docker based builds using re-usable chroots will have mounted the
9595
# toolchain subdirectories into the chroots. Removing the directories would break the mounts.
9696
$(STATUS_FLAGS_DIR)/toolchain_auto_cleanup.flag: $(STATUS_FLAGS_DIR)/daily_build_id.flag $(depend_VALIDATE_TOOLCHAIN_GPG)
97+
ifeq ($(SKIP_TOOLCHAIN_AUTO_CLEANUP),n)
9798
@echo "Daily build ID or validation mode changed, sanitizing toolchain"
9899
find $(TOOLCHAIN_RPMS_DIR) -type f -name '*.rpm' -exec rm -f {} +
100+
endif
99101
touch $@
100102
101103
copy-toolchain-rpms:

0 commit comments

Comments
 (0)