Skip to content

Commit eb3db74

Browse files
[AUTO-CHERRYPICK] Patch libcap for CVE-2025-1390 [Medium] - branch main (#12585)
Co-authored-by: Kanishk Bansal <103916909+Kanishk-Bansal@users.noreply.github.com>
1 parent 17f1826 commit eb3db74

6 files changed

Lines changed: 46 additions & 11 deletions

File tree

SPECS/libcap/CVE-2025-1390.patch

Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
1+
From 1ad42b66c3567481cc5fa22fc1ba1556a316d878 Mon Sep 17 00:00:00 2001
2+
From: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
3+
Date: Mon, 17 Feb 2025 10:31:55 +0800
4+
Subject: pam_cap: Fix potential configuration parsing error
5+
6+
The current configuration parsing does not actually skip user names
7+
that do not start with @, but instead treats the name as a group
8+
name for further parsing, which can result in matching unexpected
9+
capability sets and may trigger potential security issues. Only
10+
names starting with @ should be parsed as group names.
11+
12+
Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
13+
Signed-off-by: Andrew G. Morgan <morgan@kernel.org>
14+
---
15+
pam_cap/pam_cap.c | 1 +
16+
1 file changed, 1 insertion(+)
17+
18+
diff --git a/pam_cap/pam_cap.c b/pam_cap/pam_cap.c
19+
index 24de329..3ec99bb 100644
20+
--- a/pam_cap/pam_cap.c
21+
+++ b/pam_cap/pam_cap.c
22+
@@ -166,6 +166,7 @@ static char *read_capabilities_for_user(const char *user, const char *source)
23+
24+
if (line[0] != '@') {
25+
D(("user [%s] is not [%s] - skipping", user, line));
26+
+ continue;
27+
}
28+
29+
int i;
30+
--
31+
cgit 1.2.3-korg

SPECS/libcap/libcap.spec

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
Summary: Libcap
22
Name: libcap
33
Version: 2.60
4-
Release: 2%{?dist}
4+
Release: 3%{?dist}
55
License: GPLv2+
66
Group: System Environment/Security
77
URL: https://www.gnu.org/software/hurd/community/gsoc/project_ideas/libcap.html
@@ -10,6 +10,7 @@ Vendor: Microsoft Corporation
1010
Distribution: Mariner
1111
Patch0: CVE-2023-2602.patch
1212
Patch1: CVE-2023-2603.patch
13+
Patch2: CVE-2025-1390.patch
1314

1415
%description
1516
The libcap package implements the user-space interfaces to the POSIX 1003.1e capabilities available
@@ -60,6 +61,9 @@ sed -i "s|pass_capsh --chroot=\$(/bin/pwd) ==||g" quicktest.sh
6061
%{_mandir}/man3/*
6162

6263
%changelog
64+
* Sun Feb 23 2025 Kanishk Bansal <kanbansal@microsoft.com> - 2.60-3
65+
- Patch CVE-2025-1390
66+
6367
* Thu Jun 15 2023 Henry Li <lihl@microsoft.com> - 2.60-2
6468
- Add patch to resolve CVE-2023-2602 and CVE-2023-2603
6569
- Use autosetup

toolkit/resources/manifests/package/pkggen_core_aarch64.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -170,8 +170,8 @@ openssl-devel-1.1.1k-35.cm2.aarch64.rpm
170170
openssl-libs-1.1.1k-35.cm2.aarch64.rpm
171171
openssl-perl-1.1.1k-35.cm2.aarch64.rpm
172172
openssl-static-1.1.1k-35.cm2.aarch64.rpm
173-
libcap-2.60-2.cm2.aarch64.rpm
174-
libcap-devel-2.60-2.cm2.aarch64.rpm
173+
libcap-2.60-3.cm2.aarch64.rpm
174+
libcap-devel-2.60-3.cm2.aarch64.rpm
175175
debugedit-5.0-2.cm2.aarch64.rpm
176176
libarchive-3.6.1-4.cm2.aarch64.rpm
177177
libarchive-devel-3.6.1-4.cm2.aarch64.rpm

toolkit/resources/manifests/package/pkggen_core_x86_64.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -170,8 +170,8 @@ openssl-devel-1.1.1k-35.cm2.x86_64.rpm
170170
openssl-libs-1.1.1k-35.cm2.x86_64.rpm
171171
openssl-perl-1.1.1k-35.cm2.x86_64.rpm
172172
openssl-static-1.1.1k-35.cm2.x86_64.rpm
173-
libcap-2.60-2.cm2.x86_64.rpm
174-
libcap-devel-2.60-2.cm2.x86_64.rpm
173+
libcap-2.60-3.cm2.x86_64.rpm
174+
libcap-devel-2.60-3.cm2.x86_64.rpm
175175
debugedit-5.0-2.cm2.x86_64.rpm
176176
libarchive-3.6.1-4.cm2.x86_64.rpm
177177
libarchive-devel-3.6.1-4.cm2.x86_64.rpm

toolkit/resources/manifests/package/toolchain_aarch64.txt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -151,9 +151,9 @@ libassuan-2.5.5-2.cm2.aarch64.rpm
151151
libassuan-debuginfo-2.5.5-2.cm2.aarch64.rpm
152152
libassuan-devel-2.5.5-2.cm2.aarch64.rpm
153153
libbacktrace-static-11.2.0-8.cm2.aarch64.rpm
154-
libcap-2.60-2.cm2.aarch64.rpm
155-
libcap-debuginfo-2.60-2.cm2.aarch64.rpm
156-
libcap-devel-2.60-2.cm2.aarch64.rpm
154+
libcap-2.60-3.cm2.aarch64.rpm
155+
libcap-debuginfo-2.60-3.cm2.aarch64.rpm
156+
libcap-devel-2.60-3.cm2.aarch64.rpm
157157
libcap-ng-0.8.2-2.cm2.aarch64.rpm
158158
libcap-ng-debuginfo-0.8.2-2.cm2.aarch64.rpm
159159
libcap-ng-devel-0.8.2-2.cm2.aarch64.rpm

toolkit/resources/manifests/package/toolchain_x86_64.txt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -157,9 +157,9 @@ libassuan-2.5.5-2.cm2.x86_64.rpm
157157
libassuan-debuginfo-2.5.5-2.cm2.x86_64.rpm
158158
libassuan-devel-2.5.5-2.cm2.x86_64.rpm
159159
libbacktrace-static-11.2.0-8.cm2.x86_64.rpm
160-
libcap-2.60-2.cm2.x86_64.rpm
161-
libcap-debuginfo-2.60-2.cm2.x86_64.rpm
162-
libcap-devel-2.60-2.cm2.x86_64.rpm
160+
libcap-2.60-3.cm2.x86_64.rpm
161+
libcap-debuginfo-2.60-3.cm2.x86_64.rpm
162+
libcap-devel-2.60-3.cm2.x86_64.rpm
163163
libcap-ng-0.8.2-2.cm2.x86_64.rpm
164164
libcap-ng-debuginfo-0.8.2-2.cm2.x86_64.rpm
165165
libcap-ng-devel-0.8.2-2.cm2.x86_64.rpm

0 commit comments

Comments
 (0)