Address SymPy automation review feedback

Co-authored-by: bschnurr <1946977+bschnurr@users.noreply.github.com>

Author: Copilot

.github/workflows/sympy-stub-retirement.yml

@@ -34,6 +34,7 @@ jobs:
         run: |
           python - <<'PY'
           import json
+          import os
           import pathlib
           report = json.loads(pathlib.Path("artifacts/sympy-typing.json").read_text())
           paths = [pathlib.Path("stubs/sympy-stubs") / path for path in report["candidates"]]
@@ -45,16 +46,15 @@ jobs:
           pathlib.Path("artifacts/removed-files.txt").write_text(
               "\n".join(str(path) for path in paths) + ("\n" if paths else "")
           )
-          with pathlib.Path(__import__("os").environ["GITHUB_OUTPUT"]).open("a") as output:
+          with pathlib.Path(os.environ["GITHUB_OUTPUT"]).open("a") as output:
               output.write(f"count={len(paths)}\n")
           pathlib.Path("artifacts/pull-request-body.md").write_text(
               "Automated monthly SymPy typing comparison.\n\n"
               f"SymPy version: `{report['sympy_version']}`.\n"
               "Removed files:\n"
               + "".join(f"- `{path}`\n" for path in paths)
-              + f"\nWorkflow run: {__import__('os').environ['GITHUB_SERVER_URL']}/"
-              f"{__import__('os').environ['GITHUB_REPOSITORY']}/actions/runs/"
-              f"{__import__('os').environ['GITHUB_RUN_ID']}.\n\n"
+              + f"\nWorkflow run: {os.environ['GITHUB_SERVER_URL']}/"
+              f"{os.environ['GITHUB_REPOSITORY']}/actions/runs/{os.environ['GITHUB_RUN_ID']}.\n\n"
               "A file is removed only when every material declaration maps by name and kind "
               "to an upstream declaration with annotations on every non-`self`/`cls` parameter "
               "and its return value. Classes are structurally matched and their explicit members "

utils/README.md

@@ -44,4 +44,4 @@ or `simplify/simplify.pyi`, which were performance workarounds. To assess those,
 run the smoke command with and without the relevant stub and compare its reported
 elapsed time manually; timing is intentionally not an automatic deletion gate.
 Add another relative `.pyi` path to
-`PROTECTED_FILES` when a stub has value structural comparison cannot detect.
+`PROTECTED_FILES` when a stub provides value structural comparison cannot detect.

utils/compare_sympy_typing.py

@@ -164,7 +164,7 @@ def markdown(report: dict[str, Any]) -> str:
         if file["candidate"] or file["protected"]:
             continue
         reasons = sorted({declaration["reason"] for declaration in file["declarations"] if declaration["status"] != TYPED})
-        lines.append(f"- `{file['stub_file']}`: {' '.join(reasons)}")
+        lines.append(f"- `{file['stub_file']}`: {' '.join(reasons) or 'No material declarations were found.'}")
     return "\n".join(lines) + "\n"
 
 

utils/run_sympy_analysis_smoke.py

@@ -18,10 +18,12 @@ def main() -> int:
     result = subprocess.run((sys.executable, "-m", "pyright", str(args.fixture)), check=False)
     elapsed = time.monotonic() - started
     print(f"Pyright smoke test completed in {elapsed:.1f}s (limit: {args.max_seconds:.1f}s).")
+    if result.returncode:
+        return result.returncode
     if elapsed > args.max_seconds:
         print("Pyright smoke test exceeded the generous gross-regression threshold.", file=sys.stderr)
         return 1
-    return result.returncode
+    return 0
 
 
 if __name__ == "__main__":