From 192b670927f55136d113d046fab89d3b7f9e1246 Mon Sep 17 00:00:00 2001
From: Jakub Jares <jajares@microsoft.com>
Date: Wed, 1 Jul 2026 13:33:44 +0200
Subject: [PATCH] Drop Microsoft.NET.Test.Sdk from the MSTest metapackage

MSTest runs as a Microsoft.Testing.Platform app, so it doesn't need the
classic VSTest runner. Referencing Microsoft.NET.Test.Sdk dragged in
Microsoft.TestPlatform.TestHost and the rest of the VSTest execution
stack. Removing it leaves Microsoft.TestPlatform.ObjectModel as the only
VSTest-lineage package the MSTest package brings in - it flows
transitively through the VSTestBridge (alongside the source-only,
non-flowing Filter.Source). Build integration still comes from
Microsoft.Testing.Platform.MSBuild via MSTest.TestAdapter.

Verified against the restore graph (net462;net8.0;net9.0;uap10.0) and a
real packed nuspec: no Test.Sdk, no TestHost, ObjectModel only.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
---
 src/Package/MSTest/MSTest.csproj | 17 ++++++++---------
 1 file changed, 8 insertions(+), 9 deletions(-)

diff --git a/src/Package/MSTest/MSTest.csproj b/src/Package/MSTest/MSTest.csproj
index f971b57182..343a0ced70 100644
--- a/src/Package/MSTest/MSTest.csproj
+++ b/src/Package/MSTest/MSTest.csproj
@@ -49,15 +49,14 @@
   </ItemGroup>
 
   <ItemGroup>
-    <!-- Microsoft.NET.Test.Sdk package is referenced by build system, so omitting it. -->
-    <!-- VSTest is packaging props/targets in build directory of the NuGet package instead of buildTransitive -->
-    <!-- To ensure that this flows to consumers of MSTest metapackage, we set PrivateAssets to none (by default, PrivateAssets includes "build") -->
-    <!-- If VSTest moves from build to buildTransitive, the PrivateAssets here can/should be removed. -->
-    <!-- Currently, VSTest isn't able to move from build to buildTransitive -->
-    <!-- See: https://github.com/microsoft/vstest/pull/3879, -->
-    <!--      https://github.com/microsoft/vstest/issues/4098 -->
-    <!--      https://github.com/microsoft/vstest/pull/4104 -->
-    <PackageReference Include="Microsoft.NET.Test.Sdk" VersionOverride="$(MicrosoftNETTestSdkVersion)" Condition="'$(TargetFramework)' != '$(UwpMinimum)'" PrivateAssets="none" />
+    <!--
+      Microsoft.NET.Test.Sdk (the classic VSTest runner, which drags in Microsoft.TestPlatform.TestHost and the
+      rest of the VSTest execution stack) is intentionally NOT referenced. MSTest runs as a
+      Microsoft.Testing.Platform (MTP) application and does not need the VSTest testhost/runner. Dropping it keeps
+      the MSTest package's only VSTest-lineage dependency down to Microsoft.TestPlatform.ObjectModel, which flows
+      transitively through Microsoft.Testing.Extensions.VSTestBridge (plus the source-only, non-flowing
+      Microsoft.TestPlatform.Filter.Source). MTP build integration is provided by Microsoft.Testing.Platform.MSBuild
+      (flowed via MSTest.TestAdapter), not by Microsoft.NET.Test.Sdk. -->
     <PackageReference Include="Microsoft.Testing.Extensions.CodeCoverage" />
   </ItemGroup>