Skip to content

Commit 188d8cf

Browse files
authored
Fix graphql undefined of issue when have others RESTful API node
Cannot read property 'graphql' of undefined because services of other node also will get into `generateGraphQLSchema` function
1 parent 0a5d04a commit 188d8cf

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

src/service.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -236,7 +236,7 @@ module.exports = function(mixinOptions) {
236236
if (processedServices.has(serviceName)) return;
237237
processedServices.add(serviceName);
238238

239-
if (service.settings.graphql) {
239+
if (service.settings && service.settings.graphql) {
240240
// --- COMPILE SERVICE-LEVEL DEFINITIONS ---
241241
if (_.isObject(service.settings.graphql)) {
242242
const globalDef = service.settings.graphql;
@@ -510,7 +510,9 @@ module.exports = function(mixinOptions) {
510510
createLoaders(req, services) {
511511
return services.reduce((serviceAccum, service) => {
512512
const serviceName = this.getServiceName(service);
513-
513+
if(!service.settings) {
514+
service.settings = {}
515+
}
514516
const { graphql } = service.settings;
515517
if (graphql && graphql.resolvers) {
516518
const { resolvers } = graphql;

0 commit comments

Comments
 (0)