remove default prepareContextParams method

Author: icebob

.eslintrc.js

@@ -14,7 +14,6 @@ module.exports = {
 	},
 	plugins: ["node", "promise", "security"],
 	rules: {
-		quotes: ["warn", "double"],
 		semi: ["error", "always"],
 		"no-var": ["error"],
 		"no-console": ["error"],
@@ -28,14 +27,5 @@ module.exports = {
 		"no-process-exit": ["off"],
 		"node/no-unpublished-require": 0,
 		"require-atomic-updates": 0,
-		"space-before-function-paren": [
-			"warn",
-			{
-				anonymous: "never",
-				named: "never",
-				asyncArrow: "always",
-			},
-		],
-		"object-curly-spacing": ["warn", "always"],
 	},
 };

src/service.js

@@ -15,7 +15,7 @@ const GraphQL = require("graphql");
 const { PubSub, withFilter } = require("graphql-subscriptions");
 const hash = require("object-hash");
 
-module.exports = function(mixinOptions) {
+module.exports = function (mixinOptions) {
 	mixinOptions = _.defaultsDeep(mixinOptions, {
 		routeOptions: {
 			path: "/graphql",
@@ -266,17 +266,6 @@ module.exports = function(mixinOptions) {
 				};
 			},
 
-			/**
-			 * Prepare the context params before calling the action
-			 * @param {Object} params
-			 * @param {String} actionName
-			 * @param {Context} context
-			 * @returns {Promise<Object>}
-			 */
-			prepareContextParams(params, actionName, context) {
-				return Promise.resolve(params);
-			},
-
 			/**
 			 * Get the unique key assigned to the DataLoader map
 			 * @param {string} actionName - Fully qualified action name to bind to dataloader
@@ -361,6 +350,7 @@ module.exports = function(mixinOptions) {
 			 * @returns {Object} Generated schema
 			 */
 			generateGraphQLSchema(services) {
+				let str;
 				try {
 					let typeDefs = [];
 					let resolvers = {};
@@ -533,7 +523,7 @@ module.exports = function(mixinOptions) {
 						enums.length > 0 ||
 						inputs.length > 0
 					) {
-						let str = "";
+						str = "";
 						if (queries.length > 0) {
 							str += `
 								type Query {
@@ -597,7 +587,7 @@ module.exports = function(mixinOptions) {
 						"Unable to compile GraphQL schema",
 						500,
 						"UNABLE_COMPILE_GRAPHQL_SCHEMA",
-						{ err }
+						{ err, str }
 					);
 				}
 			},

test/integration/greeter.spec.js

@@ -34,6 +34,15 @@ describe("Integration test for greeter service", () => {
 		settings: {
 			port: 0, // Random
 		},
+
+		methods: {
+			prepareContextParams(params, actionName) {
+				if (actionName === "greeter.replace" && params.input) {
+					return params.input;
+				}
+				return params;
+			},
+		},
 	});
 
 	broker.createService({
@@ -68,6 +77,21 @@ describe("Integration test for greeter service", () => {
 				},
 			},*/
 
+			replace: {
+				graphql: {
+					input: `input GreeterInput {
+						name: String!
+					}`,
+					type: `type GreeterOutput {
+						name: String
+					}`,
+					mutation: "replace(input: GreeterInput!): GreeterOutput",
+				},
+				handler(ctx) {
+					return ctx.params;
+				},
+			},
+
 			danger: {
 				graphql: {
 					query: "danger: String!",
@@ -146,6 +170,27 @@ describe("Integration test for greeter service", () => {
 		});
 	});
 
+	it("should call the greeter.welcome action with wrapped input params", async () => {
+		const res = await fetch(`http://localhost:${port}/graphql`, {
+			method: "post",
+			body: JSON.stringify({
+				operationName: null,
+				variables: { name: "Moleculer GraphQL" },
+				query: "mutation ($name: String!) { replace(input: { name: $name }) { name } }",
+			}),
+			headers: { "Content-Type": "application/json" },
+		});
+
+		expect(res.status).toBe(200);
+		expect(await res.json()).toStrictEqual({
+			data: {
+				replace: {
+					name: "Moleculer GraphQL",
+				},
+			},
+		});
+	});
+
 	it("should call the greeter.danger and receives an error", async () => {
 		const res = await fetch(`http://localhost:${port}/graphql`, {
 			method: "post",

test/unit/service.spec.js

@@ -391,58 +391,6 @@ describe("Test Service", () => {
 		});
 	});
 
-	describe("Test 'prepareContextParams' method", () => {
-		let broker, svc, stop;
-
-		beforeAll(async () => {
-			const res = await startService();
-			broker = res.broker;
-			svc = res.svc;
-			stop = res.stop;
-		});
-
-		afterAll(async () => await stop());
-
-		it("should return the context params", async () => {
-			const params = {
-				a: 5,
-			};
-
-			expect(await svc.prepareContextParams(params)).toEqual({ a: 5 });
-		});
-
-		it("should return the modified params", async () => {
-			svc.prepareContextParams = jest.fn(params => {
-				return {
-					...params,
-					b: 10,
-				};
-			});
-
-			const params = {
-				a: 5,
-			};
-
-			expect(await svc.prepareContextParams(params)).toEqual({ a: 5, b: 10 });
-
-			expect(svc.prepareContextParams).toBeCalledTimes(1);
-			expect(svc.prepareContextParams).toBeCalledWith(params);
-		});
-
-		it("should return the unwrapped params", async () => {
-			svc.prepareContextParams = jest.fn(async params => params.input);
-
-			const params = {
-				input: { a: 5 },
-			};
-
-			expect(await svc.prepareContextParams(params)).toEqual({ a: 5 });
-
-			expect(svc.prepareContextParams).toBeCalledTimes(1);
-			expect(svc.prepareContextParams).toBeCalledWith(params);
-		});
-	});
-
 	describe("Test 'createServiceResolvers'", () => {
 		it("should call actionResolvers", async () => {
 			const { svc, stop } = await startService();