Merge pull request #66270 from nextcloud/backport/66269/stable27

[stable27] [stable28] [stable32] fix: Reject login with NUL bytes rather than converting

Author: artonge

lib/private/User/Manager.php

@@ -255,7 +255,12 @@ public function checkPassword($loginName, $password) {
 	 * @return IUser|false the User object on success, false otherwise
 	 */
 	public function checkPasswordNoLogging($loginName, $password) {
-		$loginName = str_replace("\0", '', $loginName);
+		// A NUL byte in the login name must not turn it into a second name for an
+		// account: the checks done before the password check (e.g. 2FA enforcement
+		// in Session::logClientIn()) see the name as sent, so the name has to stay the same
+		if (str_contains($loginName, "\0")) {
+			return false;
+		}
 		$password = str_replace("\0", '', $password);
 
 		$cachedBackend = $this->cache->get($loginName);

tests/lib/User/ManagerTest.php

@@ -62,8 +62,7 @@ public function testGetBackends() {
 		$this->assertEquals([$userDummyBackend, $dummyDatabaseBackend], $manager->getBackends());
 	}
 
-
-	public function testUserExistsSingleBackendExists() {
+	public function testUserExistsSingleBackendExists(): void {
 		/**
 		 * @var \Test\Util\User\Dummy | \PHPUnit\Framework\MockObject\MockObject $backend
 		 */
@@ -196,7 +195,28 @@ public function testCheckPasswordNotSupported() {
 		$this->assertFalse($manager->checkPassword('foo', 'bar'));
 	}
 
-	public function testGetOneBackendExists() {
+	public function testCheckPasswordNullByteInLoginName(): void {
+		$backend = $this->createMock(\Test\Util\User\Dummy::class);
+		$backend->expects($this->never())
+			->method('checkPassword');
+
+		$backend->expects($this->any())
+			->method('implementsActions')
+			->willReturnCallback(function ($actions) {
+				if ($actions === BACKEND::CHECK_PASSWORD) {
+					return true;
+				} else {
+					return false;
+				}
+			});
+
+		$manager = new Manager($this->config, $this->cacheFactory, $this->eventDispatcher, $this->logger);
+		$manager->registerBackend($backend);
+
+		$this->assertFalse($manager->checkPassword("foo\0", 'bar'));
+	}
+
+	public function testGetOneBackendExists(): void {
 		/**
 		 * @var \Test\Util\User\Dummy | \PHPUnit\Framework\MockObject\MockObject $backend
 		 */
@@ -347,8 +367,7 @@ public function testCreateUserInvalid($uid, $password, $exception) {
 			->with(\OC\User\Backend::CREATE_USER)
 			->willReturn(true);
 
-
-		$manager = new \OC\User\Manager($this->config, $this->oldDispatcher, $this->cacheFactory, $this->eventDispatcher);
+		$manager = new Manager($this->config, $this->cacheFactory, $this->eventDispatcher, $this->logger);
 		$manager->registerBackend($backend);
 
 		$this->expectException(\InvalidArgumentException::class, $exception);
@@ -382,8 +401,7 @@ public function testCreateUserSingleBackendNotExists() {
 		$this->assertEquals('foo', $user->getUID());
 	}
 
-
-	public function testCreateUserSingleBackendExists() {
+	public function testCreateUserSingleBackendExists(): void {
 		$this->expectException(\Exception::class);
 
 		/**
@@ -435,8 +453,7 @@ public function testCreateUserNoBackends() {
 		$this->assertFalse($manager->createUser('foo', 'bar'));
 	}
 
-
-	public function testCreateUserFromBackendWithBackendError() {
+	public function testCreateUserFromBackendWithBackendError(): void {
 		$this->expectException(\InvalidArgumentException::class);
 		$this->expectExceptionMessage('Could not create user');
 
@@ -454,8 +471,7 @@ public function testCreateUserFromBackendWithBackendError() {
 		$manager->createUserFromBackend('MyUid', 'MyPassword', $backend);
 	}
 
-
-	public function testCreateUserTwoBackendExists() {
+	public function testCreateUserTwoBackendExists(): void {
 		$this->expectException(\Exception::class);
 
 		/**