Skip to content

Commit e8e4418

Browse files
Nima21claude
andcommitted
fix: merge both chromeArgs and chromeArg CLI options
The upstream merge introduced a second CLI option --chromeArg (array) alongside the existing --chromeArgs (comma-separated string), but main.ts only read args.chromeArg, silently ignoring --chromeArgs values. This caused Chrome to launch without critical flags like --no-sandbox, resulting in "Target closed" errors in sandboxed environments. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 8d20e8d commit e8e4418

5 files changed

Lines changed: 11 additions & 8 deletions

File tree

.release-please-manifest.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
{
2-
".": "0.17.3"
2+
".": "0.17.4"
33
}

package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@nimbus21.ai/chrome-devtools-mcp",
3-
"version": "0.17.3",
3+
"version": "0.17.4",
44
"description": "MCP server for Chrome DevTools with stealth mode support",
55
"type": "module",
66
"bin": "./build/src/index.js",

server.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,13 @@
77
"url": "https://github.com/ChromeDevTools/chrome-devtools-mcp",
88
"source": "github"
99
},
10-
"version": "0.17.3",
10+
"version": "0.17.4",
1111
"packages": [
1212
{
1313
"registryType": "npm",
1414
"registryBaseUrl": "https://registry.npmjs.org",
1515
"identifier": "chrome-devtools-mcp",
16-
"version": "0.17.3",
16+
"version": "0.17.4",
1717
"transport": {
1818
"type": "stdio"
1919
},

src/main.ts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ import {tools} from './tools/tools.js';
3131

3232
// If moved update release-please config
3333
// x-release-please-start-version
34-
const VERSION = '0.17.3';
34+
const VERSION = '0.17.4';
3535
// x-release-please-end
3636

3737
export const args = parseArguments(VERSION);
@@ -77,7 +77,10 @@ server.server.setRequestHandler(SetLevelRequestSchema, () => {
7777

7878
let context: McpContext;
7979
async function getContext(): Promise<McpContext> {
80-
const chromeArgs: string[] = (args.chromeArg ?? []).map(String);
80+
const chromeArgs: string[] = [
81+
...(args.chromeArg ?? []).map(String),
82+
...((args.chromeArgs as string[] | undefined) ?? []).map(String),
83+
];
8184
const ignoreDefaultChromeArgs: string[] = (
8285
args.ignoreDefaultChromeArg ?? []
8386
).map(String);

0 commit comments

Comments
 (0)