fix: don't filter picks based on modified date after all

Author: serhalp

modules/runtime/server/cache.ts

@@ -246,14 +246,14 @@ function getMockForUrl(url: string): MockResult | null {
     return {
       data: {
         hits: [
-          { name: 'nuxt', downloadsLast30Days: 500_000, modified: new Date().toISOString() },
-          { name: 'pnpm', downloadsLast30Days: 800_000, modified: new Date().toISOString() },
-          { name: 'express', downloadsLast30Days: 1_000_000, modified: new Date().toISOString() },
-          { name: 'minimatch', downloadsLast30Days: 600_000, modified: new Date().toISOString() },
-          { name: 'next', downloadsLast30Days: 700_000, modified: new Date().toISOString() },
-          { name: 'axios', downloadsLast30Days: 900_000, modified: new Date().toISOString() },
-          { name: 'remix', downloadsLast30Days: 400_000, modified: new Date().toISOString() },
-          { name: 'webpack', downloadsLast30Days: 750_000, modified: new Date().toISOString() },
+          { name: 'nuxt', downloadsLast30Days: 500_000 },
+          { name: 'pnpm', downloadsLast30Days: 800_000 },
+          { name: 'express', downloadsLast30Days: 1_000_000 },
+          { name: 'minimatch', downloadsLast30Days: 600_000 },
+          { name: 'next', downloadsLast30Days: 700_000 },
+          { name: 'axios', downloadsLast30Days: 900_000 },
+          { name: 'remix', downloadsLast30Days: 400_000 },
+          { name: 'webpack', downloadsLast30Days: 750_000 },
         ],
       },
     }

server/api/picks.get.ts

@@ -3,7 +3,6 @@ import {
   NPMX_LETTERS,
   ALGOLIA_POOL_SIZE,
   MIN_DOWNLOADS_LAST_30_DAYS,
-  MAX_MODIFIED_AGE_MS,
   LIKES_SAMPLE_SIZE,
   selectPicks,
   type NpmxLetter,
@@ -27,7 +26,6 @@ function randomSample<T>(arr: T[], n: number): T[] {
 interface AlgoliaHit {
   name: string
   downloadsLast30Days: number
-  modified: string
   isDeprecated?: boolean
 }
 
@@ -62,7 +60,6 @@ export default defineCachedEventHandler(
     const pool = algoliaResponse.hits.filter(hit => {
       if (hit.isDeprecated) return false
       if (hit.downloadsLast30Days < MIN_DOWNLOADS_LAST_30_DAYS) return false
-      if (now - new Date(hit.modified).getTime() > MAX_MODIFIED_AGE_MS) return false
       return true
     })
 

server/utils/picks.ts

@@ -5,7 +5,6 @@ export type NpmxLetter = (typeof NPMX_LETTERS)[number]
 
 export const MIN_LIKES = 5
 export const MIN_DOWNLOADS_LAST_30_DAYS = 10_000
-export const MAX_MODIFIED_AGE_MS = 730 * 24 * 60 * 60 * 1000
 export const ALGOLIA_POOL_SIZE = 500
 export const LIKES_SAMPLE_SIZE = 30
 

test/fixtures/mock-routes.cjs

@@ -527,14 +527,14 @@ function matchGitHubApi(urlString) {
 function matchAlgoliaApi(_urlString) {
   return json({
     hits: [
-      { name: 'nuxt', downloadsLast30Days: 500000, modified: new Date().toISOString() },
-      { name: 'pnpm', downloadsLast30Days: 800000, modified: new Date().toISOString() },
-      { name: 'express', downloadsLast30Days: 1000000, modified: new Date().toISOString() },
-      { name: 'minimatch', downloadsLast30Days: 600000, modified: new Date().toISOString() },
-      { name: 'next', downloadsLast30Days: 700000, modified: new Date().toISOString() },
-      { name: 'axios', downloadsLast30Days: 900000, modified: new Date().toISOString() },
-      { name: 'remix', downloadsLast30Days: 400000, modified: new Date().toISOString() },
-      { name: 'webpack', downloadsLast30Days: 750000, modified: new Date().toISOString() },
+      { name: 'nuxt', downloadsLast30Days: 500000 },
+      { name: 'pnpm', downloadsLast30Days: 800000 },
+      { name: 'express', downloadsLast30Days: 1000000 },
+      { name: 'minimatch', downloadsLast30Days: 600000 },
+      { name: 'next', downloadsLast30Days: 700000 },
+      { name: 'axios', downloadsLast30Days: 900000 },
+      { name: 'remix', downloadsLast30Days: 400000 },
+      { name: 'webpack', downloadsLast30Days: 750000 },
     ],
   })
 }