Skip to content

Commit 03584bd

Browse files
committed
don't render 'unknown'
1 parent 93babd2 commit 03584bd

File tree

3 files changed

+14
-8
lines changed

3 files changed

+14
-8
lines changed

app/components/Compare/ReplacementSuggestion.vue

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -41,11 +41,14 @@ const nodeVersion = computed(() => {
4141
<p class="text-xs mt-0.5 opacity-80">
4242
<template v-if="replacement.type === 'native'">
4343
{{
44-
$t('package.replacement.native', {
45-
replacement:
46-
replacement.nodeFeatureId?.moduleName || replacement.description || replacement.id,
47-
nodeVersion: nodeVersion || 'unknown',
48-
})
44+
nodeVersion
45+
? $t('package.replacement.native', {
46+
replacement: replacement.description || replacement.id,
47+
nodeVersion,
48+
})
49+
: $t('package.replacement.native_no_version', {
50+
replacement: replacement.description || replacement.id,
51+
})
4952
}}
5053
</template>
5154
<template v-else-if="replacement.type === 'simple'">

app/components/Package/Replacement.vue

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,9 @@ const nodeVersion = computed(() => {
2424
</h2>
2525
<i18n-t
2626
v-if="replacement.type === 'native'"
27-
keypath="package.replacement.native"
27+
:keypath="
28+
nodeVersion ? 'package.replacement.native' : 'package.replacement.native_no_version'
29+
"
2830
scope="global"
2931
>
3032
<template #replacement>
@@ -33,8 +35,8 @@ const nodeVersion = computed(() => {
3335
</code>
3436
<span v-else>{{ replacement.id }}</span>
3537
</template>
36-
<template #nodeVersion>
37-
{{ nodeVersion || 'unknown' }}
38+
<template v-if="nodeVersion" `#nodeVersion`>
39+
{{ nodeVersion }}
3840
</template>
3941
</i18n-t>
4042
<div v-else-if="replacement.type === 'simple'" class="block">

i18n/locales/en.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -246,6 +246,7 @@
246246
"replacement": {
247247
"title": "You might not need this dependency.",
248248
"native": "This can be replaced with {replacement}, available since Node {nodeVersion}.",
249+
"native_no_version": "This can be replaced with {replacement}.",
249250
"simple": "The {community} has flagged this package as redundant, with the advice: {replacement}.",
250251
"documented": "The {community} has flagged this package as having more performant alternatives.",
251252
"none": "This package has been flagged as no longer needed, and its functionality is likely available natively in all engines.",

0 commit comments

Comments
 (0)