refactor: remove instances of "all"

Author: MatteoGabriele

app/components/Package/List.vue

@@ -75,18 +75,15 @@ const paginationMode = computed(() =>
 )
 const currentPage = computed(() => props.currentPage ?? 1)
 const pageSize = computed(() => props.pageSize ?? 25)
-// Numeric page size for virtual scroll and arithmetic (when 'all' is selected, use 25 as default)
-const numericPageSize = computed(() => (pageSize.value === 'all' ? 25 : pageSize.value))
+// Numeric page size for virtual scroll and arithmetic (use 25 as default)
+const numericPageSize = computed(() => pageSize.value)
 
 // Compute paginated results for paginated mode
 const displayedResults = computed(() => {
   if (paginationMode.value === 'infinite') {
     return props.results
   }
-  // 'all' page size means show everything (YOLO)
-  if (pageSize.value === 'all') {
-    return props.results
-  }
+
   const start = (currentPage.value - 1) * numericPageSize.value
   const end = start + numericPageSize.value
   return props.results.slice(start, end)

app/components/Package/ListToolbar.vue

@@ -147,7 +147,7 @@ function getSortKeyLabelKey(key: SortKey): string {
           $t(
             'filters.count.showing_paginated',
             {
-              pageSize: pageSize === 'all' ? $n(filteredCount) : Math.min(pageSize, filteredCount),
+              pageSize: Math.min(pageSize, filteredCount),
               count: $n(filteredCount),
             },
             filteredCount,

app/pages/org/[org].vue

@@ -65,8 +65,7 @@ const currentPage = shallowRef(1)
 
 // Calculate total pages
 const totalPages = computed(() => {
-  if (pageSize.value === 'all') return 1
-  const numericSize = typeof pageSize.value === 'number' ? pageSize.value : 25
+  const numericSize = pageSize.value ?? 25
   return Math.ceil(sortedPackages.value.length / numericSize)
 })
 

app/pages/search.vue

@@ -164,7 +164,7 @@ const EAGER_LOAD_SIZE = { algolia: 500, npm: 500 } as const
 
 // Calculate how many results we need based on current page and preferred page size
 const requestedSize = computed(() => {
-  const numericPrefSize = preferredPageSize.value === 'all' ? 250 : preferredPageSize.value
+  const numericPrefSize = preferredPageSize.value
   const base = Math.max(pageSize, currentPage.value * numericPrefSize)
   // When sorting by something other than relevance, fetch a large batch
   // so client-side sorting operates on a meaningful pool of matching results
@@ -587,10 +587,8 @@ const rawLiveRegionMessage = computed(() => {
 
   if (visibleResults.value && displayResults.value.length > 0) {
     if (viewMode.value === 'table' || paginationMode.value === 'paginated') {
-      const pSize =
-        preferredPageSize.value === 'all'
-          ? $n(effectiveTotal.value)
-          : Math.min(preferredPageSize.value, effectiveTotal.value)
+      const pSize = Math.min(preferredPageSize.value, effectiveTotal.value)
+
       return $t(
         'filters.count.showing_paginated',
         {
@@ -781,10 +779,7 @@ onBeforeUnmount(() => {
                 $t(
                   'filters.count.showing_paginated',
                   {
-                    pageSize:
-                      preferredPageSize === 'all'
-                        ? $n(effectiveTotal)
-                        : Math.min(preferredPageSize, effectiveTotal),
+                    pageSize: Math.min(preferredPageSize, effectiveTotal),
                     count: $n(effectiveTotal),
                   },
                   effectiveTotal,