Skip to content

Commit 0a2b395

Browse files
authored
chore: remove vacations from lunaria and compare logic (#1441)
1 parent 2f31cc4 commit 0a2b395

File tree

4 files changed

+7
-72
lines changed

4 files changed

+7
-72
lines changed

lunaria/files/en-GB.json

Lines changed: 0 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -1111,40 +1111,5 @@
11111111
"p1": "If you encounter an accessibility barrier on {app}, please let us know by opening an issue on our {link}. We take these reports seriously and will do our best to address them.",
11121112
"link": "GitHub repository"
11131113
}
1114-
},
1115-
"vacations": {
1116-
"title": "on vacation",
1117-
"meta_description": "The npmx team is recharging. Discord reopens in a week.",
1118-
"heading": "recharging",
1119-
"subtitle": "we've been building npmx at a pace that has cost {some} of us sleep. we don't want that to be the norm! so we are taking a week off. together.",
1120-
"illustration_alt": "a single row of cosy icons",
1121-
"poke_log": "Poke the campfire",
1122-
"what": {
1123-
"title": "what's happening",
1124-
"p1": "discord is closed {dates}.",
1125-
"dates": "February 14 – 21",
1126-
"p2": "all invite links are gone and channels are locked – except {garden}, which stays open for folks who want to keep hanging out.",
1127-
"garden": "#garden"
1128-
},
1129-
"meantime": {
1130-
"title": "in the meantime",
1131-
"p1": "{site} and {repo} stay open – dig in, file issues, open PRs. we'll get to everything when we're back. just don't expect a fast review. we'll be somewhere near a cosy fireplace.",
1132-
"repo_link": "the repo"
1133-
},
1134-
"return": {
1135-
"title": "see you soon",
1136-
"p1": "we'll come back recharged and ready for the final push to March 3rd. {social} for updates.",
1137-
"social_link": "follow us on Bluesky",
1138-
"add_to_calendar": "remind me when Discord reopens"
1139-
},
1140-
"stats": {
1141-
"contributors": "Contributors",
1142-
"commits": "Commits",
1143-
"pr": "PRs Merged",
1144-
"subtitle": {
1145-
"some": "some",
1146-
"all": "all"
1147-
}
1148-
}
11491114
}
11501115
}

lunaria/files/en-US.json

Lines changed: 0 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -1111,40 +1111,5 @@
11111111
"p1": "If you encounter an accessibility barrier on {app}, please let us know by opening an issue on our {link}. We take these reports seriously and will do our best to address them.",
11121112
"link": "GitHub repository"
11131113
}
1114-
},
1115-
"vacations": {
1116-
"title": "on vacation",
1117-
"meta_description": "The npmx team is recharging. Discord reopens in a week.",
1118-
"heading": "recharging",
1119-
"subtitle": "we've been building npmx at a pace that has cost {some} of us sleep. we don't want that to be the norm! so we are taking a week off. together.",
1120-
"illustration_alt": "a single row of cosy icons",
1121-
"poke_log": "Poke the campfire",
1122-
"what": {
1123-
"title": "what's happening",
1124-
"p1": "discord is closed {dates}.",
1125-
"dates": "February 14 – 21",
1126-
"p2": "all invite links are gone and channels are locked – except {garden}, which stays open for folks who want to keep hanging out.",
1127-
"garden": "#garden"
1128-
},
1129-
"meantime": {
1130-
"title": "in the meantime",
1131-
"p1": "{site} and {repo} stay open – dig in, file issues, open PRs. we'll get to everything when we're back. just don't expect a fast review. we'll be somewhere near a cosy fireplace.",
1132-
"repo_link": "the repo"
1133-
},
1134-
"return": {
1135-
"title": "see you soon",
1136-
"p1": "we'll come back recharged and ready for the final push to March 3rd. {social} for updates.",
1137-
"social_link": "follow us on Bluesky",
1138-
"add_to_calendar": "remind me when Discord reopens"
1139-
},
1140-
"stats": {
1141-
"contributors": "Contributors",
1142-
"commits": "Commits",
1143-
"pr": "PRs Merged",
1144-
"subtitle": {
1145-
"some": "some",
1146-
"all": "all"
1147-
}
1148-
}
11491114
}
11501115
}

lunaria/prepare-json-files.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,9 +66,11 @@ export async function mergeLocaleObject(locale: LocaleObject): Promise<NestedObj
6666

6767
async function loadLocaleSourceJson<T = unknown>(name: string): Promise<T> {
6868
const rawJson = JSON.parse(await fs.readFile(path.resolve(`${localesFolder}/${name}`), 'utf8'))
69-
// Exclude $schema since it isn't useful in generated files and the relative path
69+
// Exclude $schema since it isn't useful in generated files and the relative
70+
71+
// TODO: removing vacations entry key for temporal recharging page
7072
// would be wrong anyway
71-
const { $schema: _, ...rest } = rawJson
73+
const { $schema: _, vacations: __, ...rest } = rawJson
7274
return rest
7375
}
7476

scripts/compare-translations.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -385,6 +385,9 @@ const run = async (): Promise<void> => {
385385
lang: 'en',
386386
})
387387

388+
// TODO: removing vacations entry key for temporal recharging page
389+
delete referenceContent.vacations
390+
388391
// $schema is a JSON Schema reference, not a translation key
389392
delete referenceContent.$schema
390393

0 commit comments

Comments
 (0)