Skip to content

Commit 0d5352b

Browse files
refactor: move checkbox in table to the left side
1 parent d88e8b4 commit 0d5352b

File tree

2 files changed

+14
-15
lines changed

2 files changed

+14
-15
lines changed

app/components/Package/Table.vue

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -115,6 +115,9 @@ function getColumnLabel(id: ColumnId): string {
115115
<table class="w-full text-start">
116116
<thead class="border-b border-border">
117117
<tr>
118+
<th scope="col" class="w-8">
119+
<span class="sr-only">{{ getColumnLabel('selection') }}</span>
120+
</th>
118121
<!-- Name (always visible) -->
119122
<th
120123
scope="col"
@@ -300,15 +303,15 @@ function getColumnLabel(id: ColumnId): string {
300303
>
301304
{{ getColumnLabel('security') }}
302305
</th>
303-
<th scope="col" class="w-8">
304-
<span class="sr-only">{{ getColumnLabel('selection') }}</span>
305-
</th>
306306
</tr>
307307
</thead>
308308
<tbody>
309309
<!-- Loading skeleton rows -->
310310
<template v-if="isLoading && results.length === 0">
311311
<tr v-for="i in 5" :key="`skeleton-${i}`" class="border-b border-border">
312+
<td class="py-3 px-3 w-8">
313+
<div class="h-4 w-4 bg-bg-muted rounded animate-pulse ms-auto" />
314+
</td>
312315
<td class="py-3 px-3">
313316
<div class="h-4 w-32 bg-bg-muted rounded animate-pulse" />
314317
</td>
@@ -330,9 +333,6 @@ function getColumnLabel(id: ColumnId): string {
330333
<td v-if="isColumnVisible('keywords')" class="py-3 px-3">
331334
<div class="h-4 w-32 bg-bg-muted rounded animate-pulse ms-auto" />
332335
</td>
333-
<td class="py-3 px-3 w-8">
334-
<div class="h-4 w-4 bg-bg-muted rounded animate-pulse ms-auto" />
335-
</td>
336336
</tr>
337337
</template>
338338

app/components/Package/TableRow.vue

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,14 @@ const allMaintainersText = computed(() => {
5252
tabindex="0"
5353
:data-result-index="index"
5454
>
55+
<td class="ps-3">
56+
<PackageSelectionCheckbox
57+
:package-name="result.package.name"
58+
:disabled="isMaxSelected && !isSelected"
59+
:checked="isSelected"
60+
@change="togglePackageSelection"
61+
/>
62+
</td>
5563
<!-- Name (always visible) -->
5664
<td class="py-2 px-3">
5765
<NuxtLink
@@ -200,15 +208,6 @@ const allMaintainersText = computed(() => {
200208
</span>
201209
<span v-else class="text-fg-subtle"> - </span>
202210
</td>
203-
204-
<td class="pe-2">
205-
<PackageSelectionCheckbox
206-
:package-name="result.package.name"
207-
:disabled="isMaxSelected && !isSelected"
208-
:checked="isSelected"
209-
@change="togglePackageSelection"
210-
/>
211-
</td>
212211
</tr>
213212
</template>
214213

0 commit comments

Comments
 (0)