Skip to content

Commit 0e49505

Browse files
committed
chore: make footer accessible with infinite scroll pages
1 parent 263651e commit 0e49505

2 files changed

Lines changed: 18 additions & 8 deletions

File tree

app/app.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ onUnmounted(() => {
5050

5151
<AppHeader :show-logo="!isHomepage" />
5252

53-
<div id="main-content" class="flex-1">
53+
<div id="main-content" class="flex-1 pb-20 sm:pb-24">
5454
<NuxtPage />
5555
</div>
5656

app/components/AppFooter.vue

Lines changed: 17 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,33 @@
11
<template>
2-
<footer class="border-t border-border mt-auto">
3-
<div class="container py-8 flex flex-col gap-4 text-fg-subtle text-sm">
4-
<div class="flex flex-col sm:flex-row items-center justify-between gap-4">
2+
<footer
3+
role="contentinfo"
4+
aria-label="Site footer"
5+
class="fixed bottom-0 left-0 right-0 z-30 bg-bg/90 backdrop-blur-md border-t border-border"
6+
>
7+
<div
8+
class="container py-3 sm:py-4 flex flex-col gap-2 sm:gap-4 text-fg-subtle text-xs sm:text-sm"
9+
>
10+
<div class="flex flex-col sm:flex-row items-center justify-between gap-2 sm:gap-4">
511
<p class="font-mono m-0">a better browser for the npm registry</p>
6-
<div class="flex items-center gap-6">
12+
<div class="flex items-center gap-4 sm:gap-6">
713
<a
814
href="https://github.com/danielroe/npmx.dev"
915
rel="noopener noreferrer"
10-
class="link-subtle font-mono text-xs"
16+
class="link-subtle font-mono text-xs min-h-11 min-w-11 flex items-center"
1117
>
1218
source
1319
</a>
1420
<span class="text-border">|</span>
15-
<a href="https://roe.dev" rel="noopener noreferrer" class="link-subtle font-mono text-xs">
21+
<a
22+
href="https://roe.dev"
23+
rel="noopener noreferrer"
24+
class="link-subtle font-mono text-xs min-h-11 min-w-11 flex items-center"
25+
>
1626
@danielroe
1727
</a>
1828
</div>
1929
</div>
20-
<p class="text-xs text-fg-subtle/60 text-center sm:text-left m-0">
30+
<p class="text-xs text-fg-subtle/60 text-center sm:text-left m-0 hidden sm:block">
2131
npm is a registered trademark of npm, Inc. This site is not affiliated with npm, Inc.
2232
</p>
2333
</div>

0 commit comments

Comments
 (0)