Skip to content

Commit 0eb48b6

Browse files
fix(ui): wire description field and improve health score test coverage
1 parent e95160e commit 0eb48b6

2 files changed

Lines changed: 9 additions & 8 deletions

File tree

app/composables/usePackageComparison.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,7 @@ export function usePackageComparison(packageNames: MaybeRefOrGetter<string[]>) {
162162
package: {
163163
name: pkgData.name,
164164
version: latestVersion,
165-
description: undefined,
165+
description: pkgData.description,
166166
},
167167
downloads: downloads?.downloads,
168168
packageSize,

test/nuxt/composables/use-package-comparison.spec.ts

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -128,15 +128,15 @@ describe('usePackageComparison', () => {
128128
})
129129
})
130130

131-
describe('computeHealthScore', () => {
132-
function makeData(overrides: Partial<PackageComparisonData> = {}): PackageComparisonData {
133-
return {
134-
package: { name: 'test', version: '1.0.0' },
135-
directDeps: 2,
136-
...overrides,
137-
}
131+
function makeData(overrides: Partial<PackageComparisonData> = {}): PackageComparisonData {
132+
return {
133+
package: { name: 'test', version: '1.0.0' },
134+
directDeps: 2,
135+
...overrides,
138136
}
137+
}
139138

139+
describe('computeHealthScore', () => {
140140
it('returns score 0 for deprecated packages', () => {
141141
const score = computeHealthScore(makeData({ metadata: { deprecated: 'Use something else' } }))
142142
expect(score).toBe(0)
@@ -145,6 +145,7 @@ describe('usePackageComparison', () => {
145145
it('returns high score for a perfect package', () => {
146146
const score = computeHealthScore(
147147
makeData({
148+
package: { name: 'test', version: '1.0.0', description: 'A test package' },
148149
metadata: {
149150
lastUpdated: new Date().toISOString(),
150151
license: 'MIT',

0 commit comments

Comments
 (0)