test: fixes

Author: danielroe

app/composables/useNpmRegistry.ts

@@ -57,10 +57,10 @@ const RECENT_VERSIONS_COUNT = 5
  * Transform a full Packument into a slimmed version for client-side use.
  * Reduces payload size by:
  * - Removing readme (fetched separately)
- * - Including only: 5 most recent versions + one version per dist-tag
+ * - Including only: 5 most recent versions + one version per dist-tag + requested version
  * - Stripping unnecessary fields from version objects
  */
-function transformPackument(pkg: Packument): SlimPackument {
+function transformPackument(pkg: Packument, requestedVersion?: string | null): SlimPackument {
   // Get versions pointed to by dist-tags
   const distTagVersions = new Set(Object.values(pkg['dist-tags'] ?? {}))
 
@@ -75,9 +75,14 @@ function transformPackument(pkg: Packument): SlimPackument {
     })
     .slice(0, RECENT_VERSIONS_COUNT)
 
-  // Combine: recent versions + dist-tag versions (deduplicated)
+  // Combine: recent versions + dist-tag versions + requested version (deduplicated)
   const includedVersions = new Set([...recentVersions, ...distTagVersions])
 
+  // Add the requested version if it exists in the package
+  if (requestedVersion && pkg.versions[requestedVersion]) {
+    includedVersions.add(requestedVersion)
+  }
+
   // Build filtered versions object
   const filteredVersions: Record<string, PackumentVersion> = {}
   for (const v of includedVersions) {
@@ -115,10 +120,10 @@ function transformPackument(pkg: Packument): SlimPackument {
   }
 }
 
-export function usePackage(name: MaybeRefOrGetter<string>) {
+export function usePackage(name: MaybeRefOrGetter<string>, requestedVersion?: MaybeRefOrGetter<string | null>) {
   return useLazyAsyncData(
-    () => `package:${toValue(name)}`,
-    () => fetchNpmPackage(toValue(name)).then(r => transformPackument(r)),
+    () => `package:${toValue(name)}:${toValue(requestedVersion) ?? ''}`,
+    () => fetchNpmPackage(toValue(name)).then(r => transformPackument(r, toValue(requestedVersion))),
   )
 }
 

app/pages/package/[...name].vue

@@ -40,12 +40,12 @@ const orgName = computed(() => {
   return match ? match[1] : null
 })
 
-const { data: pkg, status, error } = usePackage(packageName)
+const { data: pkg, status, error } = usePackage(packageName, requestedVersion)
 
 const { data: downloads } = usePackageDownloads(packageName, 'last-week')
 
 // Fetch README for specific version if requested, otherwise latest
-const { data: readmeData } = useLazyFetch(() => {
+const { data: readmeData } = useLazyFetch<{ html: string }>(() => {
   const base = `/api/registry/readme/${packageName.value}`
   const version = requestedVersion.value
   return version ? `${base}/v/${version}` : base

package.json

@@ -15,7 +15,7 @@
     "generate": "nuxt generate",
     "preview": "nuxt preview",
     "postinstall": "nuxt prepare && simple-git-hooks",
-    "test:types": "vue-tsc -b --noEmit",
+    "test:types": "nuxt prepare && vue-tsc -b --noEmit",
     "test": "vitest",
     "test:coverage": "vitest --coverage",
     "test:unit": "vitest --project unit",