fix: address CodeRabbit review feedback

- Hide dependencies menu item when install size data is unavailable
- Guard against non-OK fetch responses before creating blob
- Use Vue 3.4 same-name shorthand for :size binding
- Remove console.error in favor of silent fallback
- Fix missing test closure in a11y spec

Author: Adebesin-Cell

app/components/Package/DownloadButton.vue

@@ -22,10 +22,17 @@ const dropdownPosition = shallowRef<{ top: number; right: number } | null>(null)
 
 const { t } = useI18n()
 const menuId = useId()
-const menuItems = computed(() => [
-  { id: 'package', label: t('package.download.package'), icon: 'i-lucide:package' },
-  { id: 'dependencies', label: t('package.download.dependencies'), icon: 'i-lucide:list-tree' },
-])
+const menuItems = computed(() => {
+  const items = [{ id: 'package', label: t('package.download.package'), icon: 'i-lucide:package' }]
+  if (props.installSize) {
+    items.push({
+      id: 'dependencies',
+      label: t('package.download.dependencies'),
+      icon: 'i-lucide:list-tree',
+    })
+  }
+  return items
+})
 
 function getDropdownStyle(): Record<string, string> {
   if (!dropdownPosition.value) return {}
@@ -108,6 +115,9 @@ async function downloadPackage() {
 
   try {
     const response = await fetch(tarballUrl)
+    if (!response.ok) {
+      throw new Error(`Failed to fetch tarball (${response.status})`)
+    }
     const blob = await response.blob()
     const url = URL.createObjectURL(blob)
     const link = document.createElement('a')
@@ -117,8 +127,7 @@ async function downloadPackage() {
     link.click()
     document.body.removeChild(link)
     URL.revokeObjectURL(url)
-  } catch (error) {
-    console.error('Failed to download package:', error)
+  } catch {
     // Fallback to direct link for non-CORS or other issues, though download attribute may be ignored
     const link = document.createElement('a')
     link.href = tarballUrl
@@ -183,7 +192,7 @@ defineOptions({
     v-bind="$attrs"
     type="button"
     :variant="size === 'small' ? 'subtle' : 'secondary'"
-    :size="size"
+    :size
     classicon="i-lucide:download"
     :aria-expanded="isOpen"
     aria-haspopup="menu"

test/nuxt/a11y.spec.ts

@@ -3332,6 +3332,12 @@ describe('component accessibility audits', () => {
           hunks: [],
           type: 'modify',
           fileName: 'empty.ts',
+        },
+      })
+      const results = await runAxe(component)
+      expect(results.violations).toEqual([])
+    })
+  })
 
   describe('DiffSidebarPanel', () => {
     const mockCompare = {