Skip to content

Commit 17558ec

Browse files
committed
fix: unformatted numbers
1 parent c0768e6 commit 17558ec

2 files changed

Lines changed: 6 additions & 3 deletions

File tree

app/components/Package/Dependencies.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,7 @@ const numberFormatter = useNumberFormatter()
192192
>
193193
{{
194194
$t('package.peer_dependencies.show_all', {
195-
count: sortedPeerDependencies.length,
195+
count: numberFormatter.format(sortedPeerDependencies.length),
196196
})
197197
}}
198198
</button>

app/composables/usePackageComparison.ts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,7 @@ export interface PackageComparisonData {
7070
*/
7171
export function usePackageComparison(packageNames: MaybeRefOrGetter<string[]>) {
7272
const { t } = useI18n()
73+
const numberFormatter = useNumberFormatter()
7374
const compactNumberFormatter = useCompactNumberFormatter()
7475
const bytesFormatter = useBytesFormatter()
7576
const packages = computed(() => toValue(packageNames))
@@ -264,6 +265,7 @@ export function usePackageComparison(packageNames: MaybeRefOrGetter<string[]>) {
264265
return computeFacetValue(
265266
facet,
266267
pkg,
268+
numberFormatter.value.format,
267269
compactNumberFormatter.value.format,
268270
bytesFormatter.format,
269271
t,
@@ -349,6 +351,7 @@ function resolveNoDependencyDisplay(
349351
function computeFacetValue(
350352
facet: ComparisonFacet,
351353
data: PackageComparisonData,
354+
formatNumber: (num: number) => string,
352355
formatCompactNumber: (num: number) => string,
353356
formatBytes: (num: number) => string,
354357
t: (key: string, params?: Record<string, unknown>) => string,
@@ -522,7 +525,7 @@ function computeFacetValue(
522525
if (depCount == null) return null
523526
return {
524527
raw: depCount,
525-
display: String(depCount),
528+
display: formatNumber(depCount),
526529
status: depCount > 10 ? 'warning' : 'neutral',
527530
}
528531
}
@@ -541,7 +544,7 @@ function computeFacetValue(
541544
const totalDepCount = data.installSize.dependencyCount
542545
return {
543546
raw: totalDepCount,
544-
display: String(totalDepCount),
547+
display: formatNumber(totalDepCount),
545548
status: totalDepCount > 50 ? 'warning' : 'neutral',
546549
}
547550
}

0 commit comments

Comments
 (0)