Skip to content

Commit 191510b

Browse files
authored
fix: display tooltips on focus for install size + create command (#919)
1 parent e1c4c15 commit 191510b

File tree

2 files changed

+17
-13
lines changed

2 files changed

+17
-13
lines changed

app/components/Terminal/Install.vue

Lines changed: 11 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -200,20 +200,19 @@ const copyCreateCommand = () => copyCreate(getFullCreateCommand())
200200
<span class="text-fg-subtle font-mono text-sm select-none"
201201
># {{ $t('package.create.title') }}</span
202202
>
203-
<NuxtLink
204-
:to="`/package/${createPackageInfo.packageName}`"
205-
class="text-fg-muted hover:text-fg text-xs transition-colors focus-visible:outline-accent/70 rounded"
206-
:title="$t('package.create.view', { packageName: createPackageInfo.packageName })"
203+
<TooltipApp
204+
:text="$t('package.create.view', { packageName: createPackageInfo.packageName })"
207205
>
208-
<TooltipApp
209-
:text="$t('package.create.view', { packageName: createPackageInfo.packageName })"
206+
<NuxtLink
207+
:to="`/package/${createPackageInfo.packageName}`"
208+
class="inline-flex items-center justify-center min-w-6 min-h-6 -m-1 p-1 text-fg-muted hover:text-fg text-xs transition-colors focus-visible:outline-2 focus-visible:outline-accent/70 rounded"
210209
>
211-
<span class="i-carbon:information w-3 h-3 mt-1" aria-hidden="true" />
212-
</TooltipApp>
213-
<span class="sr-only">{{
214-
$t('package.create.view', { packageName: createPackageInfo.packageName })
215-
}}</span>
216-
</NuxtLink>
210+
<span class="i-carbon:information w-3 h-3" aria-hidden="true" />
211+
<span class="sr-only">{{
212+
$t('package.create.view', { packageName: createPackageInfo.packageName })
213+
}}</span>
214+
</NuxtLink>
215+
</TooltipApp>
217216
</div>
218217

219218
<div

app/pages/package/[...package].vue

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -863,7 +863,12 @@ defineOgImageComponent('Package', {
863863
<dt class="text-xs text-fg-subtle uppercase tracking-wider flex items-center gap-1">
864864
{{ $t('package.stats.install_size') }}
865865
<TooltipApp :text="sizeTooltip">
866-
<span class="i-carbon:information w-3 h-3 text-fg-subtle" aria-hidden="true" />
866+
<span
867+
tabindex="0"
868+
class="inline-flex items-center justify-center min-w-6 min-h-6 -m-1 p-1 text-fg-subtle cursor-help focus-visible:outline-2 focus-visible:outline-accent/70 rounded"
869+
>
870+
<span class="i-carbon:information w-3 h-3" aria-hidden="true" />
871+
</span>
867872
</TooltipApp>
868873
</dt>
869874
<dd class="font-mono text-sm text-fg">

0 commit comments

Comments
 (0)